Prefer public URLs and fall back to base64 for image inputs

2026-06-08 08:38:53 +08:00
parent 679bfeb9c9
commit ca5e71c8e8
2 changed files with 464 additions and 5 deletions
@@ -4,6 +4,8 @@ import (
 	"context"
 	"encoding/base64"
 	"errors"
+	"net/http"
+	"net/http/httptest"
 	"os"
 	"path/filepath"
 	"testing"
@@ -120,6 +122,183 @@ func TestHydrateProviderRequestAssetsConvertsVolcesImageURLAssetToDataURL(t *tes
 	}
 }

+func TestHydrateProviderRequestAssetsUsesImageCapabilityBase64ForTopLevelImageAsset(t *testing.T) {
+	storageDir := t.TempDir()
+	fileName := "gateway-request-asset-edit-image.png"
+	payload := []byte("edit image bytes")
+	if err := os.WriteFile(filepath.Join(storageDir, fileName), payload, 0o644); err != nil {
+		t.Fatalf("write request asset: %v", err)
+	}
+	service := &Service{cfg: config.Config{LocalUploadedStorageDir: storageDir}}
+	body := map[string]any{
+		"image": map[string]any{
+			"assetRef": map[string]any{
+				"sha256":          "sha-edit-image",
+				"contentType":     "image/png",
+				"url":             "/static/uploaded/" + fileName,
+				"storageProvider": "local_static",
+			},
+			"url": "/static/uploaded/" + fileName,
+		},
+	}
+
+	hydrated, err := service.hydrateProviderRequestAssets(context.Background(), body, store.RuntimeModelCandidate{
+		ModelType: "image_edit",
+		Capabilities: map[string]any{
+			"image_edit": map[string]any{
+				"support_url_input":    false,
+				"support_base64_input": true,
+			},
+		},
+	})
+	if err != nil {
+		t.Fatalf("hydrate request assets: %v", err)
+	}
+	if got, want := stringFromAny(hydrated["image"]), "data:image/png;base64,"+base64.StdEncoding.EncodeToString(payload); got != want {
+		t.Fatalf("unexpected hydrated image data url: got %q want %q", got, want)
+	}
+}
+
+func TestHydrateProviderRequestAssetsImageCapabilityOverridesProviderDataURLDefault(t *testing.T) {
+	service := &Service{}
+	body := map[string]any{
+		"messages": []any{
+			map[string]any{
+				"role": "user",
+				"content": []any{
+					map[string]any{
+						"type": "image_url",
+						"image_url": map[string]any{
+							"url": map[string]any{
+								"assetRef": map[string]any{
+									"sha256":          "sha-url-only-image",
+									"contentType":     "image/png",
+									"url":             "https://cdn.example.com/request.png",
+									"storageProvider": "remote",
+								},
+								"url": "https://cdn.example.com/request.png",
+							},
+						},
+					},
+				},
+			},
+		},
+	}
+
+	hydrated, err := service.hydrateProviderRequestAssets(context.Background(), body, store.RuntimeModelCandidate{
+		Provider:  "volces",
+		ModelType: "image_edit",
+		Capabilities: map[string]any{
+			"image_edit": map[string]any{
+				"support_url_input":    true,
+				"support_base64_input": false,
+			},
+		},
+	})
+	if err != nil {
+		t.Fatalf("hydrate request assets: %v", err)
+	}
+	messages := hydrated["messages"].([]any)
+	message := messages[0].(map[string]any)
+	content := message["content"].([]any)
+	imagePart := content[0].(map[string]any)
+	imageURL := imagePart["image_url"].(map[string]any)
+	if got, want := stringFromAny(imageURL["url"]), "https://cdn.example.com/request.png"; got != want {
+		t.Fatalf("image capability should keep URL despite provider default, got %q want %q", got, want)
+	}
+}
+
+func TestHydrateProviderRequestAssetsUsesBase64ForLocalAssetEvenWhenModelSupportsURL(t *testing.T) {
+	storageDir := t.TempDir()
+	fileName := "gateway-request-asset-local-image.png"
+	payload := []byte("local image bytes")
+	if err := os.WriteFile(filepath.Join(storageDir, fileName), payload, 0o644); err != nil {
+		t.Fatalf("write request asset: %v", err)
+	}
+	service := &Service{cfg: config.Config{LocalUploadedStorageDir: storageDir}}
+	body := map[string]any{
+		"image": map[string]any{
+			"assetRef": map[string]any{
+				"sha256":          "sha-local-image",
+				"contentType":     "image/png",
+				"url":             "/static/uploaded/" + fileName,
+				"storageProvider": "local_static",
+			},
+			"url": "/static/uploaded/" + fileName,
+		},
+	}
+
+	hydrated, err := service.hydrateProviderRequestAssets(context.Background(), body, store.RuntimeModelCandidate{
+		ModelType: "image_edit",
+		Capabilities: map[string]any{
+			"image_edit": map[string]any{
+				"support_url_input":    true,
+				"support_base64_input": true,
+			},
+		},
+	})
+	if err != nil {
+		t.Fatalf("hydrate request assets: %v", err)
+	}
+	if got, want := stringFromAny(hydrated["image"]), "data:image/png;base64,"+base64.StdEncoding.EncodeToString(payload); got != want {
+		t.Fatalf("local asset should fall back to base64, got %q want %q", got, want)
+	}
+}
+
+func TestHydrateProviderRequestAssetsConvertsPlainImageURLWhenModelRequiresBase64(t *testing.T) {
+	payload := []byte{0x89, 'P', 'N', 'G', '\r', '\n', 0x1a, '\n', 0, 0, 0, 0}
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.Header().Set("Content-Type", "image/png")
+		_, _ = w.Write(payload)
+	}))
+	defer server.Close()
+	service := &Service{}
+	body := map[string]any{"image": server.URL + "/source.png"}
+
+	hydrated, err := service.hydrateProviderRequestAssets(context.Background(), body, store.RuntimeModelCandidate{
+		ModelType: "image_edit",
+		Capabilities: map[string]any{
+			"image_edit": map[string]any{
+				"support_url_input":    false,
+				"support_base64_input": true,
+			},
+		},
+	})
+	if err != nil {
+		t.Fatalf("hydrate request assets: %v", err)
+	}
+	if got, want := stringFromAny(hydrated["image"]), "data:image/png;base64,"+base64.StdEncoding.EncodeToString(payload); got != want {
+		t.Fatalf("plain image URL should be converted to data URL, got %q want %q", got, want)
+	}
+}
+
+func TestHydrateProviderRequestAssetsConvertsPrivateImageURLEvenWhenModelSupportsURL(t *testing.T) {
+	payload := []byte{0x89, 'P', 'N', 'G', '\r', '\n', 0x1a, '\n', 1, 2, 3, 4}
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.Header().Set("Content-Type", "image/png")
+		_, _ = w.Write(payload)
+	}))
+	defer server.Close()
+	service := &Service{}
+	body := map[string]any{"image": server.URL + "/source.png"}
+
+	hydrated, err := service.hydrateProviderRequestAssets(context.Background(), body, store.RuntimeModelCandidate{
+		ModelType: "image_edit",
+		Capabilities: map[string]any{
+			"image_edit": map[string]any{
+				"support_url_input":    true,
+				"support_base64_input": true,
+			},
+		},
+	})
+	if err != nil {
+		t.Fatalf("hydrate request assets: %v", err)
+	}
+	if got, want := stringFromAny(hydrated["image"]), "data:image/png;base64,"+base64.StdEncoding.EncodeToString(payload); got != want {
+		t.Fatalf("private image URL should fall back to data URL, got %q want %q", got, want)
+	}
+}
+
 func TestHydrateProviderRequestAssetsKeepsImageURLAssetAsURLForProviderURLDefault(t *testing.T) {
 	service := &Service{}
 	body := map[string]any{