wangbo
fe56aa46b9
原因：公开错误层将平台并发限流误标为上游限流，并把多种上游 4xx 统一压成 400，影响定位和客户端处理。 影响：新增公开错误 source，平台限流使用 gateway_rate_limited，上游请求按安全分类返回对应状态；数据库与管理端继续保留原始错误码、消息和状态用于审计。 验证：Go 全量测试、pnpm test、pnpm lint、pnpm build、pnpm openapi、gofmt 和 diff 检查均通过。
102 lines
5.2 KiB
Go
102 lines
5.2 KiB
Go
package publicerror
|
|
|
|
import (
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestTransportErrorsNeverExposeSocketDetails(t *testing.T) {
|
|
raw := "read tcp 10.42.0.72:54960->47.77.191.126:443: read: connection reset by peer"
|
|
got := FromFields("response_read_error", raw, http.StatusOK, true)
|
|
if got.Code != "upstream_connection_interrupted" || got.HTTPStatus != http.StatusBadGateway || !got.Retryable {
|
|
t.Fatalf("unexpected public error: %+v", got)
|
|
}
|
|
if strings.Contains(got.Message, "10.42.0.72") || strings.Contains(got.Message, "47.77.191.126") {
|
|
t.Fatalf("public error leaked socket details: %+v", got)
|
|
}
|
|
}
|
|
|
|
func TestStorageAndExpiredErrorsHaveStableActions(t *testing.T) {
|
|
storage := FromFields("storage_write_failed", "secret endpoint", 0, true)
|
|
if storage.Category != "storage" || storage.Action != "retry" || storage.HTTPStatus != http.StatusServiceUnavailable {
|
|
t.Fatalf("unexpected storage error: %+v", storage)
|
|
}
|
|
expired := FromFields("binary_result_expired", "local binary result has expired", 0, false)
|
|
if expired.Code != "result_expired" || expired.Action != "resubmit" || expired.HTTPStatus != http.StatusGone {
|
|
t.Fatalf("unexpected expired error: %+v", expired)
|
|
}
|
|
}
|
|
|
|
func TestUnknownServerErrorDoesNotExposeProviderBody(t *testing.T) {
|
|
raw := `provider rejected request: {"account":"secret-project","detail":"internal"}`
|
|
got := FromFields("vendor_opaque_error", raw, http.StatusBadGateway, true)
|
|
if got.Code != "gateway_error" || got.Message == raw || strings.Contains(got.Message, "secret-project") {
|
|
t.Fatalf("unknown provider error was exposed: %+v", got)
|
|
}
|
|
}
|
|
|
|
func TestProviderHTTPErrorDoesNotExposeProviderBody(t *testing.T) {
|
|
raw := `{"error":{"message":"bucket private-a rejected secret-project"}}`
|
|
for _, test := range []struct {
|
|
code string
|
|
status int
|
|
wantCode string
|
|
wantStatus int
|
|
}{
|
|
{code: "http_400", status: http.StatusBadRequest, wantCode: "upstream_invalid_request", wantStatus: http.StatusBadRequest},
|
|
{code: "http_404", status: http.StatusNotFound, wantCode: "upstream_not_found", wantStatus: http.StatusNotFound},
|
|
{code: "http_405", status: http.StatusMethodNotAllowed, wantCode: "upstream_method_not_allowed", wantStatus: http.StatusMethodNotAllowed},
|
|
{code: "http_413", status: http.StatusRequestEntityTooLarge, wantCode: "upstream_payload_too_large", wantStatus: http.StatusRequestEntityTooLarge},
|
|
{code: "http_422", status: http.StatusUnprocessableEntity, wantCode: "upstream_unprocessable_request", wantStatus: http.StatusUnprocessableEntity},
|
|
{code: "auth_failed", status: http.StatusUnauthorized, wantCode: "upstream_auth_failed", wantStatus: http.StatusBadGateway},
|
|
{code: "provider_failed", status: http.StatusForbidden, wantCode: "upstream_auth_failed", wantStatus: http.StatusBadGateway},
|
|
{code: "provider_failed", status: http.StatusTooManyRequests, wantCode: "upstream_rate_limited", wantStatus: http.StatusTooManyRequests},
|
|
{code: "server_error", status: http.StatusBadGateway, wantCode: "upstream_unavailable", wantStatus: http.StatusServiceUnavailable},
|
|
{code: "invalid_response", status: http.StatusOK, wantCode: "upstream_invalid_response", wantStatus: http.StatusBadGateway},
|
|
} {
|
|
got := FromFields(test.code, raw, test.status, true)
|
|
if got.Code != test.wantCode || got.HTTPStatus != test.wantStatus {
|
|
t.Fatalf("%s: unexpected public error: %+v", test.code, got)
|
|
}
|
|
if got.Source != "upstream" {
|
|
t.Fatalf("%s: source = %q, want upstream", test.code, got.Source)
|
|
}
|
|
if strings.Contains(got.Message, "private-a") || strings.Contains(got.Message, "secret-project") {
|
|
t.Fatalf("%s: provider body leaked: %+v", test.code, got)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestGatewayRateLimitIsDistinctFromUpstreamRateLimit(t *testing.T) {
|
|
gateway := FromFields("gateway_rate_limited", "concurrency limit is saturated and queueing is disabled", http.StatusTooManyRequests, true)
|
|
if gateway.Code != "gateway_rate_limited" || gateway.Source != "gateway" || gateway.HTTPStatus != http.StatusTooManyRequests {
|
|
t.Fatalf("unexpected gateway rate limit: %+v", gateway)
|
|
}
|
|
if strings.Contains(gateway.Message, "concurrency") {
|
|
t.Fatalf("gateway rate limit leaked internal details: %+v", gateway)
|
|
}
|
|
|
|
upstream := FromFields("rate_limit", "provider quota exhausted for private account", http.StatusTooManyRequests, true)
|
|
if upstream.Code != "upstream_rate_limited" || upstream.Source != "upstream" || upstream.HTTPStatus != http.StatusTooManyRequests {
|
|
t.Fatalf("unexpected upstream rate limit: %+v", upstream)
|
|
}
|
|
if upstream.Message == "provider quota exhausted for private account" {
|
|
t.Fatalf("upstream rate limit leaked provider details: %+v", upstream)
|
|
}
|
|
}
|
|
|
|
func TestHTTPCodeDerivesOriginalUpstreamStatusWhenStatusIsMissing(t *testing.T) {
|
|
got := FromFields("http_404", "404 page not found", 0, false)
|
|
if got.Code != "upstream_not_found" || got.Source != "upstream" || got.HTTPStatus != http.StatusNotFound {
|
|
t.Fatalf("unexpected derived upstream error: %+v", got)
|
|
}
|
|
}
|
|
|
|
func TestValidationGateKeepsStablePublicCode(t *testing.T) {
|
|
got := FromFields("validation_in_progress", "new production tasks are paused while validation is running", http.StatusServiceUnavailable, true)
|
|
if got.Code != "validation_in_progress" || got.HTTPStatus != http.StatusServiceUnavailable || !got.Retryable {
|
|
t.Fatalf("unexpected validation gate error: %+v", got)
|
|
}
|
|
}
|