From 22ee886476b1155a4b8dcb594d2ba255c360f39a Mon Sep 17 00:00:00 2001 From: "Dr.Lt.Data" Date: Sat, 20 Jan 2024 15:23:49 +0900 Subject: [PATCH] fix: invalid outdated ComfyUI version reporting refactor: warnings --- __init__.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/__init__.py b/__init__.py index 544a30e0..09b180ff 100644 --- a/__init__.py +++ b/__init__.py @@ -28,7 +28,7 @@ except: print(f"[WARN] ComfyUI-Manager: Your ComfyUI version is outdated. Please update to the latest version.") -version = [2, 2, 3] +version = [2, 2, 4] version_str = f"V{version[0]}.{version[1]}" + (f'.{version[2]}' if len(version) > 2 else '') print(f"### Loading: ComfyUI-Manager ({version_str})") @@ -102,7 +102,7 @@ sys.path.append('../..') from torchvision.datasets.utils import download_url -comfy_ui_required_revision = 1240 +comfy_ui_required_revision = 1917 comfy_ui_revision = "Unknown" comfy_ui_commit_date = "" @@ -354,9 +354,9 @@ def __win_check_git_update(path, do_fetch=False, do_update=False): output = output.decode('utf-8').strip() if 'detected dubious' in output: + # fix and try again + safedir_path = path.replace('\\', '/') try: - # fix and try again - safedir_path = path.replace('\\', '/') print(f"[ComfyUI-Manager] Try fixing 'dubious repository' error on '{safedir_path}' repo") process = subprocess.Popen(['git', 'config', '--global', '--add', 'safe.directory', safedir_path], stdout=subprocess.PIPE, stderr=subprocess.PIPE) output, _ = process.communicate() @@ -892,7 +892,7 @@ async def fetch_customnode_list(request): except Exception: return False else: - False + return False json_obj['custom_nodes'] = [record for record in json_obj['custom_nodes'] if not is_ignored_notice(record.get('author'))] @@ -1833,7 +1833,7 @@ async def get_notice(request): markdown_content += f"
Manager: {version_str}" try: - if required_comfyui_revision > int(comfy_ui_revision): + if comfy_ui_required_revision > int(comfy_ui_revision): markdown_content = f'

Your ComfyUI is too OUTDATED!!!

' + markdown_content except: pass @@ -2146,6 +2146,7 @@ async def share_art(request): # get the mime type of the asset assetFileType = mimetypes.guess_type(asset_filepath)[0] + share_website_host = "UNKNOWN" if "comfyworkflows" in share_destinations: share_website_host = "https://comfyworkflows.com" share_endpoint = f"{share_website_host}/api"