wangbo/ComfyUI-Manager
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI-Manager.git synced 2025-12-17 02:12:58 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

security fix

Browse Source 
https://github.com/ltdrdata/ComfyUI-Manager/issues/594
This commit is contained in:
dr.lt.data 2024-04-22 10:16:11 +09:00
parent 8f1b013e26
commit 2e5eb70db3
3 changed files with 15 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glob/manager_core.py
View File

@ -21,7 +21,7 @@ sys.path.append(glob_path)
import cm_global import cm_global
from manager_util import * from manager_util import *
version = [2, 21, 2] version = [2, 21, 3]
version_str = f"V{version[0]}.{version[1]}" + (f'.{version[2]}' if len(version) > 2 else '') version_str = f"V{version[0]}.{version[1]}" + (f'.{version[2]}' if len(version) > 2 else '')
comfyui_manager_path = os.path.abspath(os.path.join(os.path.dirname(__file__), '..')) comfyui_manager_path = os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))

12
glob/manager_server.py
View File

@ -792,11 +792,9 @@ async def fix_custom_node(request):
return web.Response(status=400) return web.Response(status=400)
@PromptServer.instance.routes.get("/customnode/install/git_url") @PromptServer.instance.routes.post("/customnode/install/git_url")
async def install_custom_node_git_url(request): async def install_custom_node_git_url(request):
res = False url = await request.text()
if "url" in request.rel_url.query:
url = request.rel_url.query['url']
res = core.gitclone_install([url]) res = core.gitclone_install([url])
if res: if res:
@ -806,11 +804,9 @@ async def install_custom_node_git_url(request):
return web.Response(status=400) return web.Response(status=400)
@PromptServer.instance.routes.get("/customnode/install/pip") @PromptServer.instance.routes.post("/customnode/install/pip")
async def install_custom_node_git_url(request): async def install_custom_node_git_url(request):
res = False packages = await request.text()
if "packages" in request.rel_url.query:
packages = request.rel_url.query['packages']
core.pip_install(packages.split(' ')) core.pip_install(packages.split(' '))
return web.Response(status=200) return web.Response(status=200)

10
js/common.js
View File

@ -89,7 +89,10 @@ export async function install_pip(packages) {
if(packages.includes('&')) if(packages.includes('&'))
app.ui.dialog.show(`Invalid PIP package enumeration: '${packages}'`); app.ui.dialog.show(`Invalid PIP package enumeration: '${packages}'`);
const res = await api.fetchApi(`/customnode/install/pip?packages=${packages}`); const res = await api.fetchApi("/customnode/install/pip", {
method: "POST",
body: packages,
});
if(res.status == 200) { if(res.status == 200) {
app.ui.dialog.show(`PIP package installation is processed.<br>To apply the pip packages, please click the <button id='cm-reboot-button3'><font size='3px'>RESTART</font></button> button in ComfyUI.`); app.ui.dialog.show(`PIP package installation is processed.<br>To apply the pip packages, please click the <button id='cm-reboot-button3'><font size='3px'>RESTART</font></button> button in ComfyUI.`);
@ -121,7 +124,10 @@ export async function install_via_git_url(url, manager_dialog) {
app.ui.dialog.show(`Wait...<BR><BR>Installing '${url}'`); app.ui.dialog.show(`Wait...<BR><BR>Installing '${url}'`);
app.ui.dialog.element.style.zIndex = 10010; app.ui.dialog.element.style.zIndex = 10010;
const res = await api.fetchApi(`/customnode/install/git_url?url=${url}`); const res = await api.fetchApi("/customnode/install/git_url", {
method: "POST",
body: url,
});
if(res.status == 200) { if(res.status == 200) {
app.ui.dialog.show(`'${url}' is installed<BR>To apply the installed custom node, please <button id='cm-reboot-button4'><font size='3px'>RESTART</font></button> ComfyUI.`); app.ui.dialog.show(`'${url}' is installed<BR>To apply the installed custom node, please <button id='cm-reboot-button4'><font size='3px'>RESTART</font></button> ComfyUI.`);