From 324851f1466342898ebd7062950e798de8bbe0f8 Mon Sep 17 00:00:00 2001 From: "Dr.Lt.Data" Date: Sat, 21 Mar 2026 13:17:34 +0900 Subject: [PATCH] fix(manager_core): capture stderr in run_script for git clone diagnostics run_script() used subprocess.check_call which discards stderr entirely. On Windows, git_helper.py's git clone failure (exit 128) produced no visible error message because stderr was never captured or forwarded. Changed to subprocess.run with capture_output=True so git's actual fatal message (e.g. "destination path already exists") is visible in comfy-cli CI logs. --- comfyui_manager/legacy/manager_core.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/comfyui_manager/legacy/manager_core.py b/comfyui_manager/legacy/manager_core.py index de6b29f3..ffa695f2 100644 --- a/comfyui_manager/legacy/manager_core.py +++ b/comfyui_manager/legacy/manager_core.py @@ -1659,7 +1659,13 @@ class ManagerFuncs: print(f"[ComfyUI-Manager] Unexpected behavior: `{cmd}`") return 0 - subprocess.check_call(cmd, cwd=cwd, env=get_script_env()) + result = subprocess.run(cmd, cwd=cwd, env=get_script_env(), capture_output=True, text=True) + if result.stdout: + print(result.stdout, end='') + if result.stderr: + print(result.stderr, end='', file=sys.stderr) + if result.returncode != 0: + raise subprocess.CalledProcessError(result.returncode, cmd, output=result.stdout, stderr=result.stderr) return 0