From b1b02dc8e5af8771ab2d4e6604dd0728ae662d13 Mon Sep 17 00:00:00 2001 From: "Dr.Lt.Data" Date: Wed, 29 Jan 2025 02:45:37 +0900 Subject: [PATCH] double-click feature is removed. The feature has been moved to https://github.com/ltdrdata/comfyui-connection-helper --- README.md | 17 +++++++++++------ glob/manager_core.py | 3 --- glob/manager_server.py | 15 --------------- js/comfyui-manager.js | 23 ----------------------- pyproject.toml | 2 +- 5 files changed, 12 insertions(+), 48 deletions(-) diff --git a/README.md b/README.md index 45b1e1d4..3f32e697 100644 --- a/README.md +++ b/README.md @@ -5,6 +5,8 @@ ![menu](https://raw.githubusercontent.com/ltdrdata/ComfyUI-extension-tutorials/Main/ComfyUI-Manager/images/dialog.jpg) ## NOTICE +* V3.10: `double-click feature` is removed + * This feature has been moved to https://github.com/ltdrdata/comfyui-connection-helper * V3.3.2: Overhauled. Officially supports [https://comfyregistry.org/](https://comfyregistry.org/). * You can see whole nodes info on [ComfyUI Nodes Info](https://ltdrdata.github.io/) page. @@ -185,17 +187,18 @@ The following settings are applied based on the section marked as `is_default`. ## Custom node support guide +* **NOTICE:** + - You should no longer assume that the GitHub repository name will match the subdirectory name under `custom_nodes`. The name of the subdirectory under `custom_nodes` will now use the normalized name from the `name` field in `pyproject.toml`. + - Avoid relying on directory names for imports whenever possible. + * https://docs.comfy.org/registry/overview +* https://github.com/Comfy-Org/rfcs - -* **Special purpose files** (optional) +**Special purpose files** (optional) + * `pyproject.toml` - Spec file for comfyregistry. * `node_list.json` - When your custom nodes pattern of NODE_CLASS_MAPPINGS is not conventional, it is used to manually provide a list of nodes for reference. ([example](https://github.com/melMass/comfy_mtb/raw/main/node_list.json)) * `requirements.txt` - When installing, this pip requirements will be installed automatically * `install.py` - When installing, it is automatically called - * `uninstall.py` - When uninstalling, it is automatically called - * `disable.py` - When disabled, it is automatically called - * When installing a custom node setup `.js` file, it is recommended to write this script for disabling. - * `enable.py` - When enabled, it is automatically called * **All scripts are executed from the root path of the corresponding custom node.** @@ -278,6 +281,7 @@ The following settings are applied based on the section marked as `is_default`. * If you add the item `skip_migration_check = True` to `config.ini`, it will not check whether there are nodes that can be migrated at startup. * This option can be used if performance issues occur in a Colab+GDrive environment. + ## Scanner When you run the `scan.sh` script: @@ -301,6 +305,7 @@ When you run the `scan.sh` script: * if `SSL: CERTIFICATE_VERIFY_FAILED` error is occured. * Edit `config.ini` file: add `bypass_ssl = True` + ## Security policy * Edit `config.ini` file: add `security_level = ` * `strong` diff --git a/glob/manager_core.py b/glob/manager_core.py index 9dce6c3a..95dea16e 100644 --- a/glob/manager_core.py +++ b/glob/manager_core.py @@ -1551,7 +1551,6 @@ def write_config(): "file_logging": get_config()['file_logging'], 'default_ui': get_config()['default_ui'], 'component_policy': get_config()['component_policy'], - 'double_click_policy': get_config()['double_click_policy'], 'windows_selector_event_loop_policy': get_config()['windows_selector_event_loop_policy'], 'model_download_by_agent': get_config()['model_download_by_agent'], 'downgrade_blacklist': get_config()['downgrade_blacklist'], @@ -1591,7 +1590,6 @@ def read_config(): 'file_logging': default_conf['file_logging'].lower() == 'true' if 'file_logging' in default_conf else True, 'default_ui': default_conf['default_ui'] if 'default_ui' in default_conf else 'none', 'component_policy': default_conf['component_policy'] if 'component_policy' in default_conf else 'workflow', - 'double_click_policy': default_conf['double_click_policy'] if 'double_click_policy' in default_conf else 'copy-all', 'windows_selector_event_loop_policy': default_conf['windows_selector_event_loop_policy'].lower() == 'true' if 'windows_selector_event_loop_policy' in default_conf else False, 'model_download_by_agent': default_conf['model_download_by_agent'].lower() == 'true' if 'model_download_by_agent' in default_conf else False, 'downgrade_blacklist': default_conf['downgrade_blacklist'] if 'downgrade_blacklist' in default_conf else '', @@ -1609,7 +1607,6 @@ def read_config(): 'file_logging': True, 'default_ui': 'none', 'component_policy': 'workflow', - 'double_click_policy': 'copy-all', 'windows_selector_event_loop_policy': False, 'model_download_by_agent': False, 'downgrade_blacklist': '', diff --git a/glob/manager_server.py b/glob/manager_server.py index e9f29a3b..9da330ba 100644 --- a/glob/manager_server.py +++ b/glob/manager_server.py @@ -161,10 +161,6 @@ def set_component_policy(mode): core.get_config()['component_policy'] = mode -def set_double_click_policy(mode): - core.get_config()['double_click_policy'] = mode - - def print_comfyui_version(): global comfy_ui_hash global comfyui_tag @@ -1205,17 +1201,6 @@ async def component_policy(request): return web.Response(status=200) -@routes.get("/manager/dbl_click/policy") -async def dbl_click_policy(request): - if "value" in request.rel_url.query: - set_double_click_policy(request.rel_url.query['value']) - core.write_config() - else: - return web.Response(text=core.get_config()['double_click_policy'], status=200) - - return web.Response(status=200) - - @routes.get("/manager/channel_url_list") async def channel_url_list(request): channels = core.get_channel_dict() diff --git a/js/comfyui-manager.js b/js/comfyui-manager.js index a574a4f1..4e5fe988 100644 --- a/js/comfyui-manager.js +++ b/js/comfyui-manager.js @@ -1061,28 +1061,6 @@ class ManagerMenuDialog extends ComfyDialog { set_component_policy(event.target.value); }); - let dbl_click_policy_combo = document.createElement("select"); - dbl_click_policy_combo.setAttribute("title", "Sets the behavior when you double-click the title area of a node."); - dbl_click_policy_combo.className = "cm-menu-combo"; - dbl_click_policy_combo.appendChild($el('option', { value: 'none', text: 'Double-Click: None' }, [])); - dbl_click_policy_combo.appendChild($el('option', { value: 'copy-all', text: 'Double-Click: Copy All Connections' }, [])); - dbl_click_policy_combo.appendChild($el('option', { value: 'copy-full', text: 'Double-Click: Copy All Connections and shape' }, [])); - dbl_click_policy_combo.appendChild($el('option', { value: 'copy-input', text: 'Double-Click: Copy Input Connections' }, [])); - dbl_click_policy_combo.appendChild($el('option', { value: 'possible-input', text: 'Double-Click: Possible Input Connections' }, [])); - dbl_click_policy_combo.appendChild($el('option', { value: 'dual', text: 'Double-Click: Possible(left) + Copy(right)' }, [])); - - api.fetchApi('/manager/dbl_click/policy') - .then(response => response.text()) - .then(data => { - dbl_click_policy_combo.value = data; - set_double_click_policy(data); - }); - - dbl_click_policy_combo.addEventListener('change', function (event) { - api.fetchApi(`/manager/dbl_click/policy?value=${event.target.value}`); - set_double_click_policy(event.target.value); - }); - api.fetchApi('/manager/share_option') .then(response => response.text()) .then(data => { @@ -1111,7 +1089,6 @@ class ManagerMenuDialog extends ComfyDialog { default_ui_combo, share_combo, component_policy_combo, - dbl_click_policy_combo, $el("br", {}, []), $el("br", {}, []), diff --git a/pyproject.toml b/pyproject.toml index f92ebd02..948834f4 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,7 +1,7 @@ [project] name = "comfyui-manager" description = "ComfyUI-Manager provides features to install and manage custom nodes for ComfyUI, as well as various functionalities to assist with ComfyUI." -version = "3.9.5" +version = "3.10" license = { file = "LICENSE.txt" } dependencies = ["GitPython", "PyGithub", "matrix-client==0.4.0", "transformers", "huggingface-hub>0.20", "typer", "rich", "typing-extensions"]