Commit Graph

2 Commits

Author SHA1 Message Date
Can H. Tartanoglu
f7df03f4e0
test: add unit tests for dependency_management flag
Lift the on/off value parser to `manager_util.is_off_value` so the
prestartup hook and the new tests share one definition, and cover the
flag's contract:

- default is enabled (today's behavior is preserved bit-for-bit)
- PIPFixer.fix_broken short-circuits without spawning subprocess when
  the flag is off
- PIPFixer.fix_broken still reaches subprocess when the flag is on
- make_pip_cmd is not gated — read paths (`pip list`, `freeze`, `show`)
  the UI and security check rely on continue to work
- value parser accepts off/false/0/no/disabled (case- and
  whitespace-insensitive) and treats unknown values as "on" so a typo
  doesn't silently disable installs
2026-05-04 16:09:17 +02:00
Dr.Lt.Data
cd60f33f6d
fix(git_helper): remove comfyui_manager import to fix Windows subprocess crash (#2703)
git_helper.py is spawned as a standalone subprocess on Windows
(manager_core.py:1342). The import of comfyui_manager.common.timestamp_utils
triggered comfyui_manager/__init__.py which imports from comfy.cli_args —
unavailable in the subprocess environment, causing ModuleNotFoundError.

Inline get_backup_branch_name() using only stdlib (time, uuid), preserving
the original collision-detection and UUID-fallback semantics. Add 9 tests
covering standalone subprocess loading, behavioral equivalence, edge cases
(repo.heads exception, 99-suffix exhaustion with UUID fallback).
2026-03-18 02:04:48 +09:00