Commit Graph
52 Commits
Author SHA1 Message Date
Jean Paul RuizandGitHub 2330a9853b Merge 1ec6736611 into 037987b917 2026-07-07 03:36:06 +09:00
Dr.Lt.DataandGitHub 491f847bbc fix(security): harden CSRF with Content-Type gate and OpenAPI sync (#2819)
Python Linting / Run Ruff (push) Has been cancelled
Defense-in-depth over GET→POST alone: reject the three CORS-safelisted
simple-form Content-Types (x-www-form-urlencoded, multipart/form-data,
text/plain) on 5 no-body POST handlers (snapshot/save,
manager/queue/{reset,start,update_comfyui}, manager/reboot) to block
<form method=POST> CSRF that bypasses method-only gating. Convert 10 pure
state-changing endpoints (fetch_updates, queue/{update_all,reset,start,
update_comfyui}, snapshot/{remove,restore,save}, comfyui_switch_version,
reboot) from GET to POST and split 5 config endpoints
(db_mode/preview_method/channel_url_list/policy/{component,update}) into
GET(read) + POST(write, JSON body). Emit the in_progress + done event pair
from the /manager/queue/install sync-enable fast-path so client UI
finalizes (previously only queue/start's empty worker done fired, leaving
item.restart unset and the Enable button visible after a successful enable).
Harden js/custom-nodes-manager.js completion path: await onQueueCompleted
with try/catch (surfaces silent turbogrid stale-item throws), replace the
{}.length == 0 no-op empty guard, set install_context before queue/install
to avoid a sync-completion race, wrap classList/updateCell in try/catch.
Resynchronize openapi.yaml with the converted routes (method → post, query
params → requestBody JSON schema, sibling post on 5 split endpoints).
Update 31 JS fetchApi call sites across 7 files; add
tests/test_csrf_content_type_helper.py covering 5 Content-Type cases via
aiohttp TestClient.

Reported-by: XlabAI Team of Tencent Xuanwu Lab
CVSS: 8.1 (AV:N/AC:L/PR:N/UI:R/S:U/C:N/I:H/A:H)
2026-04-22 05:04:07 +09:00
Jean Paul Ruiz 5835c4f5fc Fix undefined access in custom nodes manager conflicts calculation
Add null checks for nodeItem, nodesMap, extItem, and nItem before
accessing properties to prevent 'Cannot read properties of undefined'
error when processing node conflicts.

Fixes error at custom-nodes-manager.js:1318
2026-01-15 11:47:53 -05:00
ae6c7dd673 Changed Main Dialog to match aesthetics and close button location as Original ComfyUI Interface (#2349)
Python Linting / Run Ruff (push) Waiting to run
* Started changing UI to match the rest of ComfyUI

Completed Main Container

* - Added layout formatting to components of the Manager dialog box
- Pulled name from select and put it into a label (eg "DB: Channel" now has a label of DB and a dropdown with channel, etc)
- Fixed incorrect z-index

* Removed this.close() I added before finding z-index issue.

* Matched buttons and drop downs to match style of ComfyUI interface while keeping the colours the same as OG ComfyUI Manager

* - Took gui building out and put into its own .js
- Applied theme to Nodes Manager
- Made theme respect user theme colors

* - Themed model manager and snapshot manager
- fixed incorrect id in gui builder

* Fix syntax error in color property

---------

Co-authored-by: Dr.Lt.Data <128333288+ltdrdata@users.noreply.github.com>
2025-12-19 12:34:20 +09:00
Dr.Lt.DataandGitHub aaed1dc3d5 feat(security): Support System User Protection API with security migration (V3.38) (#2338)
- Migrate Manager data path: default/ComfyUI-Manager → __manager
- Force security_level=strong on outdated ComfyUI (block installations)
- Auto-migrate config.ini only; backup legacy files for manual verification
- Raise weak/normal- to normal during migration
- Add /manager/startup_alerts API for UI warnings
- Differentiate 403 responses: comfyui_outdated vs security_level
- Block startup scripts execution on old ComfyUI

Requires ComfyUI v0.3.76+ for full functionality.
Backward compatible with older versions (uses legacy path).
2025-12-03 00:42:12 +09:00
Christian ByrneandGitHub e8ec1ce8e3 recurse when finding nodes in workflow (#2070) 2025-08-11 12:47:20 +09:00
Dr.Lt.Data 815784e809 fixed: Fix issue where some nodepacks were displayed redundantly in custom nodes manager. 2025-06-25 00:18:18 +09:00
Yoland YanandGitHub 036b63efe7 Change order of manager to be default install lateste (#1747) 2025-04-15 18:46:24 +09:00
CenFunandGitHub 7651e5e48b UI improvement (#1625) 2025-03-14 00:51:37 +09:00
Dr.Lt.Data 6969557693 fixed: stuck if cnr node cannot be resolved
https://github.com/ltdrdata/ComfyUI-Manager/issues/1596#issuecomment-2692415656
2025-03-02 17:28:53 +09:00
Dr.Lt.Data 5a5a37dfee fixed: robust initial caching
https://github.com/comfyanonymous/ComfyUI/issues/7003#issuecomment-2690687621

modified: store `db_mode` setting to `config.ini`
https://github.com/ltdrdata/ComfyUI-Manager/issues/1582#issuecomment-2687332355

remove: fetch updates / skip updates
- 'updates' filter will trigger fetching
https://github.com/ltdrdata/ComfyUI-Manager/issues/1584

added: support for `disable_front` or `DISABLE_COMFYUI_MANAGER_FRONT`
2025-03-01 01:06:17 +09:00
Dr.Lt.Data 5ef58652bf remove useless code 2025-02-26 21:19:22 +09:00
Dr.Lt.Data 4fd17b0bf5 improved: advanced missing node detection based on embedded info
https://github.com/ltdrdata/ComfyUI-Manager/issues/1445

feat: Custom Nodes In Workflow
https://github.com/ltdrdata/ComfyUI-Manager/issues/990
https://github.com/ltdrdata/ComfyUI-Manager/issues/127

improved: show version on main dialog
modified: aux_id - use github_id if possible
removed: `fetch updates` button
2025-02-24 21:18:42 +09:00
Dr.Lt.Data a68330fb8f rollback wip code 2025-02-23 11:25:30 +09:00
Dr.Lt.Data 2449ad5c69 update DB 2025-02-23 11:08:07 +09:00
CenFunandGitHub 6b832edd2f store user's column width (#1541)
* Resolving conflicts

* ruff --fix
2025-02-14 07:29:11 +09:00
Dr.Lt.Data 6ff6e05408 improve: update all - background updating
modified: update all - don't update ComfyUI
2025-02-13 22:34:36 +09:00
Dr.Lt.Data 9963afa558 modified: remove comfyui-manager from list if desktop mode 2025-02-13 08:46:18 +09:00
Dr.Lt.Data e113e011cb improved: Display the terminal when starting the installation of a model or node packs 2025-02-10 02:56:55 +09:00
Dr.Lt.Data 559c011420 feat: support huggingface snapshot downloader
fixed: An issue where JS did not properly handle model download errors.
fixed: better security message for model downloading
2025-02-10 02:24:08 +09:00
Dr.Lt.Data ba9c71ffa4 fixed: close dialogs before restart
fixed: visual bug
2025-02-02 18:57:23 +09:00
Dr.Lt.Data 21b6c6569c feat: show restart confirm window when reconnected
fixed: `uv` related crash
2025-02-02 18:36:04 +09:00
Dr.Lt.Data 33f931c0a4 feat: Support for uv has been added.
Set `use_uv` in `config.ini`.
2025-02-02 17:26:29 +09:00
bymyselfandGitHub 2e55bc470c Add commands to toggle visibility of manager and custom nodes manager menus (#1505)
* Add commands for manager keybindings

* use more consistent isVisible condition check

* remove hide method in favor of super class's close method

* fix formatting

* fix tabs formatting
2025-02-02 14:37:04 +09:00
Dr.Lt.Data 3c2933338f fixed: /manager/queue/status - race condition issue 2025-02-02 10:38:05 +09:00
Dr.Lt.Data 510c364607 feat: stop feature
feat: model-manager - support background tasking
2025-02-01 16:35:56 +09:00
Dr.Lt.Data 4760deaf9c feat: custom-nodes-manager - background tasks(install/update/fix/disable/enable) 2025-02-01 11:22:01 +09:00
Dr.Lt.Data c6153ea67d * FIXED: Resolved an issue where cache updates were not working properly.
* IMPROVED: Instead of updating the entire CNR cache at once, the process now divides it into 30-page queries.
* IMPROVED: Clicking on the titles of nodes that exist only in CNR now opens the GitHub repository link instead of the CNR link, where possible.
* ADDED: Added information about `extra_model_paths.yaml` to the README.md file.

https://github.com/ltdrdata/ComfyUI-Manager/issues/1457
2025-01-19 02:25:34 +09:00
Dr.Lt.Data 0eb1cbce43 feat: provide error messages for import failed custom node. 2025-01-18 13:04:33 +09:00
Dr.Lt.Data 830be27eb2 FIXED: Resolved an issue that occurred when attempting to install the nightly version if it was not registered in custom-node-list.json.
FIXED: Improved error reporting for invalid Git URLs.

https://github.com/ltdrdata/ComfyUI-Manager/issues/1413
2025-01-11 11:38:12 +09:00
Dr.Lt.Data 29ab428979 fixed: /customnode/versions - Issue where a 400 error occurred when no versions were available in CNR.
https://github.com/ltdrdata/ComfyUI-Manager/issues/1397
2025-01-05 09:17:54 +09:00
Dr.Lt.Data c2c8fbec3c improved: back button - better style 2025-01-02 03:21:46 +09:00
Dr.Lt.Data 3c11361502 Merge branch 'main' into feat/cnr
improved: support new front's prompt, alert api
modified: z-indices
2025-01-02 02:58:55 +09:00
Dr.Lt.Data 939cb12670 fixed: alternative implementation for confirm
`confirm` cannot be used in electron
2024-12-31 14:37:03 +09:00
Dr.Lt.Data 890ba0f818 fix: Fixed an issue where the ID of nodes registered only in the CNR could not be properly resolved.
https://github.com/ltdrdata/ComfyUI-Manager/issues/1376
2024-12-29 08:10:59 +09:00
Dr.Lt.Data e4bb21f25c fix: import error - cnr_utils.extract_package_as_zip 2024-12-19 08:20:39 +09:00
Dr.Lt.Data e2e1e23ab5 modified: Change the default from CNR to nightly
fixed: broken CNR installation
2024-12-18 15:00:23 +09:00
Dr.Lt.Data b8f153e4eb Merge branch 'main' into feat/cnr 2024-12-18 09:08:15 +09:00
Chenlei HuandGitHub 30abab5925 Remove call to non-exist endpoint /component/get_unresolved (#1338) 2024-12-17 11:19:49 +09:00
Dr.Lt.Data e83e15b9fc Merge branch 'main' into feat/cnr 2024-09-26 08:57:29 +09:00
bymyselfandGitHub 32430968b8 Update groupnode/component to be compatible with frontend v1.2.64 (#1084) 2024-09-26 08:33:14 +09:00
Dr.Lt.Data a1c90ceb52 modify: close button -> back button 2024-09-08 16:51:41 +09:00
Dr.Lt.Data ecda9bd34e add favorites button 2024-09-08 16:42:36 +09:00
Dr.Lt.Data a952009d4a modified: remove uninstall/switch/disable button for ComfyUI-Manager in the list
feat: support favorites list
2024-09-08 15:53:54 +09:00
Dr.Lt.Data a1f7f7069f comfyui version switch 2024-08-21 01:33:55 +09:00
Dr.Lt.Data 0968dd85aa fix: undefined show_message
fix: invalid disable for nightly
2024-08-15 22:45:37 +09:00
Dr.Lt.Data 0b6f7962a4 fix: should not be displayed switch button if unknown node 2024-08-04 16:34:40 +09:00
Dr.Lt.Data cdb400d32b implement: invalid installation handling
- print invalid installation nodes on terminal
(installed by `comfy registryinstall`)

- show only 'reinstall' menu if invalid installation node in gui
(and show INVALID marker)
2024-07-31 02:08:30 +09:00
Dr.Lt.Data b3be556837 support CNR 2024-07-25 00:24:58 +09:00
CenFunandGitHub a94516cdb2 Model mananger UI enhancement (#808)
* Model download via url

* Model download support multiple selection

* update Roadmap
2024-06-22 19:29:22 +09:00