Commit Graph

17 Commits

Author SHA1 Message Date
Dr.Lt.Data
ee2f655370 fix(security): harden CSRF with Content-Type gate and OpenAPI sync
Defense-in-depth over GET→POST alone: reject the three CORS-safelisted
simple-form Content-Types (x-www-form-urlencoded, multipart/form-data,
text/plain) on 5 no-body POST handlers (snapshot/save,
manager/queue/{reset,start,update_comfyui}, manager/reboot) to block
<form method=POST> CSRF that bypasses method-only gating. Convert 10 pure
state-changing endpoints (fetch_updates, queue/{update_all,reset,start,
update_comfyui}, snapshot/{remove,restore,save}, comfyui_switch_version,
reboot) from GET to POST and split 5 config endpoints
(db_mode/preview_method/channel_url_list/policy/{component,update}) into
GET(read) + POST(write, JSON body). Emit the in_progress + done event pair
from the /manager/queue/install sync-enable fast-path so client UI
finalizes (previously only queue/start's empty worker done fired, leaving
item.restart unset and the Enable button visible after a successful enable).
Harden js/custom-nodes-manager.js completion path: await onQueueCompleted
with try/catch (surfaces silent turbogrid stale-item throws), replace the
{}.length == 0 no-op empty guard, set install_context before queue/install
to avoid a sync-completion race, wrap classList/updateCell in try/catch.
Resynchronize openapi.yaml with the converted routes (method → post, query
params → requestBody JSON schema, sibling post on 5 split endpoints).
Update 31 JS fetchApi call sites across 7 files; add
tests/test_csrf_content_type_helper.py covering 5 Content-Type cases via
aiohttp TestClient.

Reported-by: XlabAI Team of Tencent Xuanwu Lab
CVSS: 8.1 (AV:N/AC:L/PR:N/UI:R/S:U/C:N/I:H/A:H)
2026-04-22 04:50:34 +09:00
David
ae6c7dd673
Changed Main Dialog to match aesthetics and close button location as Original ComfyUI Interface (#2349)
Some checks are pending
Python Linting / Run Ruff (push) Waiting to run
* Started changing UI to match the rest of ComfyUI

Completed Main Container

* - Added layout formatting to components of the Manager dialog box
- Pulled name from select and put it into a label (eg "DB: Channel" now has a label of DB and a dropdown with channel, etc)
- Fixed incorrect z-index

* Removed this.close() I added before finding z-index issue.

* Matched buttons and drop downs to match style of ComfyUI interface while keeping the colours the same as OG ComfyUI Manager

* - Took gui building out and put into its own .js
- Applied theme to Nodes Manager
- Made theme respect user theme colors

* - Themed model manager and snapshot manager
- fixed incorrect id in gui builder

* Fix syntax error in color property

---------

Co-authored-by: Dr.Lt.Data <128333288+ltdrdata@users.noreply.github.com>
2025-12-19 12:34:20 +09:00
Dr.Lt.Data
aaed1dc3d5
feat(security): Support System User Protection API with security migration (V3.38) (#2338)
- Migrate Manager data path: default/ComfyUI-Manager → __manager
- Force security_level=strong on outdated ComfyUI (block installations)
- Auto-migrate config.ini only; backup legacy files for manual verification
- Raise weak/normal- to normal during migration
- Add /manager/startup_alerts API for UI warnings
- Differentiate 403 responses: comfyui_outdated vs security_level
- Block startup scripts execution on old ComfyUI

Requires ComfyUI v0.3.76+ for full functionality.
Backward compatible with older versions (uses legacy path).
2025-12-03 00:42:12 +09:00
moldwebs
48c10d0b95
Show models used in current workflow (#1819)
Simple javascript modify that filter models used in current workflow
2025-05-13 01:48:29 +09:00
CenFun
7651e5e48b
UI improvement (#1625) 2025-03-14 00:51:37 +09:00
CenFun
6b832edd2f
store user's column width (#1541)
* Resolving conflicts

* ruff --fix
2025-02-14 07:29:11 +09:00
Dr.Lt.Data
e113e011cb improved: Display the terminal when starting the installation of a model or node packs 2025-02-10 02:56:55 +09:00
Dr.Lt.Data
559c011420 feat: support huggingface snapshot downloader
fixed: An issue where JS did not properly handle model download errors.
fixed: better security message for model downloading
2025-02-10 02:24:08 +09:00
Dr.Lt.Data
33f931c0a4 feat: Support for uv has been added.
Set `use_uv` in `config.ini`.
2025-02-02 17:26:29 +09:00
Dr.Lt.Data
3c2933338f fixed: /manager/queue/status - race condition issue 2025-02-02 10:38:05 +09:00
Dr.Lt.Data
510c364607 feat: stop feature
feat: model-manager - support background tasking
2025-02-01 16:35:56 +09:00
Dr.Lt.Data
3c11361502 Merge branch 'main' into feat/cnr
improved: support new front's prompt, alert api
modified: z-indices
2025-01-02 02:58:55 +09:00
Dr.Lt.Data
a148bb5aeb modified: apply new front's confirm api 2025-01-02 02:23:21 +09:00
Dr.Lt.Data
a1c90ceb52 modify: close button -> back button 2024-09-08 16:51:41 +09:00
CenFun
aa3db7d2b4
add model size (#809) 2024-06-22 22:01:22 +09:00
CenFun
a94516cdb2
Model mananger UI enhancement (#808)
* Model download via url

* Model download support multiple selection

* update Roadmap
2024-06-22 19:29:22 +09:00
CenFun
651496cae0
Better model manager UI (#802)
* fixed row height with lib API

* update grid lib

* UI adjustment

* move some of api to common utils

* added model manager

* update install

* replace model-downloader with model-manager

* replace model-downloader with model-manager

* fixed filter

* fixed status

* apply loading animation for install button

* sort type and base
2024-06-22 10:12:01 +09:00