refactor: rename _is_cacheable_value to _is_external_cacheable_value
Some checks are pending
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run

Clearer name since objects are also cached locally - this specifically
checks for external caching eligibility.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Deep Mehta 2026-01-30 00:46:10 +05:30
parent 0440ebcf6e
commit 0141af0786

View File

@ -238,7 +238,7 @@ class BasicCache:
return return
if not has_cache_providers(): if not has_cache_providers():
return return
if not self._is_cacheable_value(value): if not self._is_external_cacheable_value(value):
return return
if contains_nan(cache_key): if contains_nan(cache_key):
return return
@ -302,8 +302,8 @@ class BasicCache:
return None return None
def _is_cacheable_value(self, value): def _is_external_cacheable_value(self, value):
"""Check if value is a CacheEntry (not objects cache).""" """Check if value is a CacheEntry suitable for external caching (not objects cache)."""
return hasattr(value, 'outputs') and hasattr(value, 'ui') return hasattr(value, 'outputs') and hasattr(value, 'ui')
def _get_class_type(self, node_id): def _get_class_type(self, node_id):