From 11ca1995a3036f143022dc3f9cf8da18d53d09d7 Mon Sep 17 00:00:00 2001 From: Luke Mino-Altherr Date: Tue, 3 Feb 2026 13:31:38 -0800 Subject: [PATCH] fix: remaining ruff linting errors in services tests - Remove unused os imports in conftest.py and test_ingest.py - Remove unused Tag import in test_asset_management.py - Remove unused ensure_tags_exist import in test_ingest.py - Fix unused info2 variable in test_asset_management.py Co-Authored-By: Claude Opus 4.5 --- tests-unit/assets_test/services/conftest.py | 1 - tests-unit/assets_test/services/test_asset_management.py | 4 ++-- tests-unit/assets_test/services/test_ingest.py | 3 +-- tests-unit/assets_test/services/test_tagging.py | 2 +- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/tests-unit/assets_test/services/conftest.py b/tests-unit/assets_test/services/conftest.py index d48e2fbe9..ef6a9752c 100644 --- a/tests-unit/assets_test/services/conftest.py +++ b/tests-unit/assets_test/services/conftest.py @@ -1,4 +1,3 @@ -import os import tempfile from pathlib import Path from unittest.mock import patch diff --git a/tests-unit/assets_test/services/test_asset_management.py b/tests-unit/assets_test/services/test_asset_management.py index bf2b33194..1bff4344c 100644 --- a/tests-unit/assets_test/services/test_asset_management.py +++ b/tests-unit/assets_test/services/test_asset_management.py @@ -2,7 +2,7 @@ import pytest from sqlalchemy.orm import Session -from app.assets.database.models import Asset, AssetInfo, Tag +from app.assets.database.models import Asset, AssetInfo from app.assets.database.queries import ensure_tags_exist, add_tags_to_asset_info from app.assets.helpers import utcnow from app.assets.services import ( @@ -179,7 +179,7 @@ class TestDeleteAssetReference: def test_keeps_asset_if_other_infos_exist(self, mock_create_session, session: Session): asset = _make_asset(session) info1 = _make_asset_info(session, asset, name="info1") - info2 = _make_asset_info(session, asset, name="info2") + _make_asset_info(session, asset, name="info2") # Second info keeps asset alive asset_id = asset.id session.commit() diff --git a/tests-unit/assets_test/services/test_ingest.py b/tests-unit/assets_test/services/test_ingest.py index 1b8fda1b5..9270a3ce0 100644 --- a/tests-unit/assets_test/services/test_ingest.py +++ b/tests-unit/assets_test/services/test_ingest.py @@ -1,12 +1,11 @@ """Tests for ingest services.""" -import os from pathlib import Path import pytest from sqlalchemy.orm import Session from app.assets.database.models import Asset, AssetCacheState, AssetInfo, Tag -from app.assets.database.queries import ensure_tags_exist, get_asset_tags +from app.assets.database.queries import get_asset_tags from app.assets.services import ingest_file_from_path, register_existing_asset diff --git a/tests-unit/assets_test/services/test_tagging.py b/tests-unit/assets_test/services/test_tagging.py index 625cddc98..396ae407f 100644 --- a/tests-unit/assets_test/services/test_tagging.py +++ b/tests-unit/assets_test/services/test_tagging.py @@ -2,7 +2,7 @@ import pytest from sqlalchemy.orm import Session -from app.assets.database.models import Asset, AssetInfo, Tag +from app.assets.database.models import Asset, AssetInfo from app.assets.database.queries import ensure_tags_exist, add_tags_to_asset_info from app.assets.helpers import utcnow from app.assets.services import apply_tags, remove_tags, list_tags