diff --git a/tests-unit/comfy_extras_test/nodes_math_test.py b/tests-unit/comfy_extras_test/nodes_math_test.py index fcf5fba49..c1a64cba4 100644 --- a/tests-unit/comfy_extras_test/nodes_math_test.py +++ b/tests-unit/comfy_extras_test/nodes_math_test.py @@ -58,16 +58,52 @@ class TestMathExpressionExecute: assert result[0] == 4.0 def test_sum_values_array(self): - result = self._exec("$sum(values)", a=1, b=2, c=3) + result = self._exec("sum(values)", a=1, b=2, c=3) assert result[0] == 6 - def test_non_numeric_result_raises(self): - with pytest.raises(ValueError, match="must evaluate to a numeric result"): - self._exec("$string(a)", a=42) + def test_sum_variadic(self): + result = self._exec("sum(a, b, c)", a=1, b=2, c=3) + assert result[0] == 6 - def test_error_message_includes_expression(self): - with pytest.raises(ValueError, match="'\\$string\\(a\\)'"): - self._exec("$string(a)", a=42) + def test_min_values(self): + result = self._exec("min(values)", a=5, b=2, c=8) + assert result[0] == 2 + + def test_max_values(self): + result = self._exec("max(values)", a=5, b=2, c=8) + assert result[0] == 8 + + def test_abs_function(self): + result = self._exec("abs(a)", a=-7) + assert result[0] == 7 + + def test_sqrt(self): + result = self._exec("sqrt(a)", a=16) + assert result[0] == 4.0 + + def test_ceil(self): + result = self._exec("ceil(a)", a=2.3) + assert result[0] == 3 + + def test_floor(self): + result = self._exec("floor(a)", a=2.7) + assert result[0] == 2 + + def test_sin(self): + result = self._exec("sin(a)", a=0) + assert result[0] == 0.0 + + def test_log10(self): + result = self._exec("log10(a)", a=100) + assert result[0] == 2.0 + + def test_non_numeric_result_raises(self): + with pytest.raises((ValueError, Exception)): + self._exec("'hello'", a=42) + + def test_undefined_function_raises(self): + with pytest.raises(Exception, match="not defined"): + self._exec("str(a)", a=42) def test_boolean_result_raises(self): with pytest.raises(ValueError, match="got bool"):