From 2870b96895aa63214395361c23414fb004f154b3 Mon Sep 17 00:00:00 2001
From: clsferguson <48876201+clsferguson@users.noreply.github.com>
Date: Mon, 22 Sep 2025 13:42:14 -0600
Subject: [PATCH] fix(docker): remove unavailable software-properties-common
 package from Debian Trixie

Remove software-properties-common package which is not available in the
python:3.12.11-slim-trixie base image, causing build failure.

Package Issue:
- software-properties-common is not included in Debian Trixie slim images
- The package is not required for our non-free repository configuration
- Direct echo to sources.list.d works without this dependency

Simplified Approach:
- Remove software-properties-common from apt-get install list
- Use direct echo command to configure non-free repositories
- Maintain all essential compilation and CUDA packages
- Keep nvidia-smi installation from non-free repositories

This resolves the build error:
"E: Unable to locate package software-properties-common"

All functionality preserved while eliminating the unnecessary dependency.
---
 Dockerfile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index d429b76fc..90a39985e 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -13,7 +13,7 @@ ENV DEBIAN_FRONTEND=noninteractive \
     MAX_JOBS=32 \
     SAGE_ATTENTION_AVAILABLE=0
 
-# Enable non-free repositories for nvidia-smi and install system deps + CUDA toolkit
+# Enable non-free repositories and install system deps + CUDA toolkit
 RUN apt-get update && apt-get install -y --no-install-recommends \
     git \
     build-essential \
@@ -27,7 +27,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
     wget \
     gnupg2 \
     ca-certificates \
-    software-properties-common \
  && echo "deb http://deb.debian.org/debian trixie main contrib non-free non-free-firmware" > /etc/apt/sources.list.d/non-free.list \
  && wget https://developer.download.nvidia.com/compute/cuda/repos/debian12/x86_64/cuda-keyring_1.1-1_all.deb \
  && dpkg -i cuda-keyring_1.1-1_all.deb \
@@ -39,7 +38,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
  && rm -rf /var/lib/apt/lists/* \
  && rm cuda-keyring_1.1-1_all.deb
 
-# Set CUDA paths for entrypoint compilation (fix LD_LIBRARY_PATH warning)
+# Set CUDA paths for entrypoint compilation
 ENV CUDA_HOME=/usr/local/cuda-12.9 \
     PATH=/usr/local/cuda-12.9/bin:${PATH} \
     LD_LIBRARY_PATH=/usr/local/cuda-12.9/lib64