From 4afa80dc0773bc2e51b193c45df38837f27452c7 Mon Sep 17 00:00:00 2001 From: Deep Mehta Date: Thu, 29 Jan 2026 19:52:06 +0530 Subject: [PATCH] docs: make should_cache docstring implementation-agnostic MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove prescriptive filtering suggestions - let implementations decide their own caching logic based on their use case. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- comfy_execution/cache_provider.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/comfy_execution/cache_provider.py b/comfy_execution/cache_provider.py index 50bbaed34..2a7e877c0 100644 --- a/comfy_execution/cache_provider.py +++ b/comfy_execution/cache_provider.py @@ -121,9 +121,8 @@ class CacheProvider(ABC): Called before on_lookup (value=None) and on_store (value provided). Return False to skip external caching for this node. - Common filters: - - By class_type: Only cache expensive nodes (KSampler, VAEDecode) - - By cost/benefit: Skip if download time > compute time + Implementations can filter based on context.class_type, value size, + or any custom logic. Use estimate_value_size() to get value size. Default: Returns True (cache everything). """