From 6a6f1e4960c5ecc3793a01d72a63e756d29cf65b Mon Sep 17 00:00:00 2001 From: doctorpangloss <@hiddenswitch.com> Date: Thu, 18 Jul 2024 17:23:53 -0700 Subject: [PATCH] Fix GitHub actions to not run unnecessary or broken stuff --- .github/workflows/stable-release.yml | 109 --------------------------- .github/workflows/test-browser.yml | 75 ------------------ .github/workflows/test-ui.yaml | 6 +- 3 files changed, 1 insertion(+), 189 deletions(-) delete mode 100644 .github/workflows/stable-release.yml delete mode 100644 .github/workflows/test-browser.yml diff --git a/.github/workflows/stable-release.yml b/.github/workflows/stable-release.yml deleted file mode 100644 index 1fd76b530..000000000 --- a/.github/workflows/stable-release.yml +++ /dev/null @@ -1,109 +0,0 @@ - -name: "Release Stable Version" - -on: - push: - tags: - - 'v*' - -jobs: - package_comfy_windows: - permissions: - contents: "write" - packages: "write" - pull-requests: "read" - runs-on: windows-latest - strategy: - matrix: - python_version: [3.11.8] - cuda_version: [121] - steps: - - name: Calculate Minor Version - shell: bash - run: | - # Extract the minor version from the Python version - MINOR_VERSION=$(echo "${{ matrix.python_version }}" | cut -d'.' -f2) - echo "MINOR_VERSION=$MINOR_VERSION" >> $GITHUB_ENV - - name: Setup Python - uses: actions/setup-python@v5 - with: - python-version: ${{ matrix.python_version }} - - - uses: actions/checkout@v4 - with: - fetch-depth: 0 - persist-credentials: false - - shell: bash - run: | - echo "@echo off - call update_comfyui.bat nopause - echo - - echo This will try to update pytorch and all python dependencies. - echo - - echo If you just want to update normally, close this and run update_comfyui.bat instead. - echo - - pause - ..\python_embeded\python.exe -s -m pip install --upgrade torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/cu${{ matrix.cuda_version }} -r ../ComfyUI/requirements.txt pygit2 - pause" > update_comfyui_and_python_dependencies.bat - - python -m pip wheel --no-cache-dir torch torchvision torchaudio --extra-index-url https://download.pytorch.org/whl/cu${{ matrix.cuda_version }} -r requirements.txt pygit2 -w ./temp_wheel_dir - python -m pip install --no-cache-dir ./temp_wheel_dir/* - echo installed basic - ls -lah temp_wheel_dir - mv temp_wheel_dir cu${{ matrix.cuda_version }}_python_deps - mv cu${{ matrix.cuda_version }}_python_deps ../ - mv update_comfyui_and_python_dependencies.bat ../ - cd .. - pwd - ls - - cp -r ComfyUI ComfyUI_copy - curl https://www.python.org/ftp/python/${{ matrix.python_version }}/python-${{ matrix.python_version }}-embed-amd64.zip -o python_embeded.zip - unzip python_embeded.zip -d python_embeded - cd python_embeded - echo ${{ env.MINOR_VERSION }} - echo 'import site' >> ./python3${{ env.MINOR_VERSION }}._pth - curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py - ./python.exe get-pip.py - ./python.exe --version - echo "Pip version:" - ./python.exe -m pip --version - - set PATH=$PWD/Scripts:$PATH - echo $PATH - ./python.exe -s -m pip install ../cu${{ matrix.cuda_version }}_python_deps/* - sed -i '1i../ComfyUI' ./python3${{ env.MINOR_VERSION }}._pth - cd .. - - git clone https://github.com/comfyanonymous/taesd - cp taesd/*.pth ./ComfyUI_copy/models/vae_approx/ - - mkdir ComfyUI_windows_portable - mv python_embeded ComfyUI_windows_portable - mv ComfyUI_copy ComfyUI_windows_portable/ComfyUI - - cd ComfyUI_windows_portable - - mkdir update - cp -r ComfyUI/.ci/update_windows/* ./update/ - cp -r ComfyUI/.ci/windows_base_files/* ./ - cp ../update_comfyui_and_python_dependencies.bat ./update/ - - cd .. - - "C:\Program Files\7-Zip\7z.exe" a -t7z -m0=lzma2 -mx=8 -mfb=64 -md=32m -ms=on -mf=BCJ2 ComfyUI_windows_portable.7z ComfyUI_windows_portable - mv ComfyUI_windows_portable.7z ComfyUI/ComfyUI_windows_portable_nvidia.7z - - cd ComfyUI_windows_portable - python_embeded/python.exe -s ComfyUI/main.py --quick-test-for-ci --cpu - - ls - - - name: Upload binaries to release - uses: svenstaro/upload-release-action@v2 - with: - repo_token: ${{ secrets.GITHUB_TOKEN }} - file: ComfyUI_windows_portable_nvidia.7z - tag: ${{ github.ref }} - overwrite: true - diff --git a/.github/workflows/test-browser.yml b/.github/workflows/test-browser.yml deleted file mode 100644 index f8e2ac6cc..000000000 --- a/.github/workflows/test-browser.yml +++ /dev/null @@ -1,75 +0,0 @@ -# This is a temporary action during frontend TS migration. -# This file should be removed after TS migration is completed. -# The browser test is here to ensure TS repo is working the same way as the -# current JS code. -# If you are adding UI feature, please sync your changes to the TS repo: -# huchenlei/ComfyUI_frontend and update test expectation files accordingly. -name: Playwright Browser Tests CI - -on: - push: - branches: [ main, master ] - pull_request: - branches: [ main, master ] - -jobs: - test: - runs-on: ubuntu-latest - steps: - - name: Checkout ComfyUI - uses: actions/checkout@v4 - with: - path: "ComfyUI" - - name: Checkout ComfyUI_frontend - uses: actions/checkout@v4 - with: - repository: "huchenlei/ComfyUI_frontend" - path: "ComfyUI_frontend" - ref: "fcc54d803e5b6a9b08a462a1d94899318c96dcbb" - - uses: actions/setup-node@v3 - with: - node-version: lts/* - - uses: actions/setup-python@v4 - with: - python-version: '3.10' - - name: Install requirements - run: | - python -m pip install --upgrade pip - pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cpu - pip install -r requirements.txt - pip install wait-for-it - working-directory: ComfyUI - - name: Start ComfyUI server - run: | - python main.py --cpu 2>&1 | tee console_output.log & - wait-for-it --service 127.0.0.1:8188 -t 600 - working-directory: ComfyUI - - name: Install ComfyUI_frontend dependencies - run: | - npm ci - working-directory: ComfyUI_frontend - - name: Install Playwright Browsers - run: npx playwright install --with-deps - working-directory: ComfyUI_frontend - - name: Run Playwright tests - run: npx playwright test - working-directory: ComfyUI_frontend - - name: Check for unhandled exceptions in server log - run: | - if grep -qE "Exception|Error" console_output.log; then - echo "Unhandled exception/error found in server log." - exit 1 - fi - working-directory: ComfyUI - - uses: actions/upload-artifact@v4 - if: always() - with: - name: playwright-report - path: ComfyUI_frontend/playwright-report/ - retention-days: 30 - - uses: actions/upload-artifact@v4 - if: always() - with: - name: console-output - path: ComfyUI/console_output.log - retention-days: 30 diff --git a/.github/workflows/test-ui.yaml b/.github/workflows/test-ui.yaml index b56c85730..cced6de65 100644 --- a/.github/workflows/test-ui.yaml +++ b/.github/workflows/test-ui.yaml @@ -22,8 +22,4 @@ jobs: npm ci npm run test:generate npm test -- --verbose - working-directory: ./tests-ui - - name: Run Unit Tests - run: | - pip install -r tests-unit/requirements.txt - python -m pytest tests-unit \ No newline at end of file + working-directory: ./tests-ui \ No newline at end of file