From 86f6ee1dcbe78f100ff155944ec24f856026d3c3 Mon Sep 17 00:00:00 2001 From: dante01yoon Date: Wed, 4 Mar 2026 09:51:04 +0900 Subject: [PATCH] test: update tests for mixed INT/FLOAT inputs and dual outputs Add assertions for both FLOAT (result[0]) and INT (result[1]) outputs. Add test_mixed_int_float_inputs and test_mixed_resolution_scale to verify the primary use case of multiplying resolutions by a float factor. Co-Authored-By: Claude Opus 4.6 --- .../comfy_extras_test/nodes_math_test.py | 54 ++++++++++++++----- 1 file changed, 42 insertions(+), 12 deletions(-) diff --git a/tests-unit/comfy_extras_test/nodes_math_test.py b/tests-unit/comfy_extras_test/nodes_math_test.py index c1a64cba4..e61dc01a6 100644 --- a/tests-unit/comfy_extras_test/nodes_math_test.py +++ b/tests-unit/comfy_extras_test/nodes_math_test.py @@ -31,63 +31,84 @@ class TestMathExpressionExecute: def test_addition(self): result = self._exec("a + b", a=3, b=4) - assert result[0] == 7 + assert result[0] == 7.0 + assert result[1] == 7 def test_subtraction(self): result = self._exec("a - b", a=10, b=3) - assert result[0] == 7 + assert result[0] == 7.0 + assert result[1] == 7 def test_multiplication(self): result = self._exec("a * b", a=3, b=5) - assert result[0] == 15 + assert result[0] == 15.0 + assert result[1] == 15 def test_division(self): result = self._exec("a / b", a=10, b=4) assert result[0] == 2.5 + assert result[1] == 2 def test_single_input(self): result = self._exec("a * 2", a=5) - assert result[0] == 10 + assert result[0] == 10.0 + assert result[1] == 10 def test_three_inputs(self): result = self._exec("a + b + c", a=1, b=2, c=3) - assert result[0] == 6 + assert result[0] == 6.0 + assert result[1] == 6 def test_float_inputs(self): result = self._exec("a + b", a=1.5, b=2.5) assert result[0] == 4.0 + assert result[1] == 4 + + def test_mixed_int_float_inputs(self): + result = self._exec("a * b", a=1024, b=1.5) + assert result[0] == 1536.0 + assert result[1] == 1536 + + def test_mixed_resolution_scale(self): + result = self._exec("a * b", a=512, b=0.75) + assert result[0] == 384.0 + assert result[1] == 384 def test_sum_values_array(self): result = self._exec("sum(values)", a=1, b=2, c=3) - assert result[0] == 6 + assert result[0] == 6.0 def test_sum_variadic(self): result = self._exec("sum(a, b, c)", a=1, b=2, c=3) - assert result[0] == 6 + assert result[0] == 6.0 def test_min_values(self): result = self._exec("min(values)", a=5, b=2, c=8) - assert result[0] == 2 + assert result[0] == 2.0 def test_max_values(self): result = self._exec("max(values)", a=5, b=2, c=8) - assert result[0] == 8 + assert result[0] == 8.0 def test_abs_function(self): result = self._exec("abs(a)", a=-7) - assert result[0] == 7 + assert result[0] == 7.0 + assert result[1] == 7 def test_sqrt(self): result = self._exec("sqrt(a)", a=16) assert result[0] == 4.0 + assert result[1] == 4 def test_ceil(self): result = self._exec("ceil(a)", a=2.3) - assert result[0] == 3 + assert result[0] == 3.0 + assert result[1] == 3 def test_floor(self): result = self._exec("floor(a)", a=2.7) - assert result[0] == 2 + assert result[0] == 2.0 + assert result[1] == 2 def test_sin(self): result = self._exec("sin(a)", a=0) @@ -96,6 +117,15 @@ class TestMathExpressionExecute: def test_log10(self): result = self._exec("log10(a)", a=100) assert result[0] == 2.0 + assert result[1] == 2 + + def test_float_output_type(self): + result = self._exec("a + b", a=1, b=2) + assert isinstance(result[0], float) + + def test_int_output_type(self): + result = self._exec("a + b", a=1, b=2) + assert isinstance(result[1], int) def test_non_numeric_result_raises(self): with pytest.raises((ValueError, Exception)):