wangbo/ComfyUI
1
0
Fork 0
mirror of https://github.com/comfyanonymous/ComfyUI.git synced 2026-03-29 21:13:33 +08:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

fix: redact proxy credentials in startup log messages
Some checks are pending
Python Linting / Run Ruff (push) Waiting to run
Details
Python Linting / Run Pylint (push) Waiting to run
Details

Browse Source 
Proxy URLs may contain userinfo (user:pass@host). Redact credentials
before logging to prevent them from appearing in the log stream that
is exposed via /internal/logs endpoints.
This commit is contained in:
snomiao 2026-03-29 03:11:46 +09:00
parent 5957425013
commit 96b3494747
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
main.py
View File

@ -77,10 +77,22 @@ if __name__ == "__main__":
setup_logger(log_level=args.verbose, use_stdout=args.log_stdout) setup_logger(log_level=args.verbose, use_stdout=args.log_stdout)
def _redact_proxy_url(url):
"""Redact userinfo from proxy URL to avoid leaking credentials in logs."""
from urllib.parse import urlparse, urlunparse
try:
parsed = urlparse(url)
if parsed.username:
netloc = f"***:***@{parsed.hostname}" + (f":{parsed.port}" if parsed.port else "")
return urlunparse(parsed._replace(netloc=netloc))
except Exception:
pass
return url
if os.environ.get('HTTP_PROXY'): if os.environ.get('HTTP_PROXY'):
logging.info("HTTP proxy configured: %s", os.environ['HTTP_PROXY']) logging.info("HTTP proxy configured: %s", _redact_proxy_url(os.environ['HTTP_PROXY']))
if os.environ.get('HTTPS_PROXY'): if os.environ.get('HTTPS_PROXY'):
logging.info("HTTPS proxy configured: %s", os.environ['HTTPS_PROXY']) logging.info("HTTPS proxy configured: %s", _redact_proxy_url(os.environ['HTTPS_PROXY']))
faulthandler.enable(file=sys.stderr, all_threads=False) faulthandler.enable(file=sys.stderr, all_threads=False)