wangbo/ComfyUI
1
0
Fork 0
mirror of https://github.com/comfyanonymous/ComfyUI.git synced 2026-05-02 21:32:31 +08:00
Code Issues Actions 16 Packages Projects Releases Wiki Activity

Fix Content-Disposition header to comply with RFC 2183/8187

Browse Source 
Changed Content-Disposition header from filename="name.ext" format
to RFC 8187 compliant filename*=utf-8''encoded format.

This ensures proper handling of special characters in filenames
and compliance with web standards.

Fixes Comfy-Org/ComfyUI#8914
This commit is contained in:
Hermes Agent 2026-04-23 19:50:16 +08:00
parent 3cdc0d523f
commit b00db6fad0
1 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
server.py
View File

@ -54,6 +54,24 @@ if args.enable_manager:
import comfyui_manager
def _make_content_disposition(filename: str) -> str:
"""
Generate RFC 8187 compliant Content-Disposition header.
According to RFC 8187, the filename parameter should use the extended notation
with 'filename*=' and 'utf-8'' language tag when the filename contains non-ASCII
characters or needs special encoding.
Examples:
ASCII: filename="test.png"
Unicode: filename*=utf-8''%E6%B5%8B%E8%AF%95.png
"""
import urllib.parse
# Always use RFC 8187 extended notation for maximum compatibility
encoded_filename = urllib.parse.quote(filename, safe='')
return f"filename*=utf-8''{encoded_filename}"
def _remove_sensitive_from_queue(queue: list) -> list:
"""Remove sensitive data (index 5) from queue item tuples."""
return [item[:5] for item in queue]
@ -559,7 +577,7 @@ class PromptServer():
buffer.seek(0)
return web.Response(body=buffer.read(), content_type=f'image/{image_format}',
headers={"Content-Disposition": f"filename=\"{filename}\""})
headers={"Content-Disposition": _make_content_disposition(filename)})
if 'channel' not in request.rel_url.query:
channel = 'rgba'
@ -579,7 +597,7 @@ class PromptServer():
buffer.seek(0)
return web.Response(body=buffer.read(), content_type='image/png',
headers={"Content-Disposition": f"filename=\"{filename}\""})
headers={"Content-Disposition": _make_content_disposition(filename)})
elif channel == 'a':
with Image.open(file) as img:
@ -596,7 +614,7 @@ class PromptServer():
alpha_buffer.seek(0)
return web.Response(body=alpha_buffer.read(), content_type='image/png',
headers={"Content-Disposition": f"filename=\"{filename}\""})
headers={"Content-Disposition": _make_content_disposition(filename)})
else:
# Use the content type from asset resolution if available,
# otherwise guess from the filename.
@ -613,7 +631,7 @@ class PromptServer():
return web.FileResponse(
file,
headers={
"Content-Disposition": f"filename=\"{filename}\"",
"Content-Disposition": _make_content_disposition(filename),
"Content-Type": content_type
}
)