wangbo/ComfyUI
1
0
Fork 0
mirror of https://github.com/comfyanonymous/ComfyUI.git synced 2026-03-10 03:37:33 +08:00
Code Issues Actions 13 Packages Projects Releases Wiki Activity

Fix links on convert to nodes

Browse Source
This commit is contained in:
pythongosssss 2023-11-04 11:30:33 +00:00
parent b6fb105b95
commit b3f759d979
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests-ui/tests/groupNode.test.js
View File

@ -138,11 +138,20 @@ describe("group node", () => {
const nodes = createDefaultWorkflow(ez, graph); const nodes = createDefaultWorkflow(ez, graph);
const save2 = ez.SaveImage(...nodes.decode.outputs); const save2 = ez.SaveImage(...nodes.decode.outputs);
const save3 = ez.SaveImage(...nodes.decode.outputs); const save3 = ez.SaveImage(...nodes.decode.outputs);
// Ensure an output with multiple links maintains them on convert to group
const group = await convertToGroup(app, graph, "test", [nodes.sampler, nodes.decode]); const group = await convertToGroup(app, graph, "test", [nodes.sampler, nodes.decode]);
expect(group.outputs[0].connections.length).toBe(3); expect(group.outputs[0].connections.length).toBe(3);
expect(group.outputs[0].connections[0].targetNode.id).toBe(nodes.save.id); expect(group.outputs[0].connections[0].targetNode.id).toBe(nodes.save.id);
expect(group.outputs[0].connections[1].targetNode.id).toBe(save2.id); expect(group.outputs[0].connections[1].targetNode.id).toBe(save2.id);
expect(group.outputs[0].connections[2].targetNode.id).toBe(save3.id); expect(group.outputs[0].connections[2].targetNode.id).toBe(save3.id);
// and they're still linked when converting back to nodes
const newNodes = group.menu["Convert to nodes"].call();
const decode = graph.find(newNodes.find((n) => n.type === "VAEDecode"));
expect(decode.outputs[0].connections.length).toBe(3);
expect(decode.outputs[0].connections[0].targetNode.id).toBe(nodes.save.id);
expect(decode.outputs[0].connections[1].targetNode.id).toBe(save2.id);
expect(decode.outputs[0].connections[2].targetNode.id).toBe(save3.id);
}); });
test("can be be converted back to nodes", async () => { test("can be be converted back to nodes", async () => {

3
web/extensions/core/groupNode.js
View File

@ -554,7 +554,8 @@ const ext = {
for (let outputId = 0; outputId < node.outputs?.length; outputId++) { for (let outputId = 0; outputId < node.outputs?.length; outputId++) {
const output = node.outputs[outputId]; const output = node.outputs[outputId];
if (!output.links) continue; if (!output.links) continue;
for (const l of output.links) { const links = [...output.links];
for (const l of links) {
const slot = slots.outputs[outputId]; const slot = slots.outputs[outputId];
const link = app.graph.links[l]; const link = app.graph.links[l];
const targetNode = app.graph.getNodeById(link.target_id); const targetNode = app.graph.getNodeById(link.target_id);