mirror of
https://github.com/comfyanonymous/ComfyUI.git
synced 2026-04-15 13:02:35 +08:00
fix(workflow): ensure Publish runs by marking build result unconditionally
The publish job was skipped because the build jobs never set their `built` output. A failed earlier step combined with job-level `continue-on-error` caused `success()` to evaluate false, so the “Mark build success” step did not run and outputs were empty. Removed job-level `continue-on-error` and replaced the marker step with an `always()`-gated step that derives `built` from `docker/build-push-action`’s `digest` output. Mirrored this in the self-hosted fallback. Kept `permissions: contents: write` for release creation. No functional changes elsewhere.
This commit is contained in:
parent
02f4e49f90
commit
b59e789284
25
.github/workflows/sync-build-release.yml
vendored
25
.github/workflows/sync-build-release.yml
vendored
@ -78,7 +78,6 @@ jobs:
|
||||
needs: check-upstream
|
||||
if: needs.check-upstream.outputs.new_version != 'none'
|
||||
runs-on: ubuntu-latest
|
||||
continue-on-error: true
|
||||
outputs:
|
||||
built: ${{ steps.mark.outputs.built }}
|
||||
digest: ${{ steps.build.outputs.digest }}
|
||||
@ -182,10 +181,16 @@ jobs:
|
||||
${{ env.IMAGE_NAME }}:${{ needs.check-upstream.outputs.new_version }}
|
||||
${{ env.IMAGE_NAME }}:latest
|
||||
|
||||
- name: Mark build success
|
||||
- name: Mark build result
|
||||
id: mark
|
||||
if: ${{ success() && steps.build.outputs.digest != '' }}
|
||||
run: echo "built=true" >> "$GITHUB_OUTPUT"
|
||||
if: ${{ always() }}
|
||||
shell: bash
|
||||
run: |
|
||||
if [ -n "${{ steps.build.outputs.digest }}" ]; then
|
||||
echo "built=true" >> "$GITHUB_OUTPUT"
|
||||
else
|
||||
echo "built=false" >> "$GITHUB_OUTPUT"
|
||||
fi
|
||||
|
||||
build-self:
|
||||
name: Build on Self-Hosted (fallback)
|
||||
@ -272,10 +277,16 @@ jobs:
|
||||
${{ env.IMAGE_NAME }}:${{ needs.check-upstream.outputs.new_version }}
|
||||
${{ env.IMAGE_NAME }}:latest
|
||||
|
||||
- name: Mark build success
|
||||
- name: Mark build result
|
||||
id: mark
|
||||
if: ${{ success() && steps.build.outputs.digest != '' }}
|
||||
run: echo "built=true" >> "$GITHUB_OUTPUT"
|
||||
if: ${{ always() }}
|
||||
shell: bash
|
||||
run: |
|
||||
if [ -n "${{ steps.build.outputs.digest }}" ]; then
|
||||
echo "built=true" >> "$GITHUB_OUTPUT"
|
||||
else
|
||||
echo "built=false" >> "$GITHUB_OUTPUT"
|
||||
fi
|
||||
|
||||
- name: Remove BuildKit image (moby/buildkit)
|
||||
if: ${{ always() }}
|
||||
|
||||
Loading…
Reference in New Issue
Block a user