wangbo/ComfyUI
1
0
Fork 0
mirror of https://github.com/comfyanonymous/ComfyUI.git synced 2026-06-27 18:29:49 +08:00
Code Issues Actions 18 Packages Projects Releases Wiki Activity

refactor(pagination): hoist cursor codec to utils/ for cross-domain reuse

Browse Source 
The keyset cursor codec was asset-namespaced (app/assets/services/cursor.py)
but the wire format and encode/decode logic are domain-agnostic. Move it to
utils/cursor.py so the jobs endpoint can share one codec instead of importing
across domains or duplicating it.
This commit is contained in:
Matt Miller 2026-06-08 17:24:48 -07:00
parent 71a20886ec
commit ba8ea12922
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/api/routes.py
View File

@ -39,7 +39,7 @@ from app.assets.services import (
update_asset_metadata, update_asset_metadata,
upload_from_temp_path, upload_from_temp_path,
) )
from app.assets.services.cursor import InvalidCursorError from utils.cursor import InvalidCursorError
from app.assets.services.tagging import list_tag_histogram from app.assets.services.tagging import list_tag_histogram
ROUTES = web.RouteTableDef() ROUTES = web.RouteTableDef()

2
app/assets/services/asset_management.py
View File

@ -4,7 +4,7 @@ import os
from datetime import timezone from datetime import timezone
from typing import Sequence from typing import Sequence
from app.assets.services.cursor import ( from utils.cursor import (
CursorPayload, CursorPayload,
InvalidCursorError, InvalidCursorError,
decode_cursor, decode_cursor,

4
tests-unit/assets_test/services/test_cursor.py
View File

@ -1,4 +1,4 @@
"""Tests for app.assets.services.cursor. """Tests for utils.cursor.
Cursors are opaque tokens internal to this server — these tests cover Cursors are opaque tokens internal to this server — these tests cover
round-tripping, validation, and length caps, not any particular wire round-tripping, validation, and length caps, not any particular wire
@ -11,7 +11,7 @@ from datetime import datetime, timedelta, timezone
import pytest import pytest
from app.assets.services.cursor import ( from utils.cursor import (
MAX_CURSOR_ID_LENGTH, MAX_CURSOR_ID_LENGTH,
MAX_CURSOR_VALUE_LENGTH, MAX_CURSOR_VALUE_LENGTH,
MAX_ENCODED_CURSOR_LENGTH, MAX_ENCODED_CURSOR_LENGTH,

2
app/assets/services/cursor.py → utils/cursor.py
View File

@ -1,4 +1,4 @@
"""Opaque keyset-pagination cursor for /api/assets. """Opaque keyset-pagination cursor shared by /api/assets and /api/jobs.
Payload JSON uses short keys to keep the encoded length small: Payload JSON uses short keys to keep the encoded length small: