fe: Consolidate warnings (#13970)

This commit is contained in:
rattus 2026-05-22 12:18:13 +10:00 committed by GitHub
parent 8edff549e3
commit f48c32871b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -62,6 +62,8 @@ def get_comfy_package_versions():
def check_comfy_packages_versions(): def check_comfy_packages_versions():
"""Warn for every comfy* package whose installed version is below requirements.txt.""" """Warn for every comfy* package whose installed version is below requirements.txt."""
from packaging.version import InvalidVersion, parse as parse_pep440 from packaging.version import InvalidVersion, parse as parse_pep440
outdated_packages = []
for pkg in get_comfy_package_versions(): for pkg in get_comfy_package_versions():
installed_str = pkg["installed"] installed_str = pkg["installed"]
required_str = pkg["required"] required_str = pkg["required"]
@ -73,19 +75,26 @@ def check_comfy_packages_versions():
logging.error(f"Failed to check {pkg['name']} version: {e}") logging.error(f"Failed to check {pkg['name']} version: {e}")
continue continue
if outdated: if outdated:
app.logger.log_startup_warning( outdated_packages.append((pkg["name"], installed_str, required_str))
f""" else:
logging.info("{} version: {}".format(pkg["name"], installed_str))
if outdated_packages:
package_warnings = "\n".join(
f"Installed {name} version {installed} is lower than the recommended version {required}."
for name, installed, required in outdated_packages
)
app.logger.log_startup_warning(
f"""
________________________________________________________________________ ________________________________________________________________________
WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING
Installed {pkg["name"]} version {installed_str} is lower than the recommended version {required_str}. {package_warnings}
{get_missing_requirements_message()} {get_missing_requirements_message()}
________________________________________________________________________ ________________________________________________________________________
""".strip() """.strip()
) )
else:
logging.info("{} version: {}".format(pkg["name"], installed_str))
REQUEST_TIMEOUT = 10 # seconds REQUEST_TIMEOUT = 10 # seconds