wangbo/ComfyUI
1
0
Fork 0
mirror of https://github.com/comfyanonymous/ComfyUI.git synced 2026-06-05 13:57:37 +08:00
Code Issues Actions 32 Packages Projects Releases Wiki Activity

Fix camera translation

Browse Source
This commit is contained in:
kijai 2026-05-31 02:08:21 +03:00
parent 4a8143f063
commit fbd3ab6417
1 changed files with 22 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
comfy_extras/nodes_gaussian_splat.py
View File

@ -543,20 +543,29 @@ def _view_matrix_t(yaw_deg, pitch_deg, device):
def _camera_basis(camera_info, dev): def _camera_basis(camera_info, dev):
# Look-at basis (eye, target, right, up, fwd) in the splat frame. The Load3D camera frame is Y-up and # Look-at basis in the splat frame, named by their projection rows: right = image +x, up = image +y
# rotated 90 deg about the up axis vs the splat frame, so remap each point (x,y,z) -> (z,-y,-x). # (down, since yflip=1), fwd = view/depth axis (eye -> scene). Load3D is three.js (right-handed, Y-up,
# camera looks down -Z); the splat is 3DGS (Y-down, Z-forward). World -> splat is a 180 deg rotation
# about X: (x, y, z) -> (x, -y, -z) (det +1, no mirror, no axis swap).
pos, tgt = camera_info.get("position", {}), camera_info.get("target", {}) pos, tgt = camera_info.get("position", {}), camera_info.get("target", {})
g = lambda d: torch.tensor([float(d.get("z", 0.0)), -float(d.get("y", 0.0)), -float(d.get("x", 0.0))], device=dev) m = lambda d: torch.tensor([float(d.get("x", 0.0)), -float(d.get("y", 0.0)), -float(d.get("z", 0.0))], device=dev)
eye, target = g(pos), g(tgt) eye, target = m(pos), m(tgt)
fwd = target - eye mv = lambda v: torch.stack([v[0], -v[1], -v[2]]) # same world->splat map, for direction vectors
fwd = fwd / fwd.norm().clamp_min(1e-8) n = lambda v: v / v.norm().clamp_min(1e-8)
up0 = torch.tensor([0.0, 1.0, 0.0], device=dev) q = camera_info.get("quaternion")
if fwd.dot(up0).abs() > 0.999: # looking straight up/down if q: # exact camera world rotation (incl. roll)
up0 = torch.tensor([0.0, 0.0, 1.0], device=dev) qwxyz = torch.tensor([float(q.get("w", 1.0)), float(q.get("x", 0.0)),
right = torch.linalg.cross(up0, fwd) float(q.get("y", 0.0)), float(q.get("z", 0.0))], device=dev)
right = right / right.norm().clamp_min(1e-8) R = _quat_to_mat(qwxyz[None])[0] # columns = camera world axes; looks down local -Z
up = torch.linalg.cross(fwd, right) right = n(mv(R[:, 0])) # camera +X -> image right
return eye, target, right, up, fwd up = n(mv(-R[:, 1])) # camera +Y is image up; image-down row is its negative
fwd = n(mv(-R[:, 2])) # camera looks down local -Z -> view direction
return eye, target, right, up, fwd
fwd = n(target - eye) # no quaternion: orbit-consistent, roll-free
yaw = math.degrees(math.atan2(-float(fwd[0]), float(fwd[2])))
pitch = math.degrees(math.asin(max(-1.0, min(1.0, float(fwd[1])))))
W = _view_matrix_t(yaw, pitch, dev)
return eye, target, W[0], W[1], W[2]
def _gauss_blur(x, sigma, dev): def _gauss_blur(x, sigma, dev):