Yousef R. Gamaleldin
02529c6d57
Merge branch 'master' into seedvr2
2025-12-31 20:20:32 +02:00
mengqin
0357ed7ec4
Add support for sage attention 3 in comfyui, enable via new cli arg ( #11026 )
...
* Add support for sage attention 3 in comfyui, enable via new cli arg
--use-sage-attiention3
* Fix some bugs found in PR review. The N dimension at which Sage
Attention 3 takes effect is reduced to 1024 (although the improvement is
not significant at this scale).
* Remove the Sage Attention3 switch, but retain the attention function
registration.
* Fix a ruff check issue in attention.py
2025-12-30 22:53:52 -05:00
drozbay
178bdc5e14
Add handling for vace_context in context windows ( #11386 )
...
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Co-authored-by: ozbayb <17261091+ozbayb@users.noreply.github.com>
2025-12-30 14:40:42 -08:00
Yousef Rafat
49febe15c3
Merge branch 'seedvr2' of https://github.com/yousef-rafat/ComfyUI into seedvr2
2025-12-30 18:45:13 +02:00
Yousef Rafat
84fa155071
fixed manual vae loading
2025-12-30 18:44:57 +02:00
Jedrzej Kosinski
4691717340
Merge branch 'master' into seedvr2
2025-12-29 19:00:13 -08:00
comfyanonymous
0e6221cc79
Add some warnings for pin and unpin errors. ( #11561 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2025-12-29 18:26:42 -05:00
rattus
9ca7e143af
mm: discard async errors from pinning failures ( #10738 )
...
Pretty much every error cudaHostRegister can throw also queues the same
error on the async GPU queue. This was fixed for repinning error case,
but there is the bad mmap and just enomem cases that are harder to
detect.
Do some dummy GPU work to clean the error state.
2025-12-29 18:19:34 -05:00
comfyanonymous
8fd07170f1
Comment out unused norm_final in lumina/z image model. ( #11545 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2025-12-28 22:07:25 -05:00
comfyanonymous
2943093a53
Enable async offload by default for AMD. ( #11534 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Generate Pydantic Stubs from api.comfy.org / generate-models (push) Has been cancelled
2025-12-27 18:54:15 -05:00
comfyanonymous
1e4e342f54
Fix noise with ancestral samplers when inferencing on cpu. ( #11528 )
2025-12-26 22:03:01 -05:00
Yousef Rafat
fadc7839cc
ruff
2025-12-26 23:14:33 +02:00
Yousef Rafat
9b573da39b
added other types of attention + compatibility
...
with images
2025-12-26 21:16:36 +02:00
Yousef Rafat
21bc67d7db
final changes
2025-12-26 02:08:59 +02:00
Yousef Rafat
7b2e5ef0af
outputs/speed/memory match custom node
2025-12-24 22:15:27 +02:00
Yousef Rafat
1afc2ed8e6
fixed the speed issue
2025-12-24 02:23:57 +02:00
Yousef Rafat
d41b1111eb
removed print statement
2025-12-23 12:36:10 +02:00
Yousef Rafat
5b0c80a093
ruff
2025-12-23 12:35:00 +02:00
Yousef Rafat
fc5fabb629
.
2025-12-22 21:16:21 +02:00
Yousef Rafat
5db5da790f
remove cfg cutoff node
2025-12-22 21:15:12 +02:00
Yousef Rafat
a4e9d071e8
video works
2025-12-22 18:12:46 +02:00
Yousef Rafat
4fe772fae9
improvements
2025-12-20 23:20:45 +02:00
comfyanonymous
fb478f679a
Only apply gemma quant config to gemma model for newbie. ( #11436 )
2025-12-20 01:02:43 -05:00
woctordho
4c432c11ed
Implement Jina CLIP v2 and NewBie dual CLIP ( #11415 )
...
* Implement Jina CLIP v2
* Support quantized Gemma in NewBie dual CLIP
2025-12-20 00:57:22 -05:00
comfyanonymous
31e961736a
Fix issue with batches and newbie. ( #11435 )
2025-12-20 00:23:51 -05:00
comfyanonymous
3ab9748903
Disable prompt weights on newbie te. ( #11434 )
2025-12-20 00:19:47 -05:00
woctordho
0aa7fa464e
Implement sliding attention in Gemma3 ( #11409 )
2025-12-20 00:16:46 -05:00
drozbay
514c24d756
Fix error from logging line ( #11423 )
...
Co-authored-by: ozbayb <17261091+ozbayb@users.noreply.github.com>
2025-12-19 20:22:45 -08:00
comfyanonymous
809ce68749
Support nested tensor denoise masks. ( #11431 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2025-12-19 19:59:25 -05:00
BradPepersAMD
cc4ddba1b6
Allow enabling use of MIOpen by setting COMFYUI_ENABLE_MIOPEN=1 as an env var ( #11366 )
2025-12-19 17:01:50 -05:00
Yousef Rafat
7e62f8cc9f
added var length attention and fixed the vae issue
2025-12-19 20:23:39 +02:00
comfyanonymous
28eaab608b
Diffusion model part of Qwen Image Layered. ( #11408 )
...
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Build package / Build Test (3.10) (push) Has been cancelled
Build package / Build Test (3.11) (push) Has been cancelled
Build package / Build Test (3.12) (push) Has been cancelled
Build package / Build Test (3.13) (push) Has been cancelled
Build package / Build Test (3.9) (push) Has been cancelled
Only thing missing after this is some nodes to make using it easier.
2025-12-18 20:21:14 -05:00
comfyanonymous
6a2678ac65
Trim/pad channels in VAE code. ( #11406 )
2025-12-18 18:22:38 -05:00
comfyanonymous
e4fb3a3572
Support loading Wan/Qwen VAEs with different in/out channels. ( #11405 )
2025-12-18 17:45:33 -05:00
Yousef Rafat
db74a27870
fix vae issue
2025-12-18 14:13:41 +02:00
comfyanonymous
bf7dc63bd6
skip_load_model -> force_full_load ( #11390 )
...
This should be a bit more clear and less prone to potential breakage if the
logic of the load models changes a bit.
2025-12-17 23:29:32 -05:00
Kohaku-Blueleaf
86dbb89fc9
Resolution bucketing and Trainer implementation refactoring ( #11117 )
2025-12-17 22:15:27 -05:00
Yousef Rafat
acb9a11c6f
Merge branch 'seedvr2' of https://github.com/yousef-rafat/ComfyUI into seedvr2
2025-12-18 00:37:32 +02:00
Yousef Rafat
d9f71da998
works
2025-12-18 00:32:14 +02:00
chaObserv
5d9ad0c6bf
Fix the last step with non-zero sigma in sa_solver ( #11380 )
2025-12-17 13:57:40 -05:00
chaObserv
827bb1512b
Add exp_heun_2_x0 sampler series ( #11360 )
2025-12-16 23:35:43 -05:00
Yousef R. Gamaleldin
183b377588
Merge branch 'master' into seedvr2
2025-12-17 00:39:06 +02:00
Yousef Rafat
ebd945ce3d
vae fix
2025-12-17 00:09:38 +02:00
comfyanonymous
ffdd53b327
Check state dict key to auto enable the index_timestep_zero ref method. ( #11362 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2025-12-16 17:03:17 -05:00
comfyanonymous
bc606d7d64
Add a way to set the default ref method in the qwen image code. ( #11349 )
2025-12-16 01:26:55 -05:00
comfyanonymous
683569de55
Only enable fp16 on ZImage on newer pytorch. ( #11344 )
2025-12-15 22:33:27 -05:00
Haoming
ea2c117bc3
[BlockInfo] Wan ( #10845 )
...
* block info
* animate
* tensor
* device
* revert
2025-12-15 17:59:16 -08:00
Haoming
fc4af86068
[BlockInfo] Lumina ( #11227 )
...
* block info
* device
* Make tensor int again
---------
Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>
2025-12-15 17:57:28 -08:00
comfyanonymous
70541d4e77
Support the new qwen edit 2511 reference method. ( #11340 )
...
index_timestep_zero can be selected in the
FluxKontextMultiReferenceLatentMethod now with the display name set to the
more generic "Edit Model Reference Method" node.
2025-12-15 19:20:34 -05:00
drozbay
77b2f7c228
Add context windows callback for custom cond handling ( #11208 )
...
Co-authored-by: ozbayb <17261091+ozbayb@users.noreply.github.com>
2025-12-15 16:06:32 -08:00