Commit Graph

167 Commits

Author SHA1 Message Date
GitHub Actions
2c099490d4 Merge upstream/master, keep local README.md 2025-10-01 05:03:19 +00:00
clsferguson
66bf02226a
Update sync-build-release.yml 2025-09-30 22:50:18 -06:00
clsferguson
36ebd94215
Update sync-build-release.yml 2025-09-30 22:49:27 -06:00
clsferguson
a719a6ad41
Update sync-build-release.yml 2025-09-30 22:42:54 -06:00
clsferguson
14e8bb4ef8
Update sync-build-release.yml 2025-09-30 22:41:26 -06:00
clsferguson
1169a1155d
Update sync-build-release.yml 2025-09-30 22:33:57 -06:00
clsferguson
6073804c99
Update sync-build-release.yml 2025-09-30 22:31:21 -06:00
clsferguson
3f8212cb2e
Update sync-build-release.yml 2025-09-30 22:28:44 -06:00
clsferguson
77ec7befa2
feat(ci): clean runners pre-build, GH-hosted first, self-hosted fallback, fail if both fail
- Add pre-build cleanup on GitHub-hosted runner using jlumbroso/free-disk-space plus Docker builder/system prune to maximize available disk for Docker builds.
- Add pre-build Docker cache pruning and disk checks on self-hosted runner to keep it minimal and appropriate for ephemeral runners.
- Change fallback logic to run self-hosted only if the GitHub-hosted build fails, using needs.<job>.result with always() to ensure the fallback job triggers after a primary failure.
- Keep GHCR login via docker/login-action@v3 and Buildx via docker/setup-buildx-action@v3; build with docker/build-push-action@v6.
- Publish release only if either build path succeeds; fail workflow if both builds or release publish fail.
- Remove post-build cleanup steps (BuildKit image removal and general pruning) to align with instruction not to worry about post cleanup on ephemeral runners.
2025-09-30 21:59:41 -06:00
clsferguson
249ff20e20
ci(sync): detect upstream release, sync master, build with GH fallback, and publish release
- Gate on new upstream release whose tag matches comfyui_version.py; skip if already released locally.
- Sync master from upstream (keep local README.md), then build and push image on GH runner with pre-clean; fallback to ephemeral self-hosted if GH build fails; publish release if either path succeeds.
- Remove unnecessary post-job cleanup since runners are ephemeral; rely on setup-buildx cleanup.
2025-09-30 15:07:11 -06:00
clsferguson
ae49228b6e
ci(workflow): remove post-job Docker prunes; keep pre-clean and reliable self-hosted fallback
- Keep pre-build cleanup on GH runners (free-disk-space action and Docker builder/system prune) to prevent ENOSPC during builds.
- Remove post-job prune steps for both GH and ephemeral self-hosted runners since runners are discarded after the job and setup-buildx uses cleanup=true to remove builders automatically.
- Retain fallback: self-hosted build runs only if the GH build fails; publish succeeds if either path succeeds; final job fails only if both builds fail.
2025-09-30 14:55:38 -06:00
clsferguson
dea2903ce2
ci: free disk on GH runner, prune Docker cache, and reliable self-hosted fallback
- Add “Free Disk Space (Ubuntu)” and Docker prune steps before/after the GitHub-hosted build to recover tens of GB and avoid “no space left on device” failures on ubuntu-latest.
- Remove continue-on-error and gate the self-hosted job with `always() && needs.build-gh.result != 'success'` so it runs only if the GH build fails, while publish proceeds if either path succeeds.
- Enable buildx GHA cache (cache-from/cache-to) to minimize runner disk pressure and rebuild times without loading images locally.
2025-09-30 13:03:03 -06:00
comfyanonymous
6e079abc3a
Workflow permission fix. (#10110) 2025-09-29 23:11:37 -04:00
comfyanonymous
447884b657
Make stable release workflow callable. (#10108) 2025-09-29 20:37:51 -04:00
comfyanonymous
bed4b49d08
Add action to do the full stable release. (#10107) 2025-09-29 20:31:15 -04:00
comfyanonymous
342cf644ce
Add a way to have different names for stable nvidia portables. (#10106) 2025-09-29 20:05:44 -04:00
comfyanonymous
3758848423
Different base files for nvidia and amd portables. (#10105) 2025-09-29 19:54:37 -04:00
comfyanonymous
0db6aabed3
Different base files for different release. (#10104) 2025-09-29 19:54:05 -04:00
comfyanonymous
1673ace19b
Make the final release test optional in the stable release action. (#10103) 2025-09-29 19:08:42 -04:00
comfyanonymous
7f38e4c538
Add action to create cached deps with manually specified torch. (#10102) 2025-09-29 17:27:52 -04:00
comfyanonymous
555f902fc1
Fix stable workflow creating multiple draft releases. (#10067) 2025-09-27 22:43:25 -04:00
comfyanonymous
896f2e653c
Fix typo in release workflow. (#10066) 2025-09-27 21:30:35 -04:00
comfyanonymous
40ae495ddc
Improvements to the stable release workflow. (#10065) 2025-09-27 20:28:49 -04:00
comfyanonymous
2b7f9a8196
Fix the failing unit test. (#10037) 2025-09-26 14:12:43 -04:00
clsferguson
4369ba2e3d
Update build-release.yml 2025-09-21 22:46:37 -06:00
clsferguson
627ec0f9b7
ci: auto‑fallback to self‑hosted when GH runner build fails using step outcome output
Replace job‑level continue‑on‑error with a step‑level setting and export build_succeeded from the docker/build‑push step to drive the fallback condition, guaranteeing the self‑hosted job runs whenever the GitHub runner fails (e.g., disk space) instead of being masked by a successful job conclusion. Update publish/finalize gating to rely on the explicit output flag (or self‑hosted success) so releases proceed only when at least one build path publishes successfully.
2025-09-21 22:45:09 -06:00
clsferguson
ab630fcca0
Add cleanup step in sync-build-release workflow 2025-09-12 20:36:26 -06:00
clsferguson
c7989867d7
Refactor upstream release check and cleanup steps 2025-09-12 20:34:49 -06:00
clsferguson
0d76dc1b18
Implement finalize job for workflow outcomes
Added a finalize job to handle outcomes based on upstream releases and publish results.
2025-09-12 10:56:16 -06:00
clsferguson
1da5dc48e6
Refactor CI workflow conditions and cleanup steps
Updated conditions for build and publish steps in CI workflow.
2025-09-12 10:47:02 -06:00
clsferguson
7b3b6fcbfd
Remove provenance and SBOM options from Docker builds 2025-09-10 22:53:05 -06:00
clsferguson
9df654da53
Remove provenance and sbom from build-release.yml
Removed 'provenance' and 'sbom' options from Docker build steps.
2025-09-10 22:50:24 -06:00
clsferguson
84cf9a63e7
Update release body message in workflow 2025-09-10 21:52:07 -06:00
clsferguson
a8ada2ac01
Add latest Docker image pull command to release notes
Updated release notes to include latest Docker image pull command.
2025-09-10 21:50:14 -06:00
clsferguson
4b11a769ad
Update release message for Docker image
Updated release body to indicate version sync from upstream.
2025-09-10 21:47:54 -06:00
clsferguson
97ac355d16
Add platform specification for Docker builds 2025-09-10 21:39:39 -06:00
clsferguson
7decaccfcd
Add platform specification for Docker builds 2025-09-10 21:38:58 -06:00
clsferguson
f5e15d6ec8
Add manual workflow for resume publishing 2025-09-10 21:11:35 -06:00
clsferguson
764e46efe0
Refactor GitHub Actions workflow for Docker builds 2025-09-10 21:07:18 -06:00
clsferguson
a86c49b5ff
Refactor publish and finalize conditions in workflow
Updated conditions for publishing and finalizing outcomes in the CI workflow.
2025-09-10 21:05:46 -06:00
clsferguson
065049892c
Refactor release workflow and remove cleanup steps
Removed package cleanup steps and updated release name.
2025-09-09 23:03:26 -06:00
clsferguson
4b9b7ba771
Refactor sync-build-release workflow
Removed unnecessary cleanup steps and adjusted job names.
2025-09-09 23:02:38 -06:00
clsferguson
8b0f8fe7a3
Add workflow for cleaning up untagged GHCR images 2025-09-09 22:58:20 -06:00
clsferguson
8538d95ce5
Refactor CI workflow for GitHub-hosted runners
Updated workflow to use GitHub-hosted runners and added cleanup steps for Docker images.
2025-09-09 22:27:46 -06:00
clsferguson
72544433ab
Add build-release workflow for Docker image 2025-09-09 21:45:22 -06:00
clsferguson
babceb30a5
Add sync and build workflow for Docker image
This workflow syncs the fork with the upstream repository and builds a Docker image on new releases.
2025-09-06 21:42:16 -06:00
guill
a9f1bb10a5
Fix progress update crossover between users (#9706)
* Fix showing progress from other sessions

Because `client_id` was missing from ths `progress_state` message, it
was being sent to all connected sessions. This technically meant that if
someone had a graph with the same nodes, they would see the progress
updates for others.

Also added a test to prevent reoccurance and moved the tests around to
make CI easier to hook up.

* Fix CI issues related to timing-sensitive tests
2025-09-04 19:13:28 -04:00
filtered
644b23ac0b
Make custom node testing checkbox optional in issue templates (#9342)
The checkbox for confirming custom node testing is now optional in both bug report and user support templates. This allows users to submit issues even if they haven't been able to test with custom nodes disabled, making the reporting process more accessible.
2025-08-14 17:36:53 -04:00
comfyanonymous
afa0a45206
Reduce portable size again. (#9323)
* compress more

* test

* not needed
2025-08-13 14:42:08 -04:00
comfyanonymous
5ca8e2fac3
Update release workflow to python3.13 pytorch cu129 (#9315)
* Try to reduce size of portable even more.

* Update stable release workflow to python 3.13 cu129

* Update dependencies workflow to python3.13 cu129
2025-08-13 03:01:12 -04:00