Commit Graph

5453 Commits

Author SHA1 Message Date
comfyanonymous
d4c7ebff9c
Remove old useless no comfy kitchen fallback. (#14245)
* Remove old fallback used when no comfy kitchen.

* Remove unused logging import
2026-06-02 17:52:41 -07:00
Jukka Seppänen
dc10c0133e
PiD: Add SDXL and QwenImage (#14240)
Some checks are pending
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-06-02 12:40:49 -07:00
Quasar of Mikus
e9207aa7cc
fix (MultiGPU): prevent freeze on manual abort when using MultiGPU CFG Split (#14235)
* fix (MultiGPU): prevent freeze on manual abort when using MultiGPU CFG Split

Problem:
Upon manual abort application hangs indefinitely.
`InterruptProcessingException` inherits from `BaseException` and bypasses MultiGPU's worker error handling block so thread dies silently, leaving the main thread waiting forever for `result_q.get()`

Fix:
Catch `comfy.model_management.InterruptProcessingException` instead of `Exception` so it's caught and passed back via `result_q` to unblock the main thread when manual abort signal fires.

* oops
2026-06-02 10:05:24 -07:00
person4268
c96fcddb81
Radiance: support variant with nonzero txt_ids (#14206)
Some checks are pending
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-06-01 22:07:48 -07:00
Alexis Rolland
e88a81d316
Revert partner nodes category (#14229)
Some checks are pending
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-06-01 21:24:46 -07:00
vidigoat
33799c4a2e
Fix uncaught OverflowError in Math Expression node for large int results (#14214) 2026-06-01 18:15:04 -07:00
comfyanonymous
4b48535a7d
Do tripo dinov3 inference in fp32. (#14221) 2026-06-01 18:08:20 -07:00
comfyanonymous
06b710aa68
Fix issue with triposplat preview and old offloading mode. (#14218) 2026-06-01 14:35:52 -07:00
comfyanonymous
e785f0d212
Some cast/dtype fixes for the birefnet and dino3 models. (#14217) 2026-06-01 14:35:26 -07:00
comfyanonymous
a88e02b185 ComfyUI v0.23.0
Some checks failed
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Build package / Build Test (3.10) (push) Has been cancelled
Build package / Build Test (3.11) (push) Has been cancelled
Build package / Build Test (3.12) (push) Has been cancelled
Build package / Build Test (3.13) (push) Has been cancelled
Build package / Build Test (3.14) (push) Has been cancelled
2026-06-01 13:05:25 -04:00
Alexander Piskun
0b610bd63a
[Partner Nodes] fix: respect VideoSlice trim when resizing videos (#14213) 2026-06-01 09:09:57 -07:00
Daxiong (Lin)
412d9ac33a
chore: update workflow templates to v0.9.92 (#14212) 2026-06-01 07:41:00 -07:00
Alexander Piskun
af58c5e674
[Partner Nodes] feat: add Flux Virtual Try-On and Erase nodes (#14207) 2026-06-01 07:12:12 -07:00
Talmaj Marinc
15f4dc401a Switch to optimized_attention_for_device in camera DA3 module.
Some checks failed
Build package / Build Test (3.12) (push) Has been cancelled
Build package / Build Test (3.11) (push) Has been cancelled
Python Linting / Run Ruff (push) Has been cancelled
Python Linting / Run Pylint (push) Has been cancelled
Build package / Build Test (3.10) (push) Has been cancelled
Build package / Build Test (3.13) (push) Has been cancelled
Build package / Build Test (3.14) (push) Has been cancelled
2026-06-01 16:11:04 +02:00
Talmaj Marinc
f57ebb4cf4 Simplify/remove duplication in detect_unet_config for Depth Anything 3 2026-06-01 16:11:04 +02:00
Talmaj Marinc
5861890010 Change categories for DA3 nodes. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
1bb9f729d9 Change wording from ignored to used in tooltips DA3. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
0d7fa3f5ab Improve tooltips DA3 2026-06-01 16:11:04 +02:00
Talmaj Marinc
e58a25afd4 Replace em dashes with - 2026-06-01 16:11:04 +02:00
Talmaj Marinc
a1da4c9c35 Fix da3_geometry parameter and add colored flag to confidence and sky map. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
80b3ce106d Simplify language of tooltips. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
26eb6bf777 Apply PR comments, reduce verbosity of docstrings, unify model and image/frame naming convention. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
da221da050 Refactor and rename nodes to from DepthAnyting3 to use DA3 naming convention. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
956f6b9950 Fix confidence use in DA3ToMesh by using normalization, fix extrisinc usage. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
724bb7b525 Fix extrinsic quaternions by normalizing them to unit quaternion. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
9f7dbb5bf6 Add DA3GeometryToMesh and DA3GeometryToPointCloud 2026-06-01 16:11:04 +02:00
Talmaj Marinc
b3b55fcb42 Improve and correct error logging for mono/multi-view. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
03aa1f2e5c Improve tooltips. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
372ab13938 Fixup last few naming issues. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
875e0d5995 Revert support for DA3Geometry for MoGeRender. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
65e416fa2a Move turbo to colormap.py and add it to DepthAnything3Render. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
554d0d1717 Refactor DepthAnything3 into DepthAnything3Inference and DepthAnything3Render. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
b006d69494 Refactor to a single socket ouptut for DA3 compatible with MoGeRender. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
2d6d0857ef Add DA3ModelType to LoadDepthAnything3. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
96b2b6e30d Improve tooltip for normalization. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
585bcad700 Apply some PR comments. 2026-06-01 16:11:04 +02:00
Talmaj
d132acbb0a Fix DA3 model loader category.
Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>
2026-06-01 16:11:04 +02:00
Talmaj Marinc
00abdae8a8 Fix node loading from geometry_estimation folder. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
2064d190c4 Modify apply_sky_clip default to False. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
37479636cb Fix no clamping when normalization is raw and refactor reusable code to _apply_sky_clip and _depth_to_image 2026-06-01 16:11:04 +02:00
Talmaj Marinc
bc19afd319 Make LoadDepthAnything3 look for models in geometry_estimation. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
c3db905288 Normalize confidence output. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
b5ecef3c47 Improve the toggles text. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
1ac1822c0a Cleanup of comments. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
062750115e Create a unified DepthAnything3 node. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
8ff8b10c45 Remove unused code. 2026-06-01 16:11:04 +02:00
Talmaj Marinc
5568e15afb Update DA3 to use dino2.get_intermediate_layers_da3 2026-06-01 16:11:04 +02:00
Talmaj Marinc
d5217129ef Merge interpolate_pos_encoding method in dinov2 2026-06-01 16:11:04 +02:00
Talmaj Marinc
25ee627556 Fix ray_pose for non float32 dtypes CORE-135 2026-06-01 16:11:04 +02:00
Talmaj Marinc
3c47111bd4 Add support for pose estimation CORE-135. 2026-06-01 16:11:04 +02:00