5452 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Jedrzej Kosinski	ba417750a7	Fix get_all_torch_devices for XPU/NPU and guard remove() ... torch.device(i) defaults to CUDA, so XPU/NPU branches were producing 'cuda:N' devices that don't match get_torch_device() output ('xpu:N'/'npu:N'). This caused devices.remove(get_torch_device()) to raise ValueError when exclude_current=True on non-NVIDIA hardware. Use explicit device strings, and guard the remove() with a membership check for safety. Amp-Thread-ID: https://ampcode.com/threads/T-019e43b8-8258-70fd-ab3a-53e4c97f85d5 Co-authored-by: Amp <amp@ampcode.com>	2026-05-20 16:46:38 -07:00
Jedrzej Kosinski	9a681ccfc9	Guard cached_patcher_init when output_model is False ... load_checkpoint_guess_config_clip_only() calls load_checkpoint_guess_config() with output_model=False, leaving out[0] as None. The subsequent unconditional assignment of cached_patcher_init crashed with AttributeError, breaking CLIP-only checkpoint loading entirely. Guard the assignment with a None check. Amp-Thread-ID: https://ampcode.com/threads/T-019e43b8-8258-70fd-ab3a-53e4c97f85d5 Co-authored-by: Amp <amp@ampcode.com>	2026-05-20 16:46:31 -07:00
Jedrzej Kosinski	50d1dd6273	Fix MultiGPU Options node discarding cloned GPUOptionsGroup ... GPUOptionsGroup.clone() returns a new instance, but the return value was discarded, causing the node to mutate the upstream caller's group in-place. When multiple MultiGPU Options nodes share an input group, each node's additions would leak into earlier siblings. Assign the clone result back to gpu_options so each node owns its own copy. Amp-Thread-ID: https://ampcode.com/threads/T-019e43b8-8258-70fd-ab3a-53e4c97f85d5 Co-authored-by: Amp <amp@ampcode.com>	2026-05-20 16:46:23 -07:00
Jukka Seppänen	4d6a058bf1	feat: MediaPipe face detection (CORE-235) (#14009) ... * Initial mediapipe face detection support * Update face_geometry.py * Account for diff sized batch input * Model folder placeholder	2026-05-20 16:07:48 -07:00
comfyanonymous	a8d2519058	ComfyUI v0.22.0	2026-05-20 13:49:36 -04:00
Daxiong (Lin)	4efe1ddb5c	chore: update workflow templates to v0.9.79 (#14011)	2026-05-20 23:46:20 +08:00
comfyanonymous	f9c84c94b4	Support Stable Audio 3 model. (#14010)	2026-05-20 11:34:22 -04:00
Cezarijus Kivylius	78b5dec6b6	fix: Hunyuan3D 2.1 batch size crashes in attention and forward pass (#13699)	2026-05-20 19:58:49 +08:00
Jedrzej Kosinski	ff766e5cfa	Merge remote-tracking branch 'origin/master' into merge-master-into-worksplit-multigpu ... Amp-Thread-ID: https://ampcode.com/threads/T-019e4352-d45e-75bc-8ed7-ed3a7f6d129a Co-authored-by: Amp <amp@ampcode.com> # Conflicts: # comfy/ldm/sam3/detector.py # comfy/ldm/sam3/tracker.py # comfy/model_base.py # comfy/quant_ops.py # comfy/supported_models.py # comfy_api_nodes/apis/bytedance.py # comfy_api_nodes/nodes_bytedance.py # comfy_api_nodes/nodes_openai.py # comfy_extras/frame_interpolation_models/film_net.py # comfy_extras/frame_interpolation_models/ifnet.py # comfy_extras/nodes_ace.py # comfy_extras/nodes_frame_interpolation.py # comfy_extras/nodes_lt_audio.py # comfy_extras/nodes_sam3.py # comfy_extras/nodes_video_model.py # folder_paths.py # nodes.py # requirements.txt	2026-05-19 21:43:51 -07:00
Jedrzej Kosinski	819c7c0702	Refactor MultiGPU scheduler for readability and termination safety (#14001) ... Behaviour-equivalent cleanup of _calc_cond_batch_multigpu device scheduling. No change to batching decisions or memory checks for any valid input. Changes: * Replace re-summed batched_to_run_length with a per-device load dict (device_load), so capacity checks are O(1) and use a single source of truth. * Extract device selection into next_available_device(), which scans at most len(devices) positions and raises if no device has remaining capacity. This makes the 'skip a full device' rule live in one place instead of two and guarantees the outer while loop cannot spin forever on a scheduling bug. * Drop the unused current_device assignment before the outer loop and the index_device % len(devices) modulo dance (now handled inside next_available_device). * Minor cleanups: list comprehensions for total_conds, conds_to_batch, and the devices list.	2026-05-19 21:23:56 -07:00
comfyanonymous	72e3f6081c	Add downscale ratio to empty ltxv latent. (#13999)	2026-05-19 20:28:06 -07:00
Jedrzej Kosinski	9e3ede1406	Fix MultiGPU scheduler capacity accounting (#14000) ... Fixes _calc_cond_batch_multigpu so that: 1. conds_per_device uses real division before math.ceil. The previous expression math.ceil(total_conds // len(devices)) applied integer floor division first, making ceil a no-op. For 3 conds across 2 devices this produced conds_per_device=1 instead of 2. 2. The scheduling loop skips devices that have already reached capacity instead of appending empty batch groups. Without this guard, the loop could repeatedly emit zero-length groups for a full device, leaving sampling stuck at 0/N until timeout. Reproduces with an Omnigen2 image workflow that produces three condition entries scheduled across two CUDA devices. With the fix the scheduler assigns conds_per_device=2 and splits the batches as 2 + 1 across the two devices, allowing sampling to complete. Original fix authored and validated by @pollockjj in pollockjj/ComfyUI#64. Co-authored-by: John Pollock <pollockjj@gmail.com>	2026-05-19 20:11:53 -07:00
Pauan	7ec7b6ffe9	Adding new StringFormat node (#13997)	2026-05-20 10:25:49 +08:00
Matt Miller	6887165a9d	docs(openapi): tighten workspace API key description field (BE-1004) (#13996) ... Aligns the OSS spec with the cloud-side BE-1004 contract: - createWorkspaceApiKey request body: add maxLength: 5000 to the description property (matches cloud's hub_profile.description MaxLen(5000) convention; enforced cloud-side via handler check). - WorkspaceApiKey + WorkspaceApiKeyCreated response schemas: mark description as required (cloud's handler always populates the field, defaulting to empty string when not supplied on create), drop nullable: true, add maxLength: 5000 for symmetry, and clarify the doc string ("Always present in responses; empty string when no description was supplied on create"). Both schemas are tagged x-runtime: [cloud] at the schema level so the tightening is correctly scoped — OSS-only implementations are not required to honor the workspace API keys endpoints at all. Related cloud PR: Comfy-Org/cloud#3747	2026-05-19 16:55:04 -07:00
Matt Miller	cc4d711eb1	feat(openapi): add optional description field to workspace API key schemas (#13993) ... * feat(openapi): add optional description field to workspace API key schemas Add an optional `description` property (type: string) to three workspace API key schemas in openapi.yaml: - Inline request body of createWorkspaceApiKey (POST /api/workspace/api-keys) - WorkspaceApiKey (list/info schema) - WorkspaceApiKeyCreated (creation response schema) The field is not added to any `required` array, making it fully backward-compatible with existing clients. Refs: BE-1005, BE-1004 Co-authored-by: Matt Miller <mattmillerai@users.noreply.github.com> * fix(openapi): mark description nullable in workspace API key response schemas Per CodeRabbit review on PR #13993: the underlying DB column is nullable varchar (default ''), so the response schemas should permit null to match stored data reality. Without nullable: true the OpenAPI contract would require coercion on the handler side or risk a contract violation. Request schema unchanged — clients shouldn't be sending null on create.	2026-05-19 14:48:47 -07:00
yy	626b082838	Fix typo in ops.py (#11925)	2026-05-20 05:45:04 +08:00
Matt Miller	d0328b442d	docs(openapi): remove top-level width/height fields on Asset schema (#13973) ... These two fields were added recently to the Asset schema as nullable integers, with the intent of exposing original image dimensions for FE consumers (cloud-side thumbnailing makes naturalWidth/Height return the wrong size for an image card's dimension label). The implementation effort that consumes them subsequently converged on a different shape — dimensions nested under the existing free-form `metadata` JSON field as `{kind: "image", width, height}` — to avoid introducing type-specific flat fields on the canonical Asset shape, and to leave room for forward-compatible additions (video duration, fps, etc.) without further schema churn. This removes the now-unused top-level fields so the spec reflects the agreed direction. No other schema definitions reference these fields directly: AssetCreated, AssetUpdated, etc. inherit Asset via allOf and do not redefine them. The runtime ingest implementation that would have populated these fields was not yet shipped, so no clients are relying on the top-level shape. Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>	2026-05-19 10:00:26 -07:00
Matt Miller	6b61918a16	docs(openapi): deprecate /api/upload/mask in favor of /api/upload/image (#13968) ... Mark the uploadMask operation as deprecated and point clients at /api/upload/image. The mask-compositing behavior the endpoint provides (alpha-compositing the supplied mask onto an original_ref image) is now expected to happen client-side, with the composited result uploaded through the unified /api/upload/image path. The endpoint continues to function for older clients; no runtime behavior changes ship with this commit. Only the OpenAPI annotation and the human-facing description are updated.	2026-05-19 12:19:51 +08:00
comfyanonymous	a4382e056e	Use temporal downscale to make empty audio latent nodes more reusable. (#13975)	2026-05-19 00:14:30 -04:00
Alexis Rolland	d71cc1c8f2	chore: Various QoL updates of nodes display names, descriptions and categories (CORE-190, CORE-191) (#13830) ... * Move detection category under image category * Add missing categories * Move detection nodes to detection category * Move save nodes to image root catefory * Rename postprocessors * Move mask category under image * Move guiders category to parent level at root of sampling category * Move custom_sampling category to parent level at the root of sampling category * Modify description of LoRA loaders * Fix node id SolidMask * Move VOID Quadmask under image/mask * Group compositing nodes under image/compositing * Move load image as mask to image category for consistency with other load image nodes * Align display name with Load Checkpoint * Move dataset category under training category * Rename Number Convert to Conver Number (verb first) * Rename Canny node * Revert wanBlockSwap + description * Add description to RemoveBackground node * Revert category update of dataset	2026-05-19 00:13:48 -04:00
comfyanonymous	990a7ae7f2	Initial work to make downscale_ratio_temporal work. (#13972)	2026-05-18 23:01:43 -04:00
Jedrzej Kosinski	df2454b47e	Reduce min for Batch Image/Mask/Latent nodes from 2 to 1 (#13721)	2026-05-19 09:50:14 +08:00
drozbay	292814c31e	feat: Add optional attention_mask input to LTXVAddGuide (CORE-220) (#13965)	2026-05-19 05:07:04 +08:00
Yousef R. Gamaleldin	187e5237e1	Fix BiRefNet issue (#13966)	2026-05-19 05:03:22 +08:00
Alexander Piskun	164a9d4bbb	[Partner Nodes] add ByteDance Seed LLM node (#13919) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-05-18 13:06:13 -07:00
rattus	16f862f02a	implement dynamic clip saving (#13959) ... Fix clip saving by doing the same patching process and diffusion models.	2026-05-18 11:46:40 -07:00
Alvin Tang	d4c6c9eff8	fix(FeatherMask): correct negative zero indexing for right/bottom feathering (#12881)	2026-05-18 20:22:15 +08:00
Alexander Piskun	264b003286	[Partner Nodes] fix Opus 4.7 sending deprecated temperature parameter (#13955)	2026-05-18 09:53:31 +03:00
Jukka Seppänen	971c9e3518	HiDream-O1: support area conditioning (#13944)	2026-05-18 01:17:05 -04:00
Jukka Seppänen	b39af210d0	Fix Qwen3.5 text generation with multiple input images (#13943)	2026-05-18 01:16:42 -04:00
apophis	aeadb7acaa	correct OOM format (#13950)	2026-05-18 12:06:45 +08:00
comfyanonymous	f48d2a017e	Log which quant ops are enabled/emulated. (#13946)	2026-05-17 16:30:54 -04:00
comfyanonymous	7c4d95d1bc	Enhance README with application and cloud links (#13936)	2026-05-16 23:55:43 -04:00
drozbay	d3607a8e6d	feat: Add downscaled IC-LoRA support to LTXVAddGuide (CORE-102) (#13896)	2026-05-16 15:02:57 +08:00
comfyanonymous	5d5a4554e1	Remove useless option and clarify what lowvram does. (#13922)	2026-05-15 17:59:02 -07:00
Jukka Seppänen	33ce449c8b	Reduce LTX2.3 peak VRAM when guide_mask is in use (CORE-166) (#13735) ... - Reduce peak VRAM by handling self_attn_mask more efficiently - Fallback to SDPA when self_attention_mask is used	2026-05-16 00:02:27 +03:00
drozbay	04856acc69	Allow negative batch_index on ImageFromBatch and LatentFromBatch (CORE-195) (#13857)	2026-05-15 22:30:02 +08:00
Jukka Seppänen	77e2ed5e01	feat: Support MoGe (CORE-168) (#13878)	2026-05-15 10:34:56 +08:00
Jukka Seppänen	b2000029c8	Persists ModelNoiseScale when also patching shift (#13892)	2026-05-14 18:36:17 -07:00
Christian Byrne	b112f68681	Generalize frontend version warning to all comfy* requirements.txt entries (#13875)	2026-05-14 16:13:30 -07:00
comfyanonymous	ed78da062c	Create SECURITY.md. (#13902)	2026-05-14 16:02:22 -07:00
comfyanonymous	616cab4f97	Revert "Include workflow_id in all execution WebSocket messages (CORE-198) (#…" (#13901) ... This reverts commit 4f6018982d.	2026-05-14 15:35:42 -07:00
Christian Byrne	4f6018982d	Include workflow_id in all execution WebSocket messages (CORE-198) (#13684)	2026-05-14 15:11:34 -07:00
comfyanonymous	7a063e83a7	Remove annoying message. (#13899)	2026-05-14 12:26:13 -07:00
Robin Huang	3f9bdc70ee	Add careers link to README and startup log (#13897)	2026-05-15 01:32:40 +08:00
Daxiong (Lin)	3d870ff51f	chore: update workflow templates to v0.9.77 (#13895)	2026-05-15 01:25:18 +08:00
Jukka Seppänen	1f28908d6e	Make audio processing nodes handle None -inputs (#13879)	2026-05-14 10:51:35 +08:00
Talmaj	fb51a988b6	Add test that each model has unique identifiers CORE-134 (#13654)	2026-05-14 10:41:25 +08:00
comfyanonymous	26515acd23	ComfyUI v0.21.1	2026-05-13 16:25:01 -04:00
Talmaj	74c17a25e5	Fix void failing with RuntimeError: start (0) + length (464) exceeds dimension size (461). (#13873)	2026-05-13 12:37:30 -07:00