Yousef Rafat
572dff904a
texture generation works
2026-04-03 01:22:38 +02:00
Yousef Rafat
4ee664d99c
..
2026-03-27 20:52:23 +02:00
Yousef Rafat
7ee735fb2b
fixed color addition
2026-03-25 23:51:54 +02:00
Yousef Rafat
88cfccd83d
work on txt gen
2026-03-24 02:44:03 +02:00
Yousef Rafat
89c041002e
shape working
2026-03-20 18:37:11 +02:00
Yousef Rafat
6664ab5c1c
.
2026-03-20 02:36:01 +02:00
Yousef Rafat
a2886f740a
post-process rewrite + light texture model work
2026-03-11 20:11:58 +02:00
Yousef Rafat
06871fbd7d
working version
2026-03-10 22:27:10 +02:00
Yousef Rafat
8fb86f3694
resolution logit
2026-02-27 22:22:07 +02:00
Yousef Rafat
e132e1d0a3
removed unnecessary code + optimizations + progres
2026-02-25 23:54:03 +02:00
Yousef Rafat
977242b2f1
vae shape decode fixes
2026-02-25 04:26:33 +02:00
Yousef Rafat
83d962e9c7
.
2026-02-24 14:53:54 +02:00
Yousef Rafat
f4ea5926a5
progressing
2026-02-23 01:40:56 +02:00
Yousef R. Gamaleldin
bd7a8e9e4f
Merge branch 'master' into trellis2
2026-02-23 00:09:46 +02:00
Yousef Rafat
3fcdac8c7b
bunch of fixes
2026-02-22 23:47:49 +02:00
comfyanonymous
caa43d2395
Fix issue loading fp8 ltxav checkpoints. ( #12582 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-02-22 16:00:02 -05:00
comfyanonymous
07ca6852e8
Fix dtype issue in embeddings connector. ( #12570 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Generate Pydantic Stubs from api.comfy.org / generate-models (push) Has been cancelled
2026-02-22 03:18:20 -05:00
comfyanonymous
f266b8d352
Move LTXAV av embedding connectors to diffusion model. ( #12569 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Build package / Build Test (3.10) (push) Has been cancelled
Build package / Build Test (3.11) (push) Has been cancelled
Build package / Build Test (3.12) (push) Has been cancelled
Build package / Build Test (3.13) (push) Has been cancelled
Build package / Build Test (3.14) (push) Has been cancelled
2026-02-21 22:29:58 -05:00
Yousef Rafat
49d1eab2a5
fixes
2026-02-22 01:25:10 +02:00
rattus
0bfb936ab4
comfy-aimdo 0.2 - Improved pytorch allocator integration ( #12557 )
...
Integrate comfy-aimdo 0.2 which takes a different approach to
installing the memory allocator hook. Instead of using the complicated
and buggy pytorch MemPool+CudaPluggableAlloctor, cuda is directly hooked
making the process much more transparent to both comfy and pytorch. As
far as pytorch knows, aimdo doesnt exist anymore, and just operates
behind the scenes.
Remove all the mempool setup stuff for dynamic_vram and bump the
comfy-aimdo version. Remove the allocator object from memory_management
and demote its use as an enablment check to a boolean flag.
Comfy-aimdo 0.2 also support the pytorch cuda async allocator, so
remove the dynamic_vram based force disablement of cuda_malloc and
just go back to the old settings of allocators based on command line
input.
2026-02-21 10:52:57 -08:00
Terry Jia
f394af8d0f
feat: add gradient-slider display mode for FLOAT inputs ( #12536 )
...
* feat: add gradient-slider display mode for FLOAT inputs
* fix: use precise type annotation list[list[float]] for gradient_stops
Amp-Thread-ID: https://ampcode.com/threads/T-019c7eea-be2b-72ce-a51f-838376f9b7a7
---------
Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>
Co-authored-by: bymyself <cbyrne@comfy.org>
2026-02-20 22:52:32 -08:00
Yousef Rafat
c000fe090f
debugging
2026-02-20 22:04:37 +02:00
Yousef Rafat
167ab754d9
coderabbit 2
2026-02-20 21:13:13 +02:00
Yousef Rafat
acb25b55e8
code rabbit suggestions
2026-02-20 20:16:49 +02:00
Yousef Rafat
8e1230543d
.
2026-02-20 17:39:44 +02:00
comfyanonymous
5f2117528a
Force min length 1 when tokenizing for text generation. ( #12538 )
2026-02-19 22:57:44 -05:00
comfyanonymous
0301ccf745
Small cleanup and try to get qwen 3 work with the text gen. ( #12537 )
2026-02-19 22:42:28 -05:00
Yousef Rafat
578c64f2c4
trellis2conditioning and a hidden bug
2026-02-19 22:05:33 +02:00
Jukka Seppänen
6d11cc7354
feat: Add basic text generation support with native models, initially supporting Gemma3 ( #12392 )
2026-02-18 20:49:43 -05:00
Yousef Rafat
4e401fd353
small fixes
2026-02-19 00:48:26 +02:00
Yousef Rafat
f2d477720c
.
2026-02-18 22:01:09 +02:00
Yousef R. Gamaleldin
5a51bf82de
Merge branch 'master' into trellis2
2026-02-18 21:52:39 +02:00
rattus
58dcc97dcf
ops: limit return of requants ( #12506 )
...
This check was far too broad and the dtype is not a reliable indicator
of wanting the requant (as QT returns the compute dtype as the dtype).
So explictly plumb whether fp8mm wants the requant or not.
2026-02-17 15:32:27 -05:00
chaObserv
44f8598521
Fix anima LLM adapter forward when manual cast ( #12504 )
2026-02-17 07:56:44 -08:00
comfyanonymous
c39653163d
Fix anima preprocess text embeds not using right inference dtype. ( #12501 )
2026-02-17 00:29:20 -05:00
comfyanonymous
18927538a1
Implement NAG on all the models based on the Flux code. ( #12500 )
...
Use the Normalized Attention Guidance node.
Flux, Flux2, Klein, Chroma, Chroma radiance, Hunyuan Video, etc..
2026-02-16 23:30:34 -05:00
comfyanonymous
4454fab7f0
Remove code to support RMSNorm on old pytorch. ( #12499 )
2026-02-16 20:09:24 -05:00
Yousef Rafat
b7de0ad87e
postprocessing node fixes + model small fixes
2026-02-17 00:10:48 +02:00
comfyanonymous
88e6370527
Remove workaround for old pytorch. ( #12480 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-02-15 20:43:53 -05:00
rattus
c0370044cd
MPDynamic: force load flux img_in weight (Fixes flux1 canny+depth lora crash) ( #12446 )
...
* lora: add weight shape calculations.
This lets the loader know if a lora will change the shape of a weight
so it can take appropriate action.
* MPDynamic: force load flux img_in weight
This weight is a bit special, in that the lora changes its geometry.
This is rather unique, not handled by existing estimate and doesn't
work for either offloading or dynamic_vram.
Fix for dynamic_vram as a special case. Ideally we can fully precalculate
these lora geometry changes at load time, but just get these models
working first.
2026-02-15 20:30:09 -05:00
Yousef Rafat
ee24b93abc
rewriting conditioning logic + model code addition
2026-02-16 01:53:53 +02:00
comfyanonymous
e1ede29d82
Remove unsafe pickle loading code that was used on pytorch older than 2.4 ( #12473 )
...
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Generate Pydantic Stubs from api.comfy.org / generate-models (push) Has been cancelled
ComfyUI hasn't started on pytorch 2.4 since last month.
2026-02-14 22:53:52 -05:00
krigeta
dc9822b7df
Add working Qwen 2512 ControlNet (Fun ControlNet) support ( #12359 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-02-13 22:23:52 -05:00
comfyanonymous
712efb466b
Add left padding to LTXAV text encoder. ( #12456 )
2026-02-13 21:56:54 -05:00
comfyanonymous
726af73867
Fix some custom nodes. ( #12455 )
2026-02-13 20:21:10 -05:00
comfyanonymous
831351a29e
Support generating attention masks for left padded text encoders. ( #12454 )
2026-02-13 20:15:23 -05:00
comfyanonymous
e1add563f9
Use torch RMSNorm for flux models and refactor hunyuan video code. ( #12432 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-02-13 15:35:13 -05:00
rattus
8902907d7a
dynamic_vram: Training fixes ( #12442 )
2026-02-13 15:29:37 -05:00
Yousef Rafat
6023feca0e
.
2026-02-13 21:05:59 +02:00
rattus
ae79e33345
llama: use a more efficient rope implementation ( #12434 )
...
Get rid of the cat and unary negation and inplace add-cmul the two
halves of the rope. Precompute -sin once at the start of the model
rather than every transformer block.
This is slightly faster on both GPU and CPU bound setups.
2026-02-12 19:56:42 -05:00
