comfyanonymous
d3504e1778
Enable pytorch attention by default for gfx1201 on torch 2.8 ( #9029 )
2025-07-23 19:21:29 -04:00
comfyanonymous
a86a58c308
Fix xpu function not implemented p2. ( #9027 )
2025-07-23 18:18:20 -04:00
comfyanonymous
39dda1d40d
Fix xpu function not implemented. ( #9026 )
2025-07-23 18:10:59 -04:00
comfyanonymous
5ad33787de
Add default device argument. ( #9023 )
2025-07-23 14:20:49 -04:00
Simon Lui
255f139863
Add xpu version for async offload and some other things. ( #9004 )
2025-07-22 15:20:09 -04:00
Jedrzej Kosinski
3c4104652b
Merge branch 'master' into worksplit-multigpu-wip
2025-07-22 11:42:23 -07:00
comfyanonymous
491fafbd64
Silence clip tokenizer warning. ( #8934 )
2025-07-16 14:42:07 -04:00
Harel Cain
9bc2798f72
LTXV VAE decoder: switch default padding mode ( #8930 )
2025-07-16 13:54:38 -04:00
comfyanonymous
50afba747c
Add attempt to work around the safetensors mmap issue. ( #8928 )
2025-07-16 03:42:17 -04:00
Yoland Yan
543c24108c
Fix wrong reference bug ( #8910 )
2025-07-14 20:45:55 -04:00
comfyanonymous
b40143984c
Add model detection error hint for lora. ( #8880 )
2025-07-12 03:49:26 -04:00
comfyanonymous
938d3e8216
Remove windows line endings. ( #8866 )
2025-07-11 02:37:51 -04:00
guill
2b653e8c18
Support for async node functions ( #8830 )
...
* Support for async execution functions
This commit adds support for node execution functions defined as async. When
a node's execution function is defined as async, we can continue
executing other nodes while it is processing.
Standard uses of `await` should "just work", but people will still have
to be careful if they spawn actual threads. Because torch doesn't really
have async/await versions of functions, this won't particularly help
with most locally-executing nodes, but it does work for e.g. web
requests to other machines.
In addition to the execute function, the `VALIDATE_INPUTS` and
`check_lazy_status` functions can also be defined as async, though we'll
only resolve one node at a time right now for those.
* Add the execution model tests to CI
* Add a missing file
It looks like this got caught by .gitignore? There's probably a better
place to put it, but I'm not sure what that is.
* Add the websocket library for automated tests
* Add additional tests for async error cases
Also fixes one bug that was found when an async function throws an error
after being scheduled on a task.
* Add a feature flags message to reduce bandwidth
We now only send 1 preview message of the latest type the client can
support.
We'll add a console warning when the client fails to send a feature
flags message at some point in the future.
* Add async tests to CI
* Don't actually add new tests in this PR
Will do it in a separate PR
* Resolve unit test in GPU-less runner
* Just remove the tests that GHA can't handle
* Change line endings to UNIX-style
* Avoid loading model_management.py so early
Because model_management.py has a top-level `logging.info`, we have to
be careful not to import that file before we call `setup_logging`. If we
do, we end up having the default logging handler registered in addition
to our custom one.
2025-07-10 14:46:19 -04:00
kosinkadink1@gmail.com
9855baaab3
Merge branch 'master' into worksplit-multigpu
2025-07-09 03:57:30 -05:00
chaObserv
aac10ad23a
Add SA-Solver sampler ( #8834 )
2025-07-08 16:17:06 -04:00
josephrocca
974254218a
Un-hardcode chroma patch_size ( #8840 )
2025-07-08 15:56:59 -04:00
comfyanonymous
75d327abd5
Remove some useless code. ( #8812 )
2025-07-06 07:07:39 -04:00
comfyanonymous
ee615ac269
Add warning when loading file unsafely. ( #8800 )
2025-07-05 14:34:57 -04:00
chaObserv
f41f323c52
Add the denoising step to several samplers ( #8780 )
2025-07-03 19:20:53 -04:00
City
d9277301d2
Initial code for new SLG node ( #8759 )
2025-07-02 20:13:43 -04:00
comfyanonymous
111f583e00
Fallback to regular op when fp8 op throws exception. ( #8761 )
2025-07-02 00:57:13 -04:00
Jedrzej Kosinski
d53479a197
Merge branch 'master' into worksplit-multigpu
2025-07-01 17:33:05 -05:00
chaObserv
b22e97dcfa
Migrate ER-SDE from VE to VP algorithm and add its sampler node ( #8744 )
...
Apply alpha scaling in the algorithm for reverse-time SDE and add custom ER-SDE sampler node for other solver types (SDE, ODE).
2025-07-01 02:38:52 -04:00
comfyanonymous
170c7bb90c
Fix contiguous issue with pytorch nightly. ( #8729 )
2025-06-29 06:38:40 -04:00
comfyanonymous
396454fa41
Reorder the schedulers so simple is the default one. ( #8722 )
2025-06-28 18:12:56 -04:00
xufeng
ba9548f756
“--whitelist-custom-nodes” args for comfy core to go with “--disable-all-custom-nodes” for development purposes ( #8592 )
...
* feat: “--whitelist-custom-nodes” args for comfy core to go with “--disable-all-custom-nodes” for development purposes
* feat: Simplify custom nodes whitelist logic to use consistent code paths
2025-06-28 15:24:02 -04:00
comfyanonymous
c36be0ea09
Fix memory estimation bug with kontext. ( #8709 )
2025-06-27 17:21:12 -04:00
comfyanonymous
9093301a49
Don't add tiny bit of random noise when VAE encoding. ( #8705 )
...
Shouldn't change outputs but might make things a tiny bit more
deterministic.
2025-06-27 14:14:56 -04:00
comfyanonymous
ef5266b1c1
Support Flux Kontext Dev model. ( #8679 )
2025-06-26 11:28:41 -04:00
comfyanonymous
a96e65df18
Disable omnigen2 fp16 on older pytorch versions. ( #8672 )
2025-06-26 03:39:09 -04:00
comfyanonymous
ec70ed6aea
Omnigen2 model implementation. ( #8669 )
2025-06-25 19:35:57 -04:00
comfyanonymous
7a13f74220
unet -> diffusion model ( #8659 )
2025-06-25 04:52:34 -04:00
chaObserv
8042eb20c6
Singlestep DPM++ SDE for RF ( #8627 )
...
Refactor the algorithm, and apply alpha scaling.
2025-06-24 14:59:09 -04:00
Jedrzej Kosinski
443a795850
Merge branch 'master' into worksplit-multigpu
2025-06-24 00:49:24 -05:00
Jedrzej Kosinski
431dec8e53
Merge branch 'worksplit-multigpu' of https://github.com/comfyanonymous/ComfyUI into worksplit-multigpu
2025-06-24 00:48:58 -05:00
Jedrzej Kosinski
44e053c26d
Improve error handling for multigpu threads
2025-06-24 00:48:51 -05:00
comfyanonymous
1883e70b43
Fix exception when using a noise mask with cosmos predict2. ( #8621 )
...
* Fix exception when using a noise mask with cosmos predict2.
* Fix ruff.
2025-06-21 03:30:39 -04:00
comfyanonymous
f7fb193712
Small flux optimization. ( #8611 )
2025-06-20 05:37:32 -04:00
comfyanonymous
7e9267fa77
Make flux controlnet work with sd3 text enc. ( #8599 )
2025-06-19 18:50:05 -04:00
comfyanonymous
91d40086db
Fix pytorch warning. ( #8593 )
2025-06-19 11:04:52 -04:00
Jedrzej Kosinski
1ae98932f1
Merge branch 'master' into worksplit-multigpu
2025-06-17 04:58:56 -05:00
chaObserv
8e81c507d2
Multistep DPM++ SDE samplers for RF ( #8541 )
...
Include alpha in sampling and minor refactoring
2025-06-16 14:47:10 -04:00
comfyanonymous
e1c6dc720e
Allow setting min_length with tokenizer_data. ( #8547 )
2025-06-16 13:43:52 -04:00
comfyanonymous
7ea79ebb9d
Add correct eps to ltxv rmsnorm. ( #8542 )
2025-06-15 12:21:25 -04:00
comfyanonymous
d6a2137fc3
Support Cosmos predict2 image to video models. ( #8535 )
...
Use the CosmosPredict2ImageToVideoLatent node.
2025-06-14 21:37:07 -04:00
chaObserv
53e8d8193c
Generalize SEEDS samplers ( #8529 )
...
Restore VP algorithm for RF and refactor noise_coeffs and half-logSNR calculations
2025-06-14 16:58:16 -04:00
comfyanonymous
29596bd53f
Small cosmos attention code refactor. ( #8530 )
2025-06-14 05:02:05 -04:00
Kohaku-Blueleaf
520eb77b72
LoRA Trainer: LoRA training node in weight adapter scheme ( #8446 )
2025-06-13 19:25:59 -04:00
comfyanonymous
c69af655aa
Uncap cosmos predict2 res and fix mem estimation. ( #8518 )
2025-06-13 07:30:18 -04:00
comfyanonymous
251f54a2ad
Basic initial support for cosmos predict2 text to image 2B and 14B models. ( #8517 )
2025-06-13 07:05:23 -04:00
pythongosssss
50c605e957
Add support for sqlite database ( #8444 )
...
* Add support for sqlite database
* fix
2025-06-11 16:43:39 -04:00
comfyanonymous
8a4ff747bd
Fix mistake in last commit. ( #8496 )
...
* Move to right place.
2025-06-11 15:13:29 -04:00
comfyanonymous
af1eb58be8
Fix black images on some flux models in fp16. ( #8495 )
2025-06-11 15:09:11 -04:00
comfyanonymous
6e28a46454
Apple most likely is never fixing the fp16 attention bug. ( #8485 )
2025-06-10 13:06:24 -04:00
comfyanonymous
7f800d04fa
Enable AMD fp8 and pytorch attention on some GPUs. ( #8474 )
...
Information is from the pytorch source code.
2025-06-09 12:50:39 -04:00
comfyanonymous
97755eed46
Enable fp8 ops by default on gfx1201 ( #8464 )
2025-06-08 14:15:34 -04:00
comfyanonymous
daf9d25ee2
Cleaner torch version comparisons. ( #8453 )
2025-06-07 10:01:15 -04:00
comfyanonymous
3b4b171e18
Alternate fix for #8435 ( #8442 )
2025-06-06 09:43:27 -04:00
comfyanonymous
4248b1618f
Let chroma TE work on regular flux. ( #8429 )
2025-06-05 10:07:17 -04:00
comfyanonymous
fb4754624d
Make the casting in lists the same as regular inputs. ( #8373 )
2025-06-01 05:39:54 -04:00
kosinkadink1@gmail.com
0336b0ace8
Merge branch 'master' into worksplit-multigpu
2025-06-01 02:39:26 -07:00
comfyanonymous
19e45e9b0e
Make it easier to pass lists of tensors to models. ( #8358 )
2025-05-31 20:00:20 -04:00
drhead
08b7cc7506
use fused multiply-add pointwise ops in chroma ( #8279 )
2025-05-30 18:09:54 -04:00
comfyanonymous
704fc78854
Put ROCm version in tuple to make it easier to enable stuff based on it. ( #8348 )
2025-05-30 15:41:02 -04:00
comfyanonymous
f2289a1f59
Delete useless file. ( #8327 )
2025-05-29 08:29:37 -04:00
comfyanonymous
5e5e46d40c
Not really tested WAN Phantom Support. ( #8321 )
2025-05-28 23:46:15 -04:00
comfyanonymous
1c1687ab1c
Support HiDream SimpleTuner loras. ( #8318 )
2025-05-28 18:47:15 -04:00
comfyanonymous
06c661004e
Memory estimation code can now take into account conds. ( #8307 )
2025-05-27 15:09:05 -04:00
comfyanonymous
89a84e32d2
Disable initial GPU load when novram is used. ( #8294 )
2025-05-26 16:39:27 -04:00
comfyanonymous
e5799c4899
Enable pytorch attention by default on AMD gfx1151 ( #8282 )
2025-05-26 04:29:25 -04:00
comfyanonymous
a0651359d7
Return proper error if diffusion model not detected properly. ( #8272 )
2025-05-25 05:28:11 -04:00
comfyanonymous
5a87757ef9
Better error if sageattention is installed but a dependency is missing. ( #8264 )
2025-05-24 06:43:12 -04:00
comfyanonymous
0b50d4c0db
Add argument to explicitly enable fp8 compute support. ( #8257 )
...
This can be used to test if your current GPU/pytorch version supports fp8 matrix mult in combination with --fast or the fp8_e4m3fn_fast dtype.
2025-05-23 17:43:50 -04:00
drhead
30b2eb8a93
create arange on-device ( #8255 )
2025-05-23 16:15:06 -04:00
comfyanonymous
f85c08df06
Make VACE conditionings stackable. ( #8240 )
2025-05-22 19:22:26 -04:00
kosinkadink1@gmail.com
8ae25235ec
Merge branch 'master' into worksplit-multigpu
2025-05-21 12:01:27 -07:00
comfyanonymous
87f9130778
Revert "This doesn't seem to be needed on chroma. ( #8209 )" ( #8210 )
...
This reverts commit 7e84bf5373
2025-05-20 05:39:55 -04:00
comfyanonymous
7e84bf5373
This doesn't seem to be needed on chroma. ( #8209 )
2025-05-20 05:29:23 -04:00
comfyanonymous
aee2908d03
Remove useless log. ( #8166 )
2025-05-17 06:27:34 -04:00
comfyanonymous
1c2d45d2b5
Fix typo in last PR. ( #8144 )
...
More robust model detection for future proofing.
2025-05-15 19:02:19 -04:00
George0726
c820ef950d
Add Wan-FUN Camera Control models and Add WanCameraImageToVideo node ( #8013 )
...
* support wan camera models
* fix by ruff check
* change camera_condition type; make camera_condition optional
* support camera trajectory nodes
* fix camera direction
---------
Co-authored-by: Qirui Sun <sunqr0667@126.com>
2025-05-15 19:00:43 -04:00
Christian Byrne
98ff01e148
Display progress and result URL directly on API nodes ( #8102 )
...
* [Luma] Print download URL of successful task result directly on nodes (#177 )
[Veo] Print download URL of successful task result directly on nodes (#184 )
[Recraft] Print download URL of successful task result directly on nodes (#183 )
[Pixverse] Print download URL of successful task result directly on nodes (#182 )
[Kling] Print download URL of successful task result directly on nodes (#181 )
[MiniMax] Print progress text and download URL of successful task result directly on nodes (#179 )
[Docs] Link to docs in `API_NODE` class property type annotation comment (#178 )
[Ideogram] Print download URL of successful task result directly on nodes (#176 )
[Kling] Print download URL of successful task result directly on nodes (#181 )
[Veo] Print download URL of successful task result directly on nodes (#184 )
[Recraft] Print download URL of successful task result directly on nodes (#183 )
[Pixverse] Print download URL of successful task result directly on nodes (#182 )
[MiniMax] Print progress text and download URL of successful task result directly on nodes (#179 )
[Docs] Link to docs in `API_NODE` class property type annotation comment (#178 )
[Luma] Print download URL of successful task result directly on nodes (#177 )
[Ideogram] Print download URL of successful task result directly on nodes (#176 )
Show output URL and progress text on Pika nodes (#168 )
[BFL] Print download URL of successful task result directly on nodes (#175 )
[OpenAI ] Print download URL of successful task result directly on nodes (#174 )
* fix ruff errors
* fix 3.10 syntax error
2025-05-14 00:33:18 -04:00
comfyanonymous
4a9014e201
Hunyuan Custom initial untested implementation. ( #8101 )
2025-05-13 15:53:47 -04:00
comfyanonymous
a814f2e8cc
Fix issue with old pytorch RMSNorm. ( #8095 )
2025-05-13 07:54:28 -04:00
comfyanonymous
481732a0ed
Support official ACE Step loras. ( #8094 )
2025-05-13 07:32:16 -04:00
Jedrzej Kosinski
9726eac475
Merge branch 'master' into worksplit-multigpu
2025-05-12 19:29:13 -05:00
comfyanonymous
640c47e7de
Fix torch warning about deprecated function. ( #8075 )
...
Drop support for torch versions below 2.2 on the audio VAEs.
2025-05-12 14:32:01 -04:00
comfyanonymous
577de83ca9
ACE VAE works in fp16. ( #8055 )
2025-05-11 04:58:00 -04:00
comfyanonymous
d42613686f
Fix issue with fp8 ops on some models. ( #8045 )
...
_scaled_mm errors when an input is non contiguous.
2025-05-10 07:52:56 -04:00
Pam
1b3bf0a5da
Fix res_multistep_ancestral sampler ( #8030 )
2025-05-09 20:14:13 -04:00
blepping
42da274717
Use normal ComfyUI attention in ACE-Steps model ( #8023 )
...
* Use normal ComfyUI attention in ACE-Steps model
* Let optimized_attention handle output reshape for ACE
2025-05-09 13:51:02 -04:00
comfyanonymous
8ab15c863c
Add --mmap-torch-files to enable use of mmap when loading ckpt/pt ( #8021 )
2025-05-09 04:52:47 -04:00
comfyanonymous
a692c3cca4
Make ACE VAE tiling work. ( #8004 )
2025-05-08 07:25:45 -04:00
comfyanonymous
5d3cc85e13
Make japanese hiragana and katakana characters work with ACE. ( #7997 )
2025-05-08 03:32:36 -04:00
comfyanonymous
c7c025b8d1
Adjust memory estimation code for ACE VAE. ( #7990 )
2025-05-08 01:22:23 -04:00
comfyanonymous
fd08e39588
Make torchaudio not a hard requirement. ( #7987 )
...
Some platforms can't install it apparently so if it's not there it should
only break models that actually use it.
2025-05-07 21:37:12 -04:00
comfyanonymous
56b6ee6754
Detection code to make ltxv models without config work. ( #7986 )
2025-05-07 21:28:24 -04:00
comfyanonymous
cc33cd3422
Experimental lyrics strength for ACE. ( #7984 )
2025-05-07 19:22:07 -04:00
comfyanonymous
16417b40d9
Initial ACE-Step model implementation. ( #7972 )
2025-05-07 08:33:34 -04:00
comfyanonymous
271c9c5b9e
Better mem estimation for the LTXV 13B model. ( #7963 )
2025-05-06 09:52:37 -04:00
