Commit Graph

72 Commits

Author SHA1 Message Date
Yousef R. Gamaleldin
b5a6c8a1ca Update comfy_extras/nodes_trellis2.py
Co-authored-by: Alexis Rolland <alexis@comfy.org>
2026-05-14 14:52:35 +03:00
Yousef Rafat
edc04765dd optimizing the simplify fn 2026-05-12 20:40:10 +03:00
Yousef Rafat
25209d1b36 removing seeds from node display 2026-05-08 19:03:06 +03:00
Yousef Rafat
e4cf496844 update the simplify function 2026-05-08 15:13:07 +03:00
Yousef Rafat
068c1c23fb removed test files 2026-04-24 01:30:31 +03:00
John Pollock
e8402d94b4 Address Trellis VAE decode review feedback 2026-04-20 22:10:15 -05:00
John Pollock
7e9ee82351 Merge remote-tracking branch 'origin/issue_73' into issue_80
# Conflicts:
#	comfy_extras/nodes_trellis2.py
2026-04-20 22:04:24 -05:00
John Pollock
3546836091 Fix Trellis VAE decode memory management 2026-04-20 20:39:08 -05:00
John Pollock
da6f3b630f Merge pull request #13 from pollockjj/issue_94
Trellis2: make textured mesh simplification deterministic
2026-04-20 17:57:01 -07:00
John Pollock
de7a811cdd fix: stabilize Trellis2 mesh simplification 2026-04-20 17:22:31 -05:00
John Pollock
0f530ce540 Omit null batch_index from Trellis upsample output 2026-04-20 17:20:57 -05:00
John Pollock
149af779ed Harden Trellis sparse latent seeding 2026-04-20 16:05:10 -05:00
John Pollock
081e7126bd Fail loud on Trellis invalid batch metadata 2026-04-20 15:50:40 -05:00
John Pollock
f309cc1889 Harden Trellis sparse metadata validation 2026-04-20 14:46:23 -05:00
John Pollock
e95be49e69 Fix Trellis seeded sparse batch semantics 2026-04-20 14:29:07 -05:00
John Pollock
032943a065 Fix Trellis PR review regressions 2026-04-20 12:15:49 -05:00
John Pollock
eaf7d708b0 Fix Trellis2 batched shape and texture semantics 2026-04-20 11:06:04 -05:00
John Pollock
e2bbcece02 Trellis2: inline batched mesh helpers 2026-04-19 23:47:57 -05:00
John Pollock
6e45580707 Trellis2: share batched mesh helpers 2026-04-19 23:33:09 -05:00
John Pollock
849a75c4dc Trellis2: handle empty and batched texture paint paths 2026-04-19 23:23:24 -05:00
John Pollock
353f3d9164 Trellis2/Hunyuan3d: preserve mesh tensor contract in batch mode 2026-04-19 22:55:38 -05:00
John Pollock
eb3ac5ffe4 Trellis2/Hunyuan3d: n>1 batched cascade support
Mesh-producing nodes (VoxelToMeshBasic, VoxelToMesh, VaeDecodeShapeTrellis)
previously stacked per-batch vertex/face tensors with torch.stack, which
failed under batch>1 because per-item meshes have variable shapes. Store
per-item tensors as lists when shapes differ; keep stacked-tensor fast
path when shapes match. Update SaveGLB, PostProcessMesh, and
VaeDecodeTextureTrellis consumers to iterate per-item when input is a
list.

Trellis2Conditioning.execute previously collapsed batched image/mask
input to index 0, yielding identical conditioning for every batch item.
Loop over the batch and produce per-image cond_512/cond_1024/neg_cond
tensors stacked along the batch dim, matching the latent batch size.

batch_size=1 behavior is unchanged. batch_size>1 runs now emit one GLB
per batch item per SaveGLB node and carry per-image conditioning
through the structure/shape/texture cascade.
2026-04-19 22:03:53 -05:00
John Pollock
78d4f27ec0 Match Copilot image_size restore pattern 2026-04-19 21:05:07 -05:00
John Pollock
e91a4659d5 Handle missing Trellis2 image_size restore state 2026-04-19 20:51:22 -05:00
John Pollock
1c91682604 Guard full Trellis2 conditioning image_size restore 2026-04-19 20:49:42 -05:00
John Pollock
718be91a15 Restore Trellis2 clip vision image_size state 2026-04-19 19:53:30 -05:00
Yousef Rafat
576befbb4b small final change 2026-04-12 20:14:47 +02:00
Yousef Rafat
293a597fdc texture fixes 2026-04-10 19:18:14 +02:00
Yousef Rafat
5cacceaad3 corrected simplification logic 2026-04-10 16:33:19 +02:00
Yousef Rafat
aab8ab6638 comfy ops + color support in postprocess 2026-04-10 16:12:23 +02:00
Yousef Rafat
986b8201da structure generation works 2026-04-10 14:24:07 +02:00
Yousef Rafat
a7117da8de fix for conditioning 2026-04-07 23:02:33 +02:00
Yousef Rafat
572dff904a texture generation works 2026-04-03 01:22:38 +02:00
Yousef Rafat
f5161f215c wrong normalization for the texture node 2026-03-30 23:20:46 +02:00
Yousef Rafat
4ee664d99c .. 2026-03-27 20:52:23 +02:00
Yousef Rafat
7ee735fb2b fixed color addition 2026-03-25 23:51:54 +02:00
Yousef Rafat
9986f6d29e pytorch -> scipy 2026-03-25 17:03:52 +02:00
Yousef Rafat
03d42e10cd add color support for save mesh 2026-03-25 02:40:15 +02:00
Yousef Rafat
88cfccd83d work on txt gen 2026-03-24 02:44:03 +02:00
Yousef Rafat
89c041002e shape working 2026-03-20 18:37:11 +02:00
Yousef Rafat
6664ab5c1c . 2026-03-20 02:36:01 +02:00
Yousef Rafat
144488f868 upscale node + simple node simplification 2026-03-11 22:50:17 +02:00
Yousef Rafat
a2886f740a post-process rewrite + light texture model work 2026-03-11 20:11:58 +02:00
Yousef Rafat
06871fbd7d working version 2026-03-10 22:27:10 +02:00
Yousef Rafat
8fb86f3694 resolution logit 2026-02-27 22:22:07 +02:00
Yousef Rafat
e132e1d0a3 removed unnecessary code + optimizations + progres 2026-02-25 23:54:03 +02:00
Yousef Rafat
977242b2f1 vae shape decode fixes 2026-02-25 04:26:33 +02:00
Yousef Rafat
83d962e9c7 . 2026-02-24 14:53:54 +02:00
Yousef Rafat
f4ea5926a5 progressing 2026-02-23 01:40:56 +02:00
Yousef Rafat
3fcdac8c7b bunch of fixes 2026-02-22 23:47:49 +02:00