sam-kpm
e24d0f0ad1
Refactor EGL device enumeration and fix eglGetDisplay fallback
...
- Extract device enumeration into _egl_device_display() helper
- Use ctypes.util.find_library("EGL") instead of hardcoded libEGL.so.1
- Fix eglGetDisplay(EGL_DEFAULT_DISPLAY) failure also falling through to
device enumeration (previously raised immediately, skipping the fallback)
- Two-pass eglQueryDevicesEXT to avoid arbitrary device count cap
2026-04-08 18:52:17 -06:00
sam-kpm
8e0558c4a4
Fix EGL context creation on headless NVIDIA (EGL_BAD_ACCESS)
...
On headless Linux with NVIDIA GPUs and no display server, eglInitialize()
with EGL_DEFAULT_DISPLAY fails with EGL_BAD_ACCESS. The fix falls back to
EGL_EXT_platform_device: enumerate EGL devices and obtain a display via
eglGetPlatformDisplayEXT(EGL_PLATFORM_DEVICE_EXT, ...).
PyOpenGL's egl_get_devices() wrapper doesn't reliably resolve the
eglQueryDevicesEXT function pointer in this scenario, so both functions
are called directly from libEGL.so.1 via ctypes.
Also handles the case where eglInitialize raises EGLError rather than
returning False, which varies by PyOpenGL version and EGL vendor.
2026-04-08 18:45:58 -06:00
Terry Jia
3696c5bad6
Add has_intermediate_output flag for nodes with interactive UI ( #13048 )
2026-03-27 21:06:38 -04:00
Terry Jia
1dc64f3526
feat: add curve inputs and raise uniform limit for GLSL shader node ( #13158 )
...
* feat: add curve inputs and raise uniform limit for GLSL shader node
* allow arbitrary size for curve
2026-03-26 21:45:05 -04:00
pythongosssss
0a7f8e11b6
fix torch.cat requiring inputs to all be same dimensions ( #12673 )
2026-02-27 08:13:24 -08:00
pythongosssss
38ca94599f
pyopengl-accelerate can cause object to be numpy ints instead of bare ints, which the glDeleteTextures function does not accept, explicitly cast to int ( #12650 )
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-02-26 03:07:35 -08:00
pythongosssss
602b2505a4
add support for pyopengl < 3.1.4 where the size parameter does not exist ( #12555 )
2026-02-21 06:14:57 -08:00
pythongosssss
96d6bd1a4a
Add GLSL shader node using PyOpenGL ( #12148 )
...
* adds support for executing simple glsl shaders
using moderngl package
* tidy
* Support multiple outputs
* Try fix build
* fix casing
* fix line endings
* convert to using PyOpenGL and glfw
* remove cpu support
* tidy
* add additional support for egl & osmesa backends
* fix ci
perf: only read required outputs
* add diagnostics, update mac initialization
* GLSL glueprints + node fixes (#12492 )
* Add image operation blueprints
* Add channels
* Add glow
* brightness/contrast
* hsb
* add glsl shader update system
* shader nit iteration
* add multipass for faster blur
* more fixes
* rebuild blueprints
* print -> logger
* Add edge preserving blur
* fix: move _initialized flag to end of GLContext.__init__
Prevents '_vao' attribute error when init fails partway through
and subsequent calls skip initialization due to early _initialized flag.
* update valid ranges
- threshold 0-100
- step 0+
* fix value ranges
* rebuild node to remove extra inputs
* Fix gamma step
* clamp saturation in colorize instead of wrapping
* Fix crash on 1x1 px images
* rework description
* remove unnecessary f
Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>
Co-authored-by: Hunter Senft-Grupp <hunter@comfy.org>
2026-02-19 23:22:13 -05:00