16 Commits

Author	SHA1	Message	Date
Kohaku-Blueleaf	ee4ee09a64	Merge branch 'master' into video-dataset-nodes	2026-06-23 09:07:32 +08:00
Matt Miller	94ee49b161	harden: load training-dataset shards with weights_only=True (#14543) ... LoadTrainingDataset was the only torch.load call in the codebase without weights_only=True; comfy/utils.py and comfy/sd1_clip.py already pass it. Recent PyTorch defaults to weights_only=True, so this is defense-in-depth for installs pinned to older PyTorch. Verified a typical shard (latents + standard conditioning) round-trips cleanly under weights_only=True.	2026-06-18 15:30:57 -04:00
Kohaku-Blueleaf	133a872cc8	style(video nodes): align naming/category with image nodes (PR #13588 review) ... Apply the same naming convention the image nodes adopted, per @alexisrolland's review on PR #13588: - Load Video (from Folder), Load Video-Text (from Folder): category "video", add search_aliases + description. - Sample Video Frame (was "Video Frame Sample"): category "video". - Crop Video (Temporal) / Crop Video (Temporal Random): category "video/transform", verb-first names, search_aliases + description. - Shuffle Videos List (was "Shuffle Video Dataset"): category "video/batch". - Shuffle Pairs of Video-Text: category "dataset/video". All video schemas now carry search_aliases and description to match the image-node conventions. Resolved review threads on PR #13588. Two comments were outdated and intentionally skipped: - CodeRabbit container-leak on load_video_frames(): the function was replaced by _decode_selected_frames() using `with av.open(...)`. - "category=cls.category" on ShuffleVideoDataset: the node is no longer an ImageProcessingNode subclass, so category is set directly.	2026-06-09 13:17:07 +08:00
Kohaku-Blueleaf	8960366a8b	Merge branch 'master' into video-dataset-nodes ... Brings the master-side refactor of the dataset nodes into the video branch. Conflicts were all in comfy_extras/nodes_dataset.py and resolved to keep both sides' intent: - ImageProcessingNode base class: kept master's _ensure_image_list group normalization AND the branch's per-frame video loop (per_frame_process) for individual _process nodes, so spatial transforms still auto-apply per video frame while group nodes use the new list handling. - AdjustBrightness / AdjustContrast: kept master's category ("image/adjustments") and descriptions plus the branch's per_frame_process = False (pure tensor math runs on the whole batch). - save_images_to_folder: took master's signature with the new overwrite/increment support; kept the branch's video loader nodes that were inserted just above it. nodes_train.py auto-merged: branch's generic repeat(num_images, *[1]*(ndim-1)) (needed for 5D video latents) is preserved while master's category renames (model/training, model/loaders) are applied.	2026-06-09 13:17:07 +08:00
Kohaku-Blueleaf	c7d29a42ba	refactor(video dataset): lazy video loading and frame-selective decode ... - Replace eager load_video_frames() with _decode_selected_frames() that opens the container with `with av.open(...)` (no resource leak) and decodes only the requested frame indices. - Video loader nodes now emit lazy VideoFromFile references; sampling and temporal-crop nodes operate lazily / decode only selected frames.	2026-06-09 13:17:06 +08:00
Yousef R. Gamaleldin	7758b9b321	fix: Image grid bug fix (CORE-215) (#14100)	2026-06-03 16:03:32 -07:00
Charles Chan	6ceec29bd1	feat: add overwrite/increment to SaveImageTextDataSetToFolderNode (#13215)	2026-05-28 10:12:04 -07:00
Alexis Rolland	174208df6b	chore: Update nodes categories (#14145) ... * Move dataset/text nodes to text category * Rename category utils into utilities * Rename category api node into partner * Move categories conditioning, latent, sampling, model_patches, training, etc. under model category * Dispatch partner nodes in to 3d, audio, image, text, video categories * Move PreviewAny node to utilities category	2026-05-27 20:43:33 -04:00
Alexis Rolland	af3d9b60af	chore: Dataset nodes clean-up (CORE-237) (#14002)	2026-05-21 15:14:16 +08:00
Kohaku-Blueleaf	d364d3f8b5	Init implementation of video dataset nodes	2026-04-14 14:39:56 +08:00
Christian Byrne	4d172e9ad7	feat: mark 429 widgets as advanced for collapsible UI (#12197) ... * feat: mark 429 widgets as advanced for collapsible UI Mark widgets as advanced across core, comfy_extras, and comfy_api_nodes to support the new collapsible advanced inputs section in the frontend. Changes: - 267 advanced markers in comfy_extras/ - 162 advanced markers in comfy_api_nodes/ - All files pass python3 -m py_compile verification Widgets marked advanced (hidden by default): - Scheduler internals: sigma_max, sigma_min, rho, mu, beta, alpha - Sampler internals: eta, s_noise, order, rtol, atol, h_init, pcoeff, etc. - Memory optimization: tile_size, overlap, temporal_size, temporal_overlap - Pipeline controls: add_noise, start_at_step, end_at_step - Timing controls: start_percent, end_percent - Layer selection: stop_at_clip_layer, layers, block_number - Video encoding: codec, crf, format - Device/dtype: device, noise_device, dtype, weight_dtype Widgets kept basic (always visible): - Core params: strength, steps, cfg, denoise, seed, width, height - Model selectors: ckpt_name, lora_name, vae_name, sampler_name - Common controls: upscale_method, crop, batch_size, fps, opacity Related: frontend PR #11939 Amp-Thread-ID: https://ampcode.com/threads/T-019c1734-6b61-702e-b333-f02c399963fc * fix: remove advanced=True from DynamicCombo.Input (unsupported) Amp-Thread-ID: https://ampcode.com/threads/T-019c1734-6b61-702e-b333-f02c399963fc * fix: address review - un-mark model merge, video, image, and training node widgets as advanced Per comfyanonymous review: - Model merge arguments should not be advanced (all 14 model-specific merge classes) - SaveAnimatedWEBP lossless/quality/method should not be advanced - SaveWEBM/SaveVideo codec/crf/format should not be advanced - TrainLoraNode options should not be advanced (7 inputs) Amp-Thread-ID: https://ampcode.com/threads/T-019c322b-a3a8-71b7-9962-d44573ca6352 * fix: un-mark batch_size and webcam width/height as advanced (should stay basic) Amp-Thread-ID: https://ampcode.com/threads/T-019c3236-1417-74aa-82a3-bcb365fbe9d1 --------- Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>	2026-02-19 19:20:02 -08:00
Christian Byrne	bbb8864778	add search aliases to all nodes (#12035) ... * feat: Add search_aliases field to node schema Adds `search_aliases` field to improve node discoverability. Users can define alternative search terms for nodes (e.g., "text concat" → StringConcatenate). Changes: - Add `search_aliases: list[str]` to V3 Schema - Add `SEARCH_ALIASES` support for V1 nodes - Include field in `/object_info` response - Add aliases to high-priority core nodes V1 usage: ```python class MyNode: SEARCH_ALIASES = ["alt name", "synonym"] ``` V3 usage: ```python io.Schema( node_id="MyNode", search_aliases=["alt name", "synonym"], ... ) ``` ## Related PRs - Frontend: Comfy-Org/ComfyUI_frontend#XXXX (draft - merge after this) - Docs: Comfy-Org/docs#XXXX (draft - merge after stable) * Propagate search_aliases through V3 Schema.get_v1_info to NodeInfoV1 * feat: add SEARCH_ALIASES for core nodes (#12016) Add search aliases to 22 core nodes in nodes.py to improve node discoverability: - Checkpoint/model loaders: CheckpointLoader, DiffusersLoader - Conditioning nodes: ConditioningAverage, ConditioningSetArea, ConditioningSetMask, ConditioningZeroOut - Style nodes: StyleModelApply - Image nodes: LoadImageMask, LoadImageOutput, ImageBatch, ImageInvert, ImagePadForOutpaint - Latent nodes: LoadLatent, SaveLatent, LatentBlend, LatentComposite, LatentCrop, LatentFlip, LatentFromBatch, LatentUpscale, LatentUpscaleBy, RepeatLatentBatch * feat: add SEARCH_ALIASES for image, mask, and string nodes (#12017) Add search aliases to nodes in comfy_extras for better discoverability: - nodes_mask.py: mask manipulation nodes - nodes_images.py: image processing nodes - nodes_post_processing.py: post-processing effect nodes - nodes_string.py: string manipulation nodes - nodes_compositing.py: compositing nodes - nodes_morphology.py: morphological operation nodes - nodes_latent.py: latent space nodes Uses search_aliases parameter in io.Schema() for v3 nodes. * feat: add SEARCH_ALIASES for audio and video nodes (#12018) Add search aliases to audio and video nodes for better discoverability: - nodes_audio.py: audio loading, saving, and processing nodes - nodes_video.py: video loading and processing nodes - nodes_wan.py: WAN model nodes Uses search_aliases parameter in io.Schema() for v3 nodes. * feat: add SEARCH_ALIASES for model and misc nodes (#12019) Add search aliases to model-related and miscellaneous nodes: - Model nodes: nodes_model_merging.py, nodes_model_advanced.py, nodes_lora_extract.py - Sampler nodes: nodes_custom_sampler.py, nodes_align_your_steps.py - Control nodes: nodes_controlnet.py, nodes_attention_multiply.py, nodes_hooks.py - Training nodes: nodes_train.py, nodes_dataset.py - Utility nodes: nodes_logic.py, nodes_canny.py, nodes_differential_diffusion.py - Architecture-specific: nodes_sd3.py, nodes_pixart.py, nodes_lumina2.py, nodes_kandinsky5.py, nodes_hidream.py, nodes_fresca.py, nodes_hunyuan3d.py - Media nodes: nodes_load_3d.py, nodes_webcam.py, nodes_preview_any.py, nodes_wanmove.py Uses search_aliases parameter in io.Schema() for v3 nodes, SEARCH_ALIASES class attribute for legacy nodes.	2026-01-22 18:36:58 -08:00
Tavi Halperin	d7111e426a	ResizeByLongerSide: support video (#11555) ... (cherry picked from commit 98c6840aa4e5fd5407ba9ab113d209011e474bf6)	2025-12-29 17:07:29 -08:00
Kohaku-Blueleaf	86dbb89fc9	Resolution bucketing and Trainer implementation refactoring (#11117)	2025-12-17 22:15:27 -05:00
comfyanonymous	eaf68c9b5b	Make lora training work on Z Image and remove some redundant nodes. (#10927)	2025-11-26 19:25:32 -05:00
Kohaku-Blueleaf	cc6a8dcd1a	Dataset Processing Nodes and Improved LoRA Trainer Nodes with multi resolution supports. (#10708) ... * Create nodes_dataset.py * Add encoded dataset caching mechanism * make training node to work with our dataset system * allow trainer node to get different resolution dataset * move all dataset related implementation to nodes_dataset * Rewrite dataset system with new io schema * Rewrite training system with new io schema * add ui pbar * Add outputs' id/name * Fix bad id/naming * use single process instead of input list when no need * fix wrong output_list flag * use torch.load/save and fix bad behaviors	2025-11-26 19:18:08 -05:00