84 Commits

Author	SHA1	Message	Date
Luke Mino-Altherr	fef2f01671	refactor: improve function naming for clarity and consistency ... Rename functions to use clearer verb-based names: - pick_best_live_path → select_best_live_path - escape_like_prefix → escape_sql_like_string - list_tree → list_files_recursively - check_asset_file_fast → verify_asset_file_unchanged - _seed_from_paths_batch → _batch_insert_assets_from_paths - reconcile_cache_states_for_root → sync_cache_states_with_filesystem - touch_asset_info_by_id → update_asset_info_access_time - replace_asset_info_metadata_projection → set_asset_info_metadata - expand_metadata_to_rows → convert_metadata_to_rows - _rows_per_stmt → _calculate_rows_per_statement - ensure_within_base → validate_path_within_base - _cleanup_temp → _delete_temp_file_if_exists - validate_hash_format → normalize_and_validate_hash - get_relative_to_root_category_path_of_asset → get_asset_category_and_relative_path Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-02-03 14:20:36 -08:00
Luke Mino-Altherr	481a2fa263	refactor: rename functions to verb-based naming convention ... Rename functions across app/assets/ to follow verb-based naming: - is_scalar → check_is_scalar - project_kv → expand_metadata_to_rows - _visible_owner_clause → _build_visible_owner_clause - _chunk_rows → _iter_row_chunks - _at_least_one → _validate_at_least_one_field - _tags_norm → _normalize_tags_field - _ser_dt → _serialize_datetime - _ser_updated → _serialize_updated_at - _error_response → _build_error_response - _validation_error_response → _build_validation_error_response - file_sender → stream_file_chunks - seed_assets_endpoint → seed_assets - utcnow → get_utc_now - _safe_sort_field → _validate_sort_field - _safe_filename → _sanitize_filename - fast_asset_file_check → check_asset_file_fast - prefixes_for_root → get_prefixes_for_root - blake3_hash → compute_blake3_hash - blake3_hash_async → compute_blake3_hash_async - _is_within → _check_is_within - _rel → _compute_relative Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-02-03 13:58:14 -08:00
Luke Mino-Altherr	4e02245012	fix: ruff linting errors and add comprehensive test coverage for asset queries ... - Fix unused imports in routes.py, asset.py, manager.py, asset_management.py, ingest.py - Fix whitespace issues in upload.py, asset_info.py, ingest.py - Fix typo in manager.py (stray character after result["asset"]) - Fix broken import in test_metadata.py (project_kv moved to asset_info.py) - Add fixture override in queries/conftest.py for unit test isolation Add 48 new tests covering all previously untested query functions: - asset.py: upsert_asset, bulk_insert_assets - cache_state.py: upsert_cache_state, delete_cache_states_outside_prefixes, get_orphaned_seed_asset_ids, delete_assets_by_ids, get_cache_states_for_prefixes, bulk_set_needs_verify, delete_cache_states_by_ids, delete_orphaned_seed_asset, bulk_insert_cache_states_ignore_conflicts, get_cache_states_by_paths_and_asset_ids - asset_info.py: insert_asset_info, get_or_create_asset_info, update_asset_info_timestamps, replace_asset_info_metadata_projection, bulk_insert_asset_infos_ignore_conflicts, get_asset_info_ids_by_ids - tags.py: bulk_insert_tags_and_meta Total: 119 tests pass (up from 71) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-02-03 13:21:12 -08:00
Luke Mino-Altherr	9f9db2c2c2	refactor: extract multipart upload parsing from routes ... - Add app/assets/api/upload.py with parse_multipart_upload() for HTTP parsing - Add ParsedUpload dataclass to schemas_in.py - Add domain exceptions (AssetValidationError, AssetNotFoundError, HashMismatchError) - Add manager.process_upload() with domain exceptions (no HTTP status codes) - Routes map domain exceptions to HTTP responses - Slim down upload_asset route to ~20 lines (was ~150) Amp-Thread-ID: https://ampcode.com/threads/T-019c2519-abe1-738a-ad2e-29ece17c0e42 Co-authored-by: Amp <amp@ampcode.com>	2026-02-03 13:08:04 -08:00
Luke Mino-Altherr	e987bd268f	Move get_comfy_models_folders to path_utils.py to avoid late import ... Amp-Thread-ID: https://ampcode.com/threads/T-019c2510-33fa-7199-ae4b-bc31102277a7 Co-authored-by: Amp <amp@ampcode.com>	2026-02-03 13:08:04 -08:00
Luke Mino-Altherr	2eb100adf9	Refactor helpers.py: move functions to their respective modules ... - Move scanner-only functions to scanner.py - Move query-only functions (is_scalar, project_kv) to asset_info.py - Move get_query_dict to routes.py - Create path_utils.py service for path-related functions - Reduce helpers.py to shared utilities only Amp-Thread-ID: https://ampcode.com/threads/T-019c2510-33fa-7199-ae4b-bc31102277a7 Co-authored-by: Amp <amp@ampcode.com>	2026-02-03 13:08:04 -08:00
Luke Mino-Altherr	a02f160e20	Move hashing.py to services directory ... Amp-Thread-ID: https://ampcode.com/threads/T-019c2510-33fa-7199-ae4b-bc31102277a7 Co-authored-by: Amp <amp@ampcode.com>	2026-02-03 13:08:04 -08:00
Luke Mino-Altherr	c3105b1174	refactor: move bulk_ops to queries and scanner service ... - Delete bulk_ops.py, moving logic to appropriate layers - Add bulk insert query functions: - queries/asset.bulk_insert_assets - queries/cache_state.bulk_insert_cache_states_ignore_conflicts - queries/cache_state.get_cache_states_by_paths_and_asset_ids - queries/asset_info.bulk_insert_asset_infos_ignore_conflicts - queries/asset_info.get_asset_info_ids_by_ids - queries/tags.bulk_insert_tags_and_meta - Move seed_from_paths_batch orchestration to scanner._seed_from_paths_batch Amp-Thread-ID: https://ampcode.com/threads/T-019c24fd-157d-776a-ad24-4f19cf5d3afe Co-authored-by: Amp <amp@ampcode.com>	2026-02-03 13:08:04 -08:00
Luke Mino-Altherr	64d2f51dfc	refactor: move scanner to services layer with pure query extraction ... - Move app/assets/scanner.py to app/assets/services/scanner.py - Extract pure queries from fast_db_consistency_pass: - get_cache_states_for_prefixes() - bulk_set_needs_verify() - delete_cache_states_by_ids() - delete_orphaned_seed_asset() - Split prune_orphaned_assets into pure queries: - delete_cache_states_outside_prefixes() - get_orphaned_seed_asset_ids() - delete_assets_by_ids() - Add reconcile_cache_states_for_root() service function - Add prune_orphaned_assets() service function - Remove function injection pattern - Update imports in main.py, server.py, routes.py Amp-Thread-ID: https://ampcode.com/threads/T-019c24f1-3385-701b-87e0-8b6bc87e841b Co-authored-by: Amp <amp@ampcode.com>	2026-02-03 13:08:04 -08:00
Luke Mino-Altherr	fba4570e49	refactor: move in-function imports to top-level and remove keyword-only argument pattern ... - Move imports from inside functions to module top-level in: - app/assets/database/queries/asset.py - app/assets/database/queries/asset_info.py - app/assets/database/queries/cache_state.py - app/assets/manager.py - app/assets/services/asset_management.py - app/assets/services/ingest.py - Remove keyword-only argument markers (*,) from app/assets/ to match codebase conventions Amp-Thread-ID: https://ampcode.com/threads/T-019c24eb-bfa2-727f-8212-8bc976048604 Co-authored-by: Amp <amp@ampcode.com>	2026-02-03 13:08:04 -08:00
Luke Mino-Altherr	15ee03f65c	Refactor asset database: separate business logic from queries ... Architecture changes: - API Routes -> manager.py (thin adapter) -> services/ (business logic) -> queries/ (atomic DB ops) - Services own session lifecycle via create_session() - Queries accept Session as parameter, do single-table atomic operations New app/assets/services/ layer: - __init__.py - exports all service functions - ingest.py - ingest_file_from_path(), register_existing_asset() - asset_management.py - get_asset_detail(), update_asset_metadata(), delete_asset_reference(), set_asset_preview() - tagging.py - apply_tags(), remove_tags(), list_tags() Removed from queries/asset_info.py: - ingest_fs_asset (moved to services/ingest.py as ingest_file_from_path) - update_asset_info_full (moved to services/asset_management.py as update_asset_metadata) - create_asset_info_for_existing_asset (moved to services/ingest.py as register_existing_asset) Updated manager.py: - Now a thin adapter that transforms API schemas to/from service calls - Delegates all business logic to services layer - No longer imports sqlalchemy.orm.Session or models directly Test updates: - Fixed test_cache_state.py import of pick_best_live_path (moved to helpers.py) - Added comprehensive service layer tests (41 new tests) - All 112 query + service tests pass Amp-Thread-ID: https://ampcode.com/threads/T-019c24e2-7ae4-707f-ad19-c775ed8b82b5 Co-authored-by: Amp <amp@ampcode.com>	2026-02-03 13:08:04 -08:00
Luke Mino-Altherr	70a600baf0	chore: remove unused Asset import from manager.py ... Amp-Thread-ID: https://ampcode.com/threads/T-019c24bb-475b-7442-9ff9-8288edea3345 Co-authored-by: Amp <amp@ampcode.com>	2026-02-03 13:08:04 -08:00
Luke Mino-Altherr	17ad7e393f	refactor(assets): split queries.py into modular query modules ... Split the ~1000 line app/assets/database/queries.py into focused modules: - queries/asset.py - Asset entity queries (asset_exists_by_hash, get_asset_by_hash) - queries/asset_info.py - AssetInfo queries (~15 functions) - queries/cache_state.py - AssetCacheState queries (list_cache_states_by_asset_id, pick_best_live_path, prune_orphaned_assets, fast_db_consistency_pass) - queries/tags.py - Tag queries (8 functions including ensure_tags_exist, add/remove tag functions, list_tags_with_usage) - queries/__init__.py - Re-exports all public functions for backward compatibility Also adds comprehensive unit tests using in-memory SQLite: - tests-unit/assets_test/queries/conftest.py - Session fixture - tests-unit/assets_test/queries/test_asset.py - 5 tests - tests-unit/assets_test/queries/test_asset_info.py - 23 tests - tests-unit/assets_test/queries/test_cache_state.py - 8 tests - tests-unit/assets_test/queries/test_metadata.py - 12 tests for _apply_metadata_filter - tests-unit/assets_test/queries/test_tags.py - 23 tests All 71 unit tests pass. Existing integration tests unaffected. Amp-Thread-ID: https://ampcode.com/threads/T-019c24bb-475b-7442-9ff9-8288edea3345 Co-authored-by: Amp <amp@ampcode.com>	2026-02-03 13:08:04 -08:00
Jedrzej Kosinski	6ea8c128a3	Assets Part 2 - add more endpoints (#12125)	2026-01-31 02:22:05 -05:00
ric-yu	79f6bb5e4f	add blueprints dir for built-in blueprints (#11853)	2026-01-13 16:14:40 -08:00
Jedrzej Kosinski	acd0e53653	Make bulk_ops not use .returning to be compatible with python 3.10 and 3.11 sqlalchemy (#11839)	2026-01-13 00:15:24 -05:00
Jedrzej Kosinski	ec0a832acb	Add workaround for hacky nodepack(s) that edit folder_names_and_paths to have values with tuples of more than 2. Other things could potentially break with those nodepack(s), so I will hunt for the guilty nodepack(s) now. (#11755)	2026-01-08 22:49:12 -08:00
Jedrzej Kosinski	1dc3da6314	Add most basic Asset support for models (#11315) ... * Brought over minimal elements from PR 10045 to reproduce seed_assets and register_assets_system without adding anything to the DB or server routes yet, for now making everything sync (can introduce async once everything is cleaned up and brought over) * Added db script to insert assets stuff, cleaned up some code; assets (models) now get added/rescanned * Added support for 5 http endpoints for assets * Replaced Optional with | None in schemas_in.py and schemas_out.py * Remove two routes that will not be relevant yet in this PR: HEAD /api/assets/hash/<hash> and PUT /api/assets/<id>/preview * Remove some functions the two deleted endpoints were using * Don't show assets scan message upon calling /object_info endpoint * removed unsued import to satisfy ruff * Simplified hashing function tpye hint and _hash_file_obj * Satisfied ruff	2026-01-08 22:21:51 -05:00
comfyanonymous	65cfcf5b1b	New Year ruff cleanup. (#11595)	2026-01-01 22:06:14 -05:00
Dr.Lt.Data	af96d9812d	feat(security): add System User protection with __ prefix (#10966) ... * feat(security): add System User protection with `__` prefix Add protected namespace for custom nodes to store sensitive data (API keys, licenses) that cannot be accessed via HTTP endpoints. Key changes: - New API: get_system_user_directory() for internal access - New API: get_public_user_directory() with structural blocking - 3-layer defense: header validation, path blocking, creation prevention - 54 tests covering security, edge cases, and backward compatibility System Users use `__` prefix (e.g., __system, __cache) following Python's private member convention. They exist in user_directory/ but are completely blocked from /userdata HTTP endpoints. * style: remove unused imports	2025-11-28 21:28:42 -05:00
Dr.Lt.Data	ca7808f240	fix(user_manager): fix typo in move_userdata dest validation (#10967) ... Check `dest` instead of `source` when validating destination path in move_userdata endpoint.	2025-11-28 12:43:17 -08:00
Christian Byrne	87b0359392	Update server templates handler to use new multi-package distribution (comfyui-workflow-templates versions >=0.3) (#10791) ... * update templates for monorepo * refactor	2025-11-19 22:36:56 -08:00
Jedrzej Kosinski	f13cff0be6	Add custom node published subgraphs endpoint (#10438) ... * Add get_subgraphs_dir to ComfyExtension and PUBLISHED_SUBGRAPH_DIRS to nodes.py * Created initial endpoints, although the returned paths are a bit off currently * Fix path and actually return real data * Sanitize returned /api/global_subgraphs entries * Remove leftover function from early prototyping * Remove added whitespace * Add None check for sanitize_entry	2025-10-21 23:16:16 -04:00
Christian Byrne	255572188f	Add workflow templates version tracking to system_stats (#9089) ... Adds installed and required workflow templates version information to the /system_stats endpoint, allowing the frontend to detect and notify users when their templates package is outdated. - Add get_installed_templates_version() and get_required_templates_version() methods to FrontendManager - Include templates version info in system_stats response - Add comprehensive unit tests for the new functionality	2025-09-26 21:29:13 -07:00
Christian Byrne	3e316c6338	Update frontend to v1.25.10 and revert navigation mode override (#9522) ... - Update comfyui-frontend-package from 1.25.9 to 1.25.10 - Revert forced legacy navigation mode from PR #9518 - Frontend v1.25.10 includes proper navigation mode fixes and improved display text	2025-08-23 17:54:01 -04:00
comfyanonymous	8be0d22ab7	Don't use the annoying new navigation mode by default. (#9518)	2025-08-23 13:56:17 -04:00
saurabh-pingale	0737b7e0d2	fix(userdata): catch invalid workflow filenames (#9434) (#9445)	2025-08-20 22:27:57 -04:00
Johnpaul Chiwetelu	3dfefc88d0	API for Recently Used Items (#8792) ... * feat: add file creation time to model file metadata and user file info * fix linting	2025-08-01 22:02:06 -04:00
SHIVANSH GUPTA	d03ae077b4	Added parameter required_frontend_version in the /system_stats API response (#8875) ... * Added the parameter required_frontend_version in the /system_stats api response * Update server.py * Created a function get_required_frontend_version and wrote tests for it * Refactored the function to return currently installed frontend pacakage version * Moved required_frontend to a new function and imported that in server.py * Corrected test cases using mocking techniques * Corrected files to comply with ruff formatting	2025-07-24 14:05:54 -04:00
filtered	baa8c8cdd3	Add '@prerelease' to use latest test frontend (#8501) ... * Add '@prerelease' to use latest test frontend Allows download of pre-release versions. Will always get the latest pre-release version - even if it's older than the latest stable release. * nit	2025-06-12 17:03:27 -07:00
filtered	ecb8d15e7a	Allow specifying any frontend semver suffixes (#8498)	2025-06-11 21:41:30 -04:00
pythongosssss	50c605e957	Add support for sqlite database (#8444) ... * Add support for sqlite database * fix	2025-06-11 16:43:39 -04:00
Benjamin Lu	180db6753f	Add Help Menu in NodeLibrarySidebarTab (#8179)	2025-06-01 04:32:32 -04:00
comfyanonymous	d9c80a85e5	This should not be a warning. (#7946)	2025-05-05 07:49:07 -04:00
Terry Jia	5c5457a4ef	support more example folders (#7836) ... * support more example folders * add warning message	2025-04-29 11:28:04 -04:00
Benjamin Lu	8115a7895b	Add /api/v2/userdata endpoint (#7817) ... * Add list_userdata_v2 * nit * nit * nit * nit * please set me free * \\\\ * \\\\	2025-04-27 20:06:55 -04:00
Christian Byrne	05d5a75cdc	Update frontend to 1.16 (Install templates as pip package) (#7623) ... * install templates as pip package * Update requirements.txt * bump templates version to include hidream --------- Co-authored-by: Chenlei Hu <hcl@comfy.org>	2025-04-17 14:25:33 -04:00
Laurent Erignoux	2b71aab299	User missing (#7439) ... * Ensuring a 401 error is returned when user data is not found in multi-user context. * Returning a 401 error when provided comfy-user does not exists on server side.	2025-04-01 13:53:52 -04:00
Chenlei Hu	ce9b084279	[nit] Format error strings (#7345)	2025-03-21 19:08:25 -04:00
comfyanonymous	f4411250f3	Repeat frontend version warning at the end. ... This way someone running ComfyUI with the command line is more likely to actually see it.	2025-03-12 07:13:40 -04:00
huchenlei	cfbe4b49ca	Access package version	2025-03-10 20:43:59 -04:00
Chenlei Hu	7946049794	nit	2025-03-10 15:14:40 -04:00
Chenlei Hu	1f138dd382	Only check frontend package if using default frontend	2025-03-10 15:07:44 -04:00
comfyanonymous	29832b3b61	Warn if frontend package is older than the one in requirements.txt	2025-03-08 03:51:36 -05:00
comfyanonymous	c3d9cc4592	Print the frontend version in the log.	2025-03-07 19:56:26 -05:00
Dr.Lt.Data	1650cda030	Fixed: Incorrect guide message for missing frontend. (#7105) ... `{sys.executable} -m pip` -> `{sys.executable} -s -m pip` https://github.com/comfyanonymous/ComfyUI/pull/7047#issuecomment-2697876793	2025-03-06 15:23:23 -05:00
comfyanonymous	745b13649b	Add update instructions for the portable.	2025-03-04 23:34:36 -05:00
Dr.Lt.Data	2b140654c7	suggest absolute full path to the requirements.txt instead of just requirements.txt (#7079) ... For users of the portable version, there are occasional instances where commands are misinterpreted.	2025-03-04 23:29:34 -05:00
Dr.Lt.Data	d6e5d487ad	improved: better frontend package installation guide (#7047) ... * improved: better installation guide - change `pip` to `{sys.executable} -m pip` modified: To prevent the guide message from being obscured by a complex error message, apply `exit` instead of `raise`. * ruff fix	2025-03-03 04:40:23 -05:00
comfyanonymous	6752a826f6	Make the missing frontend package error more obvious.	2025-03-02 15:43:56 -05:00