Merge 5a400d837e into 4e823431cc

Merge branch 'master' into cursor/mark-deprecated-cloud-endpoints-e81e
Add cloud-runtime experiment node-schema endpoints to spec (#13806 )
2026-05-10 01:02:56 +08:00 · 2026-05-08 19:48:34 -07:00 · 2026-05-08 19:48:32 -07:00 · 2026-05-08 19:14:23 -07:00 · 2026-05-08 18:30:11 -07:00 · 2026-05-08 17:32:14 -07:00
2 changed files with 79 additions and 253 deletions
--- a/comfy/utils.py
+++ b/comfy/utils.py
@ -1390,7 +1390,7 @@ def convert_old_quants(state_dict, model_prefix="", metadata={}):
                    k_out = "{}.weight_scale".format(layer)

                if layer is not None:
-                    layer_conf = {"format": "float8_e4m3fn"}  # TODO: check if anyone did some non e4m3fn scaled checkpoints
+                    layer_conf = {"format": "float8_e4m3fn"}
                    if full_precision_matrix_mult:
                        layer_conf["full_precision_matrix_mult"] = full_precision_matrix_mult
                    layers[layer] = layer_conf
--- a/openapi.yaml
+++ b/openapi.yaml
@ -74,6 +74,8 @@ tags:
    description: Cloud workflow management and versioning (cloud-only)
  - name: task
    description: Background task management (cloud-only)
+  - name: runtime-only
+    description: Operations served exclusively by the cloud runtime with no local equivalent

 paths:
  # ---------------------------------------------------------------------------
@ -349,35 +351,6 @@ paths:
        "404":
          description: Job not found

-  /api/job/{job_id}/status:
-    get:
-      operationId: getJobStatus
-      tags: [queue]
-      summary: Get job status (legacy singular path)
-      x-runtime: [cloud]
-      deprecated: true
-      description: |
-        **Deprecated.** This endpoint is superseded by `GET /api/jobs/{job_id}`.
-        Clients should migrate; the endpoint is retained for backward
-        compatibility but will be removed in a future release.
-      parameters:
-        - name: job_id
-          in: path
-          description: The job ID to fetch status for.
-          required: true
-          schema:
-            type: string
-            format: uuid
-      responses:
-        "200":
-          description: Job status
-          content:
-            application/json:
-              schema:
-                $ref: "#/components/schemas/JobDetailResponse"
-        "404":
-          description: Job not found
-
  # ---------------------------------------------------------------------------
  # History
  # ---------------------------------------------------------------------------
@ -465,75 +438,6 @@ paths:
                additionalProperties:
                  $ref: "#/components/schemas/HistoryEntry"

-  /api/history_v2:
-    get:
-      operationId: getHistoryV2
-      tags: [history]
-      summary: Get execution history (v2 format)
-      x-runtime: [cloud]
-      deprecated: true
-      description: |
-        **Deprecated.** This endpoint is superseded by `GET /api/jobs`.
-        Clients should migrate; the endpoint is retained for backward
-        compatibility but will be removed in a future release.
-      parameters:
-        - $ref: "#/components/parameters/ComfyUserHeader"
-        - name: limit
-          in: query
-          schema:
-            type: integer
-          description: Maximum number of history entries to return
-        - name: offset
-          in: query
-          schema:
-            type: integer
-            default: 0
-          description: Pagination offset
-      responses:
-        "200":
-          description: History entries
-          content:
-            application/json:
-              schema:
-                type: object
-                properties:
-                  items:
-                    type: array
-                    items:
-                      $ref: "#/components/schemas/HistoryEntry"
-                  pagination:
-                    $ref: "#/components/schemas/PaginationInfo"
-
-  /api/history_v2/{prompt_id}:
-    get:
-      operationId: getHistoryV2ByPromptId
-      tags: [history]
-      summary: Get v2 history for a specific prompt
-      x-runtime: [cloud]
-      deprecated: true
-      description: |
-        **Deprecated.** This endpoint is superseded by `GET /api/jobs/{prompt_id}`.
-        Clients should migrate; the endpoint is retained for backward
-        compatibility but will be removed in a future release.
-      parameters:
-        - $ref: "#/components/parameters/ComfyUserHeader"
-        - name: prompt_id
-          in: path
-          description: The prompt ID to fetch history for.
-          required: true
-          schema:
-            type: string
-            format: uuid
-      responses:
-        "200":
-          description: Single history entry
-          content:
-            application/json:
-              schema:
-                $ref: "#/components/schemas/HistoryEntry"
-        "404":
-          description: Prompt not found
-
  # ---------------------------------------------------------------------------
  # Upload
  # ---------------------------------------------------------------------------
@ -690,71 +594,6 @@ paths:
        "404":
          description: File not found

-  /api/viewvideo:
-    get:
-      operationId: viewVideo
-      tags: [view]
-      summary: View or download a video file (legacy alias)
-      x-runtime: [cloud]
-      deprecated: true
-      description: |
-        **Deprecated.** This endpoint is an alias of `GET /api/view` added for
-        legacy history-queue video playback. Callers should use `/api/view`
-        directly; the endpoint is retained for backward compatibility but will
-        be removed in a future release.
-      parameters:
-        - name: filename
-          in: query
-          required: true
-          schema:
-            type: string
-          description: Name of the file to view
-        - name: type
-          in: query
-          schema:
-            type: string
-            enum: [input, output, temp]
-            default: output
-          description: Directory type
-        - name: subfolder
-          in: query
-          schema:
-            type: string
-          description: Subfolder within the directory
-        - name: preview
-          in: query
-          schema:
-            type: string
-          description: Preview format hint (e.g. "webp;90")
-        - name: channel
-          in: query
-          schema:
-            type: string
-            enum: [rgba, rgb, a]
-          description: Channel extraction mode
-      responses:
-        "200":
-          description: File content
-          content:
-            image/*:
-              schema:
-                type: string
-                format: binary
-            video/*:
-              schema:
-                type: string
-                format: binary
-            audio/*:
-              schema:
-                type: string
-                format: binary
-            application/octet-stream:
-              schema:
-                type: string
-                format: binary
-        "404":
-          description: File not found
-
  /api/view_metadata/{folder_name}:
    get:
      operationId: viewMetadata
@ -855,32 +694,6 @@ paths:
                    x-runtime: [cloud]
                    description: "[cloud-only] How the templates version was resolved. Local ComfyUI returns null."

-  /api/logs:
-    get:
-      operationId: getLogs
-      tags: [system]
-      summary: Get server logs (placeholder)
-      x-runtime: [cloud]
-      deprecated: true
-      description: |
-        **Deprecated.** This endpoint returns a static placeholder response and
-        provides no real log data. It is retained only to avoid breaking clients
-        that still call it. Clients should remove their dependency; the endpoint
-        will be removed in a future release.
-      responses:
-        "200":
-          description: Static placeholder log response
-          content:
-            application/json:
-              schema:
-                type: object
-                properties:
-                  logs:
-                    type: array
-                    items:
-                      type: string
-                    description: Log lines (always empty in current implementation)
-
  # ---------------------------------------------------------------------------
  # Node / Object Info
  # ---------------------------------------------------------------------------
@ -2258,7 +2071,6 @@ paths:
                    type: integer
                    description: Number of assets marked as missing

-
  # ===========================================================================
  # Cloud-runtime FE-facing operations
  #
@ -2309,7 +2121,11 @@ paths:
      operationId: getCloudJobStatus
      tags: [queue]
      summary: Get status of a cloud job
-      description: "[cloud-only] Returns the current execution status of a cloud job."
+      deprecated: true
+      description: |
+        **Deprecated.** This endpoint is superseded by `GET /api/jobs/{job_id}`.
+        Clients should migrate; the endpoint is retained for backward
+        compatibility but will be removed in a future release.
      x-runtime: [cloud]
      parameters:
        - name: job_id
@ -2379,7 +2195,11 @@ paths:
      operationId: getHistoryV2
      tags: [history]
      summary: Get paginated execution history (v2)
-      description: "[cloud-only] Returns a paginated list of execution history entries in the v2 format, with richer metadata than the legacy history endpoint."
+      deprecated: true
+      description: |
+        **Deprecated.** This endpoint is superseded by `GET /api/jobs`.
+        Clients should migrate; the endpoint is retained for backward
+        compatibility but will be removed in a future release.
      x-runtime: [cloud]
      parameters:
        - name: limit
@ -2418,7 +2238,11 @@ paths:
      operationId: getHistoryV2ByPromptId
      tags: [history]
      summary: Get v2 history for a specific prompt
-      description: "[cloud-only] Returns the v2 history entry for a specific prompt execution."
+      deprecated: true
+      description: |
+        **Deprecated.** This endpoint is superseded by `GET /api/jobs/{prompt_id}`.
+        Clients should migrate; the endpoint is retained for backward
+        compatibility but will be removed in a future release.
      x-runtime: [cloud]
      parameters:
        - name: prompt_id
@ -2453,7 +2277,12 @@ paths:
      operationId: getCloudLogs
      tags: [system]
      summary: Get cloud execution logs
-      description: "[cloud-only] Returns execution logs for the authenticated user's cloud jobs."
+      deprecated: true
+      description: |
+        **Deprecated.** This endpoint returns a static placeholder response and
+        provides no real log data. It is retained only to avoid breaking clients
+        that still call it. Clients should remove their dependency; the endpoint
+        will be removed in a future release.
      x-runtime: [cloud]
      parameters:
        - name: job_id
@ -2762,35 +2591,38 @@ paths:
  # ---------------------------------------------------------------------------
  /api/experiment/nodes:
    get:
-      operationId: listCloudNodes
-      tags: [node]
-      summary: List installed custom nodes
-      description: "[cloud-only] Returns the list of custom node packages installed in the cloud runtime."
+      operationId: getNodeInfoSchema
+      tags: [runtime-only]
+      summary: Get pre-rendered node info schema
+      description: "[cloud-only] Returns the static ComfyUI object_info schema, identical for every caller, rendered once at startup with empty model/user-file context. Served by a raw HTTP handler that writes pre-rendered bytes with ETag + Cache-Control validators for RFC 7232 conditional GETs."
      x-runtime: [cloud]
      parameters:
-        - name: limit
-          in: query
+        - name: If-None-Match
+          in: header
+          required: false
          schema:
-            type: integer
-          description: Maximum number of results
-        - name: offset
-          in: query
-          schema:
-            type: integer
-          description: Pagination offset
+            type: string
+          description: Entity tag previously returned by this endpoint. When present and matching, the server returns 304 Not Modified.
      responses:
        "200":
-          description: Custom node list
+          description: Node info schema
+          headers:
+            ETag:
+              schema:
+                type: string
+              description: Entity tag for conditional request validation
+            Cache-Control:
+              schema:
+                type: string
+              description: Cache directives for the response
          content:
            application/json:
              schema:
-                $ref: "#/components/schemas/CloudNodeList"
-        "401":
-          description: Unauthorized
-          content:
-            application/json:
-              schema:
-                $ref: "#/components/schemas/CloudError"
+                type: object
+                additionalProperties:
+                  $ref: "#/components/schemas/NodeInfo"
+        "304":
+          description: Not Modified — returned when the client sends a matching If-None-Match header
    post:
      operationId: installCloudNode
      tags: [node]
@ -2840,10 +2672,10 @@ paths:

  /api/experiment/nodes/{id}:
    get:
-      operationId: getCloudNode
-      tags: [node]
-      summary: Get details of an installed custom node
-      description: "[cloud-only] Returns details about a specific installed custom node package."
+      operationId: getNodeByID
+      tags: [runtime-only]
+      summary: Get a single node definition by ID
+      description: "[cloud-only] Returns one node's definition from the pre-indexed object_info schema. Served by a raw HTTP handler that writes pre-rendered bytes with ETag + Cache-Control validators for RFC 7232 conditional GETs."
      x-runtime: [cloud]
      parameters:
        - name: id
@ -2851,26 +2683,33 @@ paths:
          required: true
          schema:
            type: string
-          description: Custom node package ID
+          description: Node class identifier
+        - name: If-None-Match
+          in: header
+          required: false
+          schema:
+            type: string
+          description: Entity tag previously returned by this endpoint. When present and matching, the server returns 304 Not Modified.
      responses:
        "200":
-          description: Node detail
+          description: Single node definition
+          headers:
+            ETag:
+              schema:
+                type: string
+              description: Entity tag for conditional request validation
+            Cache-Control:
+              schema:
+                type: string
+              description: Cache directives for the response
          content:
            application/json:
              schema:
-                $ref: "#/components/schemas/CloudNode"
-        "401":
-          description: Unauthorized
-          content:
-            application/json:
-              schema:
-                $ref: "#/components/schemas/CloudError"
+                $ref: "#/components/schemas/NodeInfo"
+        "304":
+          description: Not Modified — returned when the client sends a matching If-None-Match header
        "404":
-          description: Not found
-          content:
-            application/json:
-              schema:
-                $ref: "#/components/schemas/CloudError"
+          description: Node not found
    delete:
      operationId: uninstallCloudNode
      tags: [node]
@ -5547,7 +5386,12 @@ paths:
      operationId: viewVideo
      tags: [view]
      summary: View or download a video file
-      description: "[cloud-only] Serves a video file from the output directory. Used by the frontend video player."
+      deprecated: true
+      description: |
+        **Deprecated.** This endpoint is an alias of `GET /api/view` added for
+        legacy history-queue video playback. Callers should use `/api/view`
+        directly; the endpoint is retained for backward compatibility but will
+        be removed in a future release.
      x-runtime: [cloud]
      parameters:
        - name: filename
@ -5700,7 +5544,6 @@ paths:
              schema:
                $ref: "#/components/schemas/CloudError"

-
 components:
  parameters:
    ComfyUserHeader:
@ -7052,7 +6895,6 @@ components:
        error:
          type: string

-
    # -------------------------------------------------------------------
    # Cloud-runtime schemas
    #
@ -7289,22 +7131,6 @@ components:
        enabled:
          type: boolean

-    CloudNodeList:
-      type: object
-      x-runtime: [cloud]
-      description: "[cloud-only] Paginated list of installed custom node packages."
-      required:
-        - nodes
-      properties:
-        nodes:
-          type: array
-          items:
-            $ref: "#/components/schemas/CloudNode"
-        total:
-          type: integer
-        has_more:
-          type: boolean
-
    HubLabel:
      type: object
      x-runtime: [cloud]
Author	SHA1	Message	Date
Matt Miller	ed09c3d2f1	Merge `5a400d837e` into `4e823431cc`	2026-05-08 19:48:34 -07:00
Matt Miller	5a400d837e	Merge branch 'master' into cursor/mark-deprecated-cloud-endpoints-e81e Some checks are pending Python Linting / Run Ruff (push) Waiting to run Details Python Linting / Run Pylint (push) Waiting to run Details	2026-05-08 19:48:32 -07:00
Matt Miller	4e823431cc	Add cloud-runtime experiment node-schema endpoints to spec (#13806 ) * Add cloud-runtime experiment node-schema endpoints to spec Replace the GET operations at /api/experiment/nodes and /api/experiment/nodes/{id} with getNodeInfoSchema and getNodeByID — the optimized, ETag-tagged object_info schema endpoints the cloud frontend depends on for the workflow editor. Each operation is tagged x-runtime: [cloud] and uses the runtime-only tag for cloud-side codegen exclusion. Response headers document the ETag and Cache-Control validators; 304 Not Modified is declared for RFC 7232 conditional GETs. Remove the now-unused CloudNodeList schema to keep Spectral clean. Co-authored-by: Matt Miller <MillerMedia@users.noreply.github.com> * spec: document If-None-Match header on conditional GET endpoints Both `getNodeInfoSchema` and `getNodeByID` advertise `ETag` response headers and a `304 Not Modified` response, but the spec didn't declare the `If-None-Match` request header that triggers conditional validation. Adding it as an optional header parameter on both ops so client codegen exposes the conditional-GET pattern.	2026-05-08 19:14:23 -07:00
Matt Miller	81af8e4de2	fix(spec): consolidate duplicate path entries on deprecated cloud-runtime endpoints Previous commit added new path entries with `deprecated: true` for `/api/job/{job_id}/status`, `/api/history_v2`, `/api/history_v2/{prompt_id}`, `/api/logs`, and `/api/viewvideo`, but the canonical entries already existed elsewhere in the file. Result: 5 duplicate path keys (Spectral parser errors), and the deprecation flag did not land on the operations that FE clients consume by operationId. This commit moves `deprecated: true` plus the standardized "Deprecated." description onto the canonical operations (`getCloudJobStatus`, `getHistoryV2`, `getHistoryV2ByPromptId`, `getCloudLogs`, `viewVideo`) and removes the duplicate entries. Operation IDs and response schemas are unchanged. Spectral lint passes with zero new warnings.	2026-05-08 18:30:11 -07:00
comfyanonymous	66669b2ded	I don't think there was any because nobody complained. (#13807 ) Some checks are pending Python Linting / Run Ruff (push) Waiting to run Details Python Linting / Run Pylint (push) Waiting to run Details Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run Details Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run Details Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run Details Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run Details Execution Tests / test (macos-latest) (push) Waiting to run Details Execution Tests / test (ubuntu-latest) (push) Waiting to run Details Execution Tests / test (windows-latest) (push) Waiting to run Details Test server launches without errors / test (push) Waiting to run Details Unit Tests / test (macos-latest) (push) Waiting to run Details Unit Tests / test (ubuntu-latest) (push) Waiting to run Details Unit Tests / test (windows-2022) (push) Waiting to run Details	2026-05-08 17:32:14 -07:00