ComfyUI/app/assets
Luke Mino-Altherr 15ee03f65c Refactor asset database: separate business logic from queries
Architecture changes:
- API Routes -> manager.py (thin adapter) -> services/ (business logic) -> queries/ (atomic DB ops)
- Services own session lifecycle via create_session()
- Queries accept Session as parameter, do single-table atomic operations

New app/assets/services/ layer:
- __init__.py - exports all service functions
- ingest.py - ingest_file_from_path(), register_existing_asset()
- asset_management.py - get_asset_detail(), update_asset_metadata(), delete_asset_reference(), set_asset_preview()
- tagging.py - apply_tags(), remove_tags(), list_tags()

Removed from queries/asset_info.py:
- ingest_fs_asset (moved to services/ingest.py as ingest_file_from_path)
- update_asset_info_full (moved to services/asset_management.py as update_asset_metadata)
- create_asset_info_for_existing_asset (moved to services/ingest.py as register_existing_asset)

Updated manager.py:
- Now a thin adapter that transforms API schemas to/from service calls
- Delegates all business logic to services layer
- No longer imports sqlalchemy.orm.Session or models directly

Test updates:
- Fixed test_cache_state.py import of pick_best_live_path (moved to helpers.py)
- Added comprehensive service layer tests (41 new tests)
- All 112 query + service tests pass

Amp-Thread-ID: https://ampcode.com/threads/T-019c24e2-7ae4-707f-ad19-c775ed8b82b5
Co-authored-by: Amp <amp@ampcode.com>
2026-02-03 13:08:04 -08:00
..
api Assets Part 2 - add more endpoints (#12125) 2026-01-31 02:22:05 -05:00
database Refactor asset database: separate business logic from queries 2026-02-03 13:08:04 -08:00
services Refactor asset database: separate business logic from queries 2026-02-03 13:08:04 -08:00
hashing.py Add most basic Asset support for models (#11315) 2026-01-08 22:21:51 -05:00
helpers.py Refactor asset database: separate business logic from queries 2026-02-03 13:08:04 -08:00
manager.py Refactor asset database: separate business logic from queries 2026-02-03 13:08:04 -08:00
scanner.py refactor(assets): split queries.py into modular query modules 2026-02-03 13:08:04 -08:00