ComfyUI/app/assets/services
Luke Mino-Altherr 7f3415549e
Some checks are pending
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Build package / Build Test (3.10) (push) Waiting to run
Build package / Build Test (3.11) (push) Waiting to run
Build package / Build Test (3.12) (push) Waiting to run
Build package / Build Test (3.13) (push) Waiting to run
Build package / Build Test (3.14) (push) Waiting to run
Fix five code review issues
1. Seeder pause/resume: only resume after prompt execution if pause()
   returned True, preventing undo of user-initiated pauses.

2. Missing rollback in enrich_assets_batch: add sess.rollback() in
   exception handler to prevent broken session state for subsequent
   batch operations.

3. Hash checkpoint validation: store mtime_ns/file_size in
   HashCheckpoint and re-stat on resume instead of comparing the same
   stat result to itself.

4. Scan progress preserved: save _last_progress before clearing
   _progress in finally blocks so wait=true endpoint returns final
   stats instead of zeros.

5. Download XSS hardening: block dangerous MIME types (matching
   server.py) and add X-Content-Type-Options: nosniff header to
   asset content endpoint.

Amp-Thread-ID: https://ampcode.com/threads/T-019cbb6b-e97b-776d-8c43-2de8acd0d09e
Co-authored-by: Amp <amp@ampcode.com>
2026-03-04 16:49:44 -08:00
..
__init__.py Reduce duplication across assets module 2026-03-03 17:23:32 -08:00
asset_management.py feat: soft-delete for AssetReference with scanner persistence 2026-03-03 20:15:14 -08:00
bulk_ingest.py Fix asset API security and correctness issues 2026-03-03 18:47:48 -08:00
file_utils.py fix: follow symlinks in list_files_recursively with cycle detection 2026-03-03 15:51:52 -08:00
hashing.py Fix five code review issues 2026-03-04 16:49:44 -08:00
ingest.py Add checkpoint/interrupt support to BLAKE3 hashing 2026-03-04 15:22:42 -08:00
metadata_extract.py fix: support in-memory SQLite and ensure custom MIME types are initialized 2026-03-04 16:28:10 -08:00
path_utils.py Reduce duplication across assets module 2026-03-03 17:23:32 -08:00
schemas.py Reduce duplication across assets module 2026-03-03 17:23:32 -08:00
tagging.py Reduce duplication across assets module 2026-03-03 17:23:32 -08:00