feat(task): 暴露任务取消控制状态

This commit is contained in:
chengcheng 2026-06-25 17:01:32 +08:00
parent 6089aa6085
commit f4e1db1279
4 changed files with 49 additions and 0 deletions

View File

@ -1598,6 +1598,10 @@ func boolValue(body map[string]any, key string) bool {
func (s *Server) getTask(w http.ResponseWriter, r *http.Request) {
task, err := s.store.GetTask(r.Context(), r.PathValue("taskID"))
if err == nil {
cancelState := runner.DescribeTaskCancellation(task)
task.Cancellable = &cancelState.Cancellable
task.Submitted = &cancelState.Submitted
task.Message = cancelState.Message
writeJSON(w, http.StatusOK, task)
return
}

View File

@ -20,6 +20,25 @@ type TaskCancelResult struct {
Message string `json:"message"`
}
func DescribeTaskCancellation(task store.GatewayTask) TaskCancelResult {
if taskCancelTerminalStatus(task.Status) {
return taskCancelUnavailable(task, "任务已结束,无法取消")
}
if strings.TrimSpace(task.RemoteTaskID) != "" {
return taskCancelUnavailable(task, "任务已提交上游,当前不可取消,请继续查询结果")
}
if strings.TrimSpace(task.Status) != "queued" {
return taskCancelUnavailable(task, "任务已开始执行,当前阶段不可取消,请继续查询结果")
}
return TaskCancelResult{
TaskID: task.ID,
Cancelled: false,
Cancellable: true,
Submitted: false,
Message: "任务仍在本地队列中,可取消",
}
}
func (s *Service) CancelTask(ctx context.Context, taskID string, user *auth.User) (TaskCancelResult, error) {
task, err := s.store.GetTask(ctx, taskID)
if err != nil {

View File

@ -76,3 +76,26 @@ func TestTaskCancelUnavailableReportsSubmittedFromRemoteTaskID(t *testing.T) {
t.Fatalf("remote task id should report submitted: %+v", result)
}
}
func TestDescribeTaskCancellationReportsQueuedTaskAsCancellable(t *testing.T) {
result := DescribeTaskCancellation(store.GatewayTask{ID: "task-queued", Status: "queued"})
if result.TaskID != "task-queued" {
t.Fatalf("unexpected task id: %+v", result)
}
if result.Cancelled || !result.Cancellable || result.Submitted {
t.Fatalf("queued local task should be cancellable and not submitted: %+v", result)
}
}
func TestDescribeTaskCancellationReportsRemoteTaskAsSubmitted(t *testing.T) {
result := DescribeTaskCancellation(store.GatewayTask{
ID: "task-remote",
Status: "running",
RemoteTaskID: "remote-1",
})
if result.Cancelled || result.Cancellable || !result.Submitted {
t.Fatalf("remote task should be submitted and non-cancellable: %+v", result)
}
}

View File

@ -446,6 +446,9 @@ type GatewayTask struct {
AsyncMode bool `json:"asyncMode"`
RiverJobID int64 `json:"riverJobId,omitempty"`
Status string `json:"status"`
Cancellable *bool `json:"cancellable,omitempty"`
Submitted *bool `json:"submitted,omitempty"`
Message string `json:"message,omitempty"`
AttemptCount int `json:"attemptCount"`
RemoteTaskID string `json:"remoteTaskId,omitempty"`
RemoteTaskPayload map[string]any `json:"remoteTaskPayload,omitempty"`