5770 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Jukka SeppänenandGitHub	0246a5e624	Merge 4cf6a777f6 into 55a15f87ce	2026-07-09 13:08:42 +08:00
3 people	55a15f87ce	feat(assets): add namespaced model_type tags and align tag semantics (#14511) ... * feat(assets): add namespaced model type tags * fix(assets): mark path-derived upload tags automatic * fix(assets): merge duplicate scan specs * test(assets): make duplicate path normalization portable * feat(assets): add loader_path as the authoritative loader locator (#14796) * fix(assets): filter model_type tags by bucket extension sets Buckets sharing a base directory (e.g. diffusion_models and a custom unet_gguf) tagged every file in the directory regardless of whether the bucket could load it, so .safetensors files were tagged model_type:unet_gguf and vice versa. Carry each bucket's registered extension set through get_comfy_models_folders and only emit a model_type tag when the file extension matches, keeping the empty-set match-all convention from folder_paths.filter_files_extensions. Files under a model base matching no bucket now keep only the models tag instead of every directory-matching model_type tag. * feat(assets): replace response file_path with persisted loader_path The old file_path response field was a namespaced storage locator (models/checkpoints/foo.safetensors): not an absolute path, not unique identity, and not the value a loader consumes. Nothing needs that shape on the wire (hash/ID-based locating is the long-term direction), so it is dropped rather than renamed; the storage-root matching stays internal, powering display_name. What loaders DO need is the in-root loader path (category dropped: models/checkpoints/foo/bar.safetensors -> foo/bar.safetensors). Serve it as a first-class loader_path field, persisted on asset_references (migration 0006) and written by every ingest pipeline at insert, so responses read the column verbatim. Like the model_type tags, loader_path is a seed-time derivative of the model folder registry, maintained by the same scan lifecycle (new files seed fresh values, pruning retires rows whose bucket disappeared). Rows predating the column serve a null loader_path; databases from before this stack already need recreating for the base branch's tag changes. loader_path resolves every registered base including extra_model_paths entries; display_name only the canonical storage roots. A file can therefore be loadable with no display name (extra-path models) or the reverse (unregistered files under the models root), and loader_path is null exactly when no loader can resolve the file. * test(assets): lock loader_path matrix (asymmetry, null, persist/read) Cover the behaviour that has no production change but is easy to regress: the extra-path asymmetry (loadable but no storage namespace), null loader_path persistence for orphan files, and the response reading the stored column with a compute fallback for un-backfilled rows. * fix(assets): persist subfolder-qualified loader_path for ingested outputs ingest_existing_file built its seed spec with the file's basename, so outputs saved into a subfolder persisted loader_path (and the user_metadata filename that preview URLs split for their subfolder param) as just the basename: the served locator pointed at a file that does not exist at that path. Scanner and seeder specs already derive fname via compute_loader_path; use the same derivation here. * fix(assets): only extension-matching buckets contribute a loader_path The model-base match in get_asset_category_and_relative_path ignored each bucket's extension set, so a file inside a registered base whose extension the bucket cannot load (e.g. a .txt uploaded into model_type:checkpoints) advertised a loader_path that no loader list would ever resolve, while the tag side of the same stack already excluded it. Apply the extension check used for backend tags (empty set accepts any extension), keeping loader_path null exactly when no loader can resolve the file. * fix(assets): refresh loader_path when re-ingesting an existing reference upsert_reference only wrote loader_path on the INSERT branch, so re-ingesting an existing reference (an output overwritten in place, or a file re-registered after its loader_path derivation changed) kept the stale or NULL value forever. Write it on the UPDATE branch too, with a null-safe change guard so a loader_path difference alone is enough to trigger the update, and identical values stay a no-op. * fix(assets): repair semantic merge breakage from #14796 and master Two textually-clean but semantically-broken merges: - routes.py lost its folder_paths import when #14796's import block superseded the base's, while the content-type hardening added via the base's master merge still calls folder_paths.is_dangerous_content_type. - master's SVG download-hardening test uploads with the pre-namespacing bare checkpoints tag, which this branch's destination validation rejects; use model_type:checkpoints. --------- Co-authored-by: guill <jacob.e.segal@gmail.com>	2026-07-08 22:00:08 -07:00
Daxiong (Lin)andGitHub	6cc814437f	Update workflow templates to v0.11.6 (#14834)	2026-07-08 14:04:57 -07:00
Alexander PiskunandGitHub	24d3ea3265	[Partner Nodes] feat(ByteDance): add Seedream 5 Pro model support (#14832)	2026-07-08 14:04:19 -07:00
j2gg0sandGitHub	c6cb904994	Fix AttributeError in VAE.is_dynamic() for VAEs constructed without a patcher (#14826)	2026-07-08 16:01:43 -04:00
SilverandGitHub	091b70edda	add models-directory launch argument (#9113)	2026-07-08 22:20:47 +08:00
comfyanonymousandGitHub	ffbecfffb9	Fix crash when using UNetSelfAttentionMultiply (#14823)	2026-07-07 21:17:31 -07:00
comfyanonymousandGitHub	b481bc15af	Support gqa on all attention backends, drop support for pytorch 2.4 (#14772)	2026-07-07 22:57:52 -04:00
comfyanonymousandGitHub	6880614319	Update AGENTS.md (#14819)	2026-07-07 18:36:13 -07:00
Barish OzbayandGitHub	51bf508a0b	feat: Implement basic text overlay node (CORE-137) (#14610)	2026-07-07 21:26:52 +08:00
3 people	a3020f107e	fix(Video): don't crash on videos with undecodable audio streams (#14746) ... * fix(Video): don't crash on videos with undecodable audio streams Signed-off-by: bigcat88 <bigcat88@icloud.com> * Update comfy_api_nodes/util/upload_helpers.py --------- Signed-off-by: bigcat88 <bigcat88@icloud.com> Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>	2026-07-07 15:59:49 +03:00
comfyanonymousandGitHub	7cf4e78335	Delete symlink that breaks our updates. (#14803)	2026-07-06 22:24:05 -04:00
Alexis RollandandGitHub	7747c342d4	ci: add CLA Assistant workflow (#14582)	2026-07-07 06:44:19 +08:00
comfyanonymousandGitHub	439bd807f8	Skip unloading dynamic model patchers in current workflow. (#14799)	2026-07-06 14:35:12 -07:00
Daxiong (Lin)andGitHub	b08debceca	chore: update embedded docs to v0.5.7 (#14783)	2026-07-06 09:56:09 +08:00
comfyanonymousandGitHub	000c6b784e	Small speedup for text model sampling. (#14773)	2026-07-05 18:39:24 -07:00
Alexander PiskunandGitHub	985fb9d6ad	[Partner Nodes] fix(logs-auth): mask authorization headers in logs (#14774) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-05 13:55:29 +03:00
Alexis RollandandGitHub	4cf6a777f6	Merge branch 'master' into pixal3d	2026-07-05 15:41:54 +08:00
Alexis RollandandGitHub	7f287b705e	fix: Bug when setting transparency in color picker (#14764)	2026-07-04 19:13:38 -04:00
comfyanonymousandGitHub	b7ba504e06	Try to make coderabbit enforce AGENTS.md (#14759)	2026-07-04 14:25:24 -04:00
SilverandGitHub	6c62ca0b6b	fix: error when embedding is loaded with models using llama_template (#14744)	2026-07-04 17:06:09 +08:00
Robin HuangandGitHub	3fe9f5fecb	Add CLAUDE.md as symlink to AGENTS.md (#14757)	2026-07-04 13:12:47 +08:00
Alexander PiskunandGitHub	1073a74976	[Partner Nodes] chore(ByteDance): adjust category name (#14752) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-04 00:01:05 +03:00
comfyanonymousandGitHub	de1b8f3e8d	Update AGENTS.md (#14738)	2026-07-03 13:08:24 -07:00
kijai	ccdf4c811b	Unwrap progress bar	2026-07-03 20:44:20 +03:00
kijai	5067ac461e	Refactor/optimize UV unwrap	2026-07-03 20:23:26 +03:00
kijai	3b34e177cb	Separate preprocessing	2026-07-03 20:22:11 +03:00
Alexis RollandandGitHub	ed16bd8319	Merge branch 'master' into pixal3d	2026-07-03 20:56:02 +08:00
kijai	5b35c13510	use lanczos for mask too like upstream	2026-07-03 14:47:32 +03:00
Alexander PiskunandGitHub	77917ed3a6	[Partner Nodes] chore(StabilityAI): remove StabilityAI nodes (#14737) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-03 14:24:21 +03:00
Daxiong (Lin)andGitHub	a04ebe05c2	chore: update workflow templates to v0.11.2 (#14741)	2026-07-03 19:08:11 +08:00
Alexander PiskunandGitHub	9764381998	[Partner Nodes] feat(ByteDance): add support for Seed Audio 1.0 (#14731) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-03 14:00:10 +03:00
kijai	f54c4fbb8b	Fix import	2026-07-03 12:26:00 +03:00
kijai	334eaecab0	Category	2026-07-03 12:24:08 +03:00
kijai	80da0fd2b4	Move GetMeshInfo node	2026-07-03 12:18:55 +03:00
kijai	361fa98202	Add RenderMesh, cleanup	2026-07-03 11:45:25 +03:00
Alexis RollandandGitHub	343939a2cf	Merge branch 'master' into pixal3d	2026-07-03 15:17:08 +08:00
comfyanonymousandGitHub	1e04ced089	Update AGENTS.md (#14733)	2026-07-03 02:08:47 -04:00
Matt MillerandGitHub	96e0e3585b	security: fix four vulnerabilities (GHSA-779p-m5rp-r4h4) (#14734) ... * security: fix five vulnerabilities (GHSA-779p-m5rp-r4h4) - CVE-2026-56670: force download of SVG/XML responses on /view to prevent stored XSS - CVE-2026-56671: contain /experiment/models/preview reads within the model folder - CVE-2026-56672: stop inline rendering of uploaded /userdata/{file} content - CVE-2026-56673: prevent path traversal in get_annotated_filepath (LoadImage /prompt input) - CVE-2026-56674: reject opaque/null Origin to close the CSRF middleware bypass Adds regression tests under tests-unit/security_test/ covering all five. * security: address review feedback on GHSA-779p fixes - Fix Windows CI failure in test_get_annotated_filepath: compare against os.path.abspath(...) to match the intentional abspath normalization added by the traversal hardening (abspath prepends the drive letter on Windows). - origin_check: narrow the bare `except:` in is_loopback() to ValueError so genuine interrupts aren't swallowed (review nit). - origin_check: guard .port access in is_cross_origin_forbidden() so a malformed/out-of-range port (e.g. Origin: http://127.0.0.1:99999) fails closed with a 403 instead of surfacing an uncaught 500 in the middleware. - server /view: escape backslash/quote in the Content-Disposition filename (RFC 6266 quoted-string) so a filename containing a double quote can't malform the response header. * security: address CodeRabbit review feedback on GHSA-779p tests - test #3: guard the symlink-escape test with a try/except skip so it no longer errors on Windows CI where os.symlink needs elevated privileges / Developer Mode (mirrors the guard in the sibling test #2). - test #5: refresh the stale module docstring to describe the actual /view gating (view_image closure calling folder_paths.is_dangerous_content_type, the normalising check) instead of the bypassable raw set-membership test. * revert(security): drop CVE-2026-56674 Origin: null CSRF change Per maintainer review, the reported CSRF is already mitigated by the pre-existing Sec-Fetch-Site: cross-site check for current browsers, and the null-origin rejection risked breaking legitimate sandboxed-iframe embeds. Restores origin_only_middleware and is_loopback in server.py to their prior state (the Sec-Fetch-Site check is retained) and removes utils/origin_check.py and its regression test. The other four GHSA-779p fixes are unaffected.	2026-07-02 20:44:54 -07:00
kijai	429b13f97c	Fix normal smoothing and some cleanup	2026-07-03 00:57:37 +03:00
comfyanonymousandGitHub	35c1470935	Update AGENTS.md (#14726)	2026-07-02 15:05:55 -04:00
kijai	d635cc412d	Miscellanous cleanup	2026-07-02 16:34:16 +03:00
kijai	419e726061	More cleanup	2026-07-02 15:28:51 +03:00
kijai	be67e2366d	Cleanup NAF	2026-07-02 11:24:16 +03:00
kijai	29e2118717	Minor cleanup	2026-07-02 10:23:17 +03:00
Jukka SeppänenandGitHub	1a6d6b9961	Merge branch 'master' into pixal3d	2026-07-02 09:38:14 +03:00
3 people	694815f498	[Partner Nodes] chore(Ideogram): remove IdeogramV1 and IdeogramV2 nodes (#14712) ... Signed-off-by: bigcat88 <bigcat88@icloud.com> Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>	2026-07-02 08:35:11 +03:00
comfyanonymousandGitHub	92594ca84c	Update AGENTS.md with more stuff. (#14725)	2026-07-01 21:55:13 -04:00
kijai	6ecbaac853	ruff	2026-07-01 21:39:19 +03:00
kijai	2bbf53e8fc	Linting	2026-07-01 21:21:11 +03:00