Commit Graph

22 Commits

Author SHA1 Message Date
Claude
1bf3bfbdb3
Fix Docker build failures and workflow publish bug; remove SageAttention
- Dockerfile: fix glibc 2.41 patch path (cuda-12.9 -> cuda-12.8 to match
  installed packages); remove SAGE_ATTENTION_AVAILABLE env var
- sync-build-release.yml: add always() to publish job condition so it runs
  even when build-self is skipped (the primary GitHub runner path succeeds),
  fixing releases never being created on normal builds
- entrypoint.sh: remove SageAttention compilation and GPU detection logic;
  simplify to permissions setup, ComfyUI-Manager sync, custom node install,
  and launch
- README: update CUDA version references from 12.9/cu129 to 12.8/cu128;
  remove SageAttention documentation; fix docker-compose GPU syntax

https://claude.ai/code/session_01WQc56fWdK329K11kRGnb5g
2026-03-27 12:31:01 +00:00
clsferguson
b59e789284
fix(workflow): ensure Publish runs by marking build result unconditionally
The publish job was skipped because the build jobs never set their `built` output. A failed earlier step combined with job-level `continue-on-error` caused `success()` to evaluate false, so the “Mark build success” step did not run and outputs were empty. Removed job-level `continue-on-error` and replaced the marker step with an `always()`-gated step that derives `built` from `docker/build-push-action`’s `digest` output. Mirrored this in the self-hosted fallback. Kept `permissions: contents: write` for release creation. No functional changes elsewhere.
2025-10-10 21:37:58 -06:00
clsferguson
66bf02226a
Update sync-build-release.yml 2025-09-30 22:50:18 -06:00
clsferguson
36ebd94215
Update sync-build-release.yml 2025-09-30 22:49:27 -06:00
clsferguson
a719a6ad41
Update sync-build-release.yml 2025-09-30 22:42:54 -06:00
clsferguson
14e8bb4ef8
Update sync-build-release.yml 2025-09-30 22:41:26 -06:00
clsferguson
1169a1155d
Update sync-build-release.yml 2025-09-30 22:33:57 -06:00
clsferguson
6073804c99
Update sync-build-release.yml 2025-09-30 22:31:21 -06:00
clsferguson
3f8212cb2e
Update sync-build-release.yml 2025-09-30 22:28:44 -06:00
clsferguson
77ec7befa2
feat(ci): clean runners pre-build, GH-hosted first, self-hosted fallback, fail if both fail
- Add pre-build cleanup on GitHub-hosted runner using jlumbroso/free-disk-space plus Docker builder/system prune to maximize available disk for Docker builds.
- Add pre-build Docker cache pruning and disk checks on self-hosted runner to keep it minimal and appropriate for ephemeral runners.
- Change fallback logic to run self-hosted only if the GitHub-hosted build fails, using needs.<job>.result with always() to ensure the fallback job triggers after a primary failure.
- Keep GHCR login via docker/login-action@v3 and Buildx via docker/setup-buildx-action@v3; build with docker/build-push-action@v6.
- Publish release only if either build path succeeds; fail workflow if both builds or release publish fail.
- Remove post-build cleanup steps (BuildKit image removal and general pruning) to align with instruction not to worry about post cleanup on ephemeral runners.
2025-09-30 21:59:41 -06:00
clsferguson
249ff20e20
ci(sync): detect upstream release, sync master, build with GH fallback, and publish release
- Gate on new upstream release whose tag matches comfyui_version.py; skip if already released locally.
- Sync master from upstream (keep local README.md), then build and push image on GH runner with pre-clean; fallback to ephemeral self-hosted if GH build fails; publish release if either path succeeds.
- Remove unnecessary post-job cleanup since runners are ephemeral; rely on setup-buildx cleanup.
2025-09-30 15:07:11 -06:00
clsferguson
ab630fcca0
Add cleanup step in sync-build-release workflow 2025-09-12 20:36:26 -06:00
clsferguson
c7989867d7
Refactor upstream release check and cleanup steps 2025-09-12 20:34:49 -06:00
clsferguson
0d76dc1b18
Implement finalize job for workflow outcomes
Added a finalize job to handle outcomes based on upstream releases and publish results.
2025-09-12 10:56:16 -06:00
clsferguson
1da5dc48e6
Refactor CI workflow conditions and cleanup steps
Updated conditions for build and publish steps in CI workflow.
2025-09-12 10:47:02 -06:00
clsferguson
7b3b6fcbfd
Remove provenance and SBOM options from Docker builds 2025-09-10 22:53:05 -06:00
clsferguson
a8ada2ac01
Add latest Docker image pull command to release notes
Updated release notes to include latest Docker image pull command.
2025-09-10 21:50:14 -06:00
clsferguson
7decaccfcd
Add platform specification for Docker builds 2025-09-10 21:38:58 -06:00
clsferguson
a86c49b5ff
Refactor publish and finalize conditions in workflow
Updated conditions for publishing and finalizing outcomes in the CI workflow.
2025-09-10 21:05:46 -06:00
clsferguson
4b9b7ba771
Refactor sync-build-release workflow
Removed unnecessary cleanup steps and adjusted job names.
2025-09-09 23:02:38 -06:00
clsferguson
8538d95ce5
Refactor CI workflow for GitHub-hosted runners
Updated workflow to use GitHub-hosted runners and added cleanup steps for Docker images.
2025-09-09 22:27:46 -06:00
clsferguson
babceb30a5
Add sync and build workflow for Docker image
This workflow syncs the fork with the upstream repository and builds a Docker image on new releases.
2025-09-06 21:42:16 -06:00