Talmaj Marinc
26eb6bf777
Apply PR comments, reduce verbosity of docstrings, unify model and image/frame naming convention.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
da221da050
Refactor and rename nodes to from DepthAnyting3 to use DA3 naming convention.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
956f6b9950
Fix confidence use in DA3ToMesh by using normalization, fix extrisinc usage.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
724bb7b525
Fix extrinsic quaternions by normalizing them to unit quaternion.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
9f7dbb5bf6
Add DA3GeometryToMesh and DA3GeometryToPointCloud
2026-06-01 16:11:04 +02:00
Talmaj Marinc
b3b55fcb42
Improve and correct error logging for mono/multi-view.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
03aa1f2e5c
Improve tooltips.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
372ab13938
Fixup last few naming issues.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
875e0d5995
Revert support for DA3Geometry for MoGeRender.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
65e416fa2a
Move turbo to colormap.py and add it to DepthAnything3Render.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
554d0d1717
Refactor DepthAnything3 into DepthAnything3Inference and DepthAnything3Render.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
b006d69494
Refactor to a single socket ouptut for DA3 compatible with MoGeRender.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
2d6d0857ef
Add DA3ModelType to LoadDepthAnything3.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
96b2b6e30d
Improve tooltip for normalization.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
585bcad700
Apply some PR comments.
2026-06-01 16:11:04 +02:00
Talmaj
d132acbb0a
Fix DA3 model loader category.
...
Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>
2026-06-01 16:11:04 +02:00
Talmaj Marinc
00abdae8a8
Fix node loading from geometry_estimation folder.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
2064d190c4
Modify apply_sky_clip default to False.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
37479636cb
Fix no clamping when normalization is raw and refactor reusable code to _apply_sky_clip and _depth_to_image
2026-06-01 16:11:04 +02:00
Talmaj Marinc
bc19afd319
Make LoadDepthAnything3 look for models in geometry_estimation.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
c3db905288
Normalize confidence output.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
b5ecef3c47
Improve the toggles text.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
1ac1822c0a
Cleanup of comments.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
062750115e
Create a unified DepthAnything3 node.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
8ff8b10c45
Remove unused code.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
5568e15afb
Update DA3 to use dino2.get_intermediate_layers_da3
2026-06-01 16:11:04 +02:00
Talmaj Marinc
d5217129ef
Merge interpolate_pos_encoding method in dinov2
2026-06-01 16:11:04 +02:00
Talmaj Marinc
25ee627556
Fix ray_pose for non float32 dtypes CORE-135
2026-06-01 16:11:04 +02:00
Talmaj Marinc
3c47111bd4
Add support for pose estimation CORE-135.
2026-06-01 16:11:04 +02:00
Talmaj Marinc
1d5b6143e7
Refactor custom da dinov2 to image_encoders/dino2
2026-06-01 16:11:04 +02:00
Talmaj Marinc
a8c9ae9059
Modify upscaling to be closer to original CORE-135
2026-06-01 16:11:04 +02:00
Talmaj Marinc
137a05b93d
Initial commit CORE-135
2026-06-01 16:11:02 +02:00
Jukka Seppänen
462c27fdb2
feat: Add TripoSplat support ( #14210 )
2026-06-01 07:01:50 -07:00
comfyanonymous
70a2e1a851
Remove old portable updater migration code. ( #14202 )
...
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
* Remove old portable updater migration code.
This is 2 years old so I don't think it's needed anymore.
* Delete new_updater.py
2026-05-31 20:47:00 -07:00
Alexander Piskun
4f7882a7be
[Partner Nodes] feat: added grok-imagine-video-1.5 model to the GrokVideo node in First Frame mode ( #14198 )
2026-05-31 20:40:49 -07:00
Jukka Seppänen
c37d2a0dac
feat: Add gaussian splat nodes ( #14190 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-05-31 11:47:29 -07:00
savvadesogle
cd45f42a83
fix(multigpu): replace hardcoded torch.cuda.set_device with device-agnostic set_torch_device ( #14191 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Build package / Build Test (3.10) (push) Has been cancelled
Build package / Build Test (3.11) (push) Has been cancelled
Build package / Build Test (3.12) (push) Has been cancelled
Build package / Build Test (3.13) (push) Has been cancelled
Build package / Build Test (3.14) (push) Has been cancelled
Generate Pydantic Stubs from api.comfy.org / generate-models (push) Has been cancelled
2026-05-30 21:18:42 -04:00
comfyanonymous
81aa5a38b2
Speed up ernie model by a bit on nvidia and use higher quality rope. ( #14192 )
2026-05-30 17:53:37 -07:00
Daxiong (Lin)
ea73d3b2ea
chore: update embedded docs to v0.5.2 ( #14193 )
2026-05-31 07:49:59 +08:00
Terry Jia
08e93a31a3
feat: add Preview3DAdvanced node ( #14175 )
...
Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>
2026-05-30 17:57:36 -04:00
rattus
f7297bc5a9
Revert deprecation of non-dynamic smart memory (CORE-152 (revert)) ( #14183 )
...
* mm: re-instantate smart memory for VRAM
* mm: restore non-dynamic smart memory
By popular demand. We aren't quite ready for the deprecation as non
dynamic enabled GPUs and some high-vram custom model loader setups
prefer the old full hands on.
2026-05-30 15:20:33 -04:00
rattus
e154da83b1
Threaded Loader performance fixes / improvements (+ Aimdo 0.4.6) ( #14116 )
...
* memory_management: Add direct to read GPU mode
Make destination optional (or make it optionally GPU) and use aimdo
to file_read direct to GPU.
* ops: Remove stream pin buffers and use aimdo reads
This consumed too much RAM and its better to just take the hit on
the CPU syncing back the stream on a short ring buffer. Aimdo
implements this so just rip the stream pin buffer from comfy.
* model_management: all active pin registration movement
Its better to just let the active model load past the pin limit as
pins and let the pins move around. The saves the HDD and SATA
people disk traffic while only costing a few GPU syncs.
* utils: use aimdo file handle
This opens on windows with more favourable flags
* mp: only count the model proper for loaded_ram and vram
Exclude live loras from the numbers to avoid the case where the reported
loaded memory exceeds the size of the model.
This causes me confusion in the Kijai visualizer when it looked fully
loaded but was hitting disk due to this accounding disrepency.
* utils: add bit reverse utility
useful for max scattering something ordered.
* pinned_memory: Implement offload balancing
Use a max scatter alogorithm to prioritize pins of the same size such
that when doing a little bit of offloading it gets scattered, allowing
the prefetcher to more evenly swollow the offload.
* comfy-aimdo 0.4.7
Aimdo 0.4.7 implement VRAM buffer exhaustion predection to avoid
early speculative load of weights that definately wont fix once the
inference gets further in.
* model-prefetch: consolidate pin ensures on the sync point
This could happen mid prefetch block, cause a sync of the entire
block and lose overlap. Get ahead of the problem with a free down
at the natural compute stream sync point.
* mm: Put a 2GB min on the pin ceiling
This is reasonably bad if it starts causing swap pressure, moreso than
during normal ram-cache proceedings. Clamp it.
* add --fast-disk
2026-05-30 15:20:04 -04:00
Terry Jia
bb560036b9
feat(io): add File3DPLY / File3DSPLAT / File3DSPZ / File3DKSPLAT types ( #14185 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-05-30 09:39:26 -04:00
comfyanonymous
0b04660ba3
Speed up anima a bit on nvidia. ( #14181 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Build package / Build Test (3.10) (push) Waiting to run
Build package / Build Test (3.11) (push) Waiting to run
Build package / Build Test (3.12) (push) Waiting to run
Build package / Build Test (3.13) (push) Waiting to run
Build package / Build Test (3.14) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-05-29 22:47:10 -07:00
comfyanonymous
6e1ef2311b
Remove useless code. ( #14178 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-05-29 16:26:46 -07:00
Alexander Piskun
ec1896aceb
[Partner Nodes] feat: add new nodes for Tripo3D P1 model ( #14155 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-05-29 09:19:53 -07:00
Jukka Seppänen
54d5be4a8e
Fix background removal mask output shape ( #14171 )
2026-05-29 09:14:32 -07:00
Alexander Piskun
ea5b092576
[Partner Nodes] fix: removed "beta" models versions from Grok nodes ( #14170 )
2026-05-29 09:08:43 -07:00
Terry Jia
e7214d78ee
feat: add model_info output to Load3D node ( #14144 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Build package / Build Test (3.10) (push) Waiting to run
Build package / Build Test (3.11) (push) Waiting to run
Build package / Build Test (3.12) (push) Waiting to run
Build package / Build Test (3.13) (push) Waiting to run
Build package / Build Test (3.14) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-05-29 00:06:00 -07:00
Daxiong (Lin)
b10a61615c
chore: update workflow templates to v0.9.91 ( #14163 )
2026-05-28 22:42:17 -07:00
