Talmaj Marinc
343afeb6d0
Fix sweep deleting FAILED partials and fix segmented resume path trusted offsets blindly.
2026-07-13 00:24:37 +02:00
Talmaj Marinc
fe20a6483e
Add _positive_int in cli_args arguments.
2026-07-13 00:24:37 +02:00
Talmaj Marinc
e7b60beaf1
Redact urls in logging and fix concurrent enqueue issue that could corrupt the downloaded files.
2026-07-13 00:24:37 +02:00
Talmaj Marinc
ce237f9a79
Simplify docstrings.
2026-07-13 00:24:37 +02:00
Talmaj Marinc
1d79c41064
Normalize malformed safetensors headers into StructuralError.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
ccadcaf4e3
Prevent redirects to loopback/internal IPs (SSRF)
2026-07-13 00:24:36 +02:00
Talmaj Marinc
2fc66a5e8d
Simplify docstrings.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
15aa401146
Fix IPv4-mapped IPv6 addresses
2026-07-13 00:24:36 +02:00
Talmaj Marinc
4c152491f0
Restrict cleartext HTTP redirects to explicit loopback/dev hosts.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
72ce283d32
Simplify docstrings.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
bd27ae82a1
Don't echo full URLs and raw exception text from probe failures.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
9f9a9272ce
Simplify docstrings.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
a0b35f60be
Handle short pwrite() results.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
d0e71574a1
Switch to asyncio.to_thread for db calls in job.py
2026-07-13 00:24:36 +02:00
Talmaj Marinc
8a32df7108
Improve _finalize checks for downloads.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
03e6b57a86
Truncate file to 0 before restarting.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
391c628b8e
Add max-download-size in case the server tries to send larger files than it reports.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
790e6775da
Clear error when the job leaves a failure state.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
3b5483a225
Fix resuming of segmented download.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
d73483be0e
Simplify docstrings.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
acf8f95eb5
Fix potential concurrency and db integrity error.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
2bed0a5d73
Fix an issue when a credential is deleted, resuming of download fails.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
96a3e0ccad
Simplify docstrings.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
ea583ae155
Fix sercret_last4
2026-07-13 00:24:36 +02:00
Talmaj Marinc
cbb0ddd87e
Improve normalize_host
2026-07-13 00:24:36 +02:00
Talmaj Marinc
b107b834f2
Docstring simplification.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
53da5f94e6
Fix url parsing.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
cca6687a0a
Simplify migration docstring.
2026-07-13 00:24:36 +02:00
Talmaj Marinc
6f4c742bc5
Add initial commit for model downloader.
2026-07-13 00:24:36 +02:00
comfyanonymous
917faef771
Support PID 1.5 models. ( #14894 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-07-12 09:43:30 -07:00
Gustavo Schneiter
8b099de36a
Fix SaveVideo description: says images, saves video ( #14885 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Generate Pydantic Stubs from api.comfy.org / generate-models (push) Has been cancelled
2026-07-12 12:58:25 +08:00
comfyanonymous
69ea58697b
Try to fix flash attention related issue on AMD. ( #14880 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-07-11 17:16:40 -07:00
comfyanonymous
f3a36e7484
Temporarily disable auto enabling triton by default on AMD. ( #14878 )
...
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
I get freezing issues on my test machine.
2026-07-10 18:37:59 -07:00
comfyanonymous
92ddf07ba1
Try to fix some issues with the seedvr VAE. ( #14877 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-07-10 19:54:28 -04:00
Alexis Rolland
1f51e146a8
chore: Update preview nodes ( #14871 )
2026-07-10 19:32:53 -04:00
Alexis Rolland
5976ee37cd
Bringing back the text node ( #14870 )
2026-07-10 19:31:39 -04:00
Terry Jia
328144ce24
CORE-329 feat: add Save 3D (Advanced) node family ( #14701 )
2026-07-11 04:03:34 +08:00
Terry Jia
8310b0e0db
feat: add bboxes input to Create Bounding Boxes node ( #14724 )
2026-07-11 03:58:03 +08:00
Yousef R. Gamaleldin
94fa08223e
Save Text Node (CORE-176) ( #14102 )
2026-07-11 03:54:56 +08:00
liminfei-amd
1377a2f729
Only auto-enable the ROCm comfy-kitchen Triton backend on matrix-core GPUs ( #14869 )
...
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
#14862 auto-enables the comfy-kitchen Triton backend whenever torch.version.hip
is set and Triton >= 3.7. The INT8 matmul kernels compile tl.dot to matrix-core
instructions (WMMA on RDNA3+/gfx11xx-gfx12xx, MFMA on CDNA/gfx9xx); RDNA1/RDNA2
(gfx10xx) have neither, so the auto-enabled INT8 path hangs the GPU there
(reported on RDNA2 + triton-windows 3.7.1: native and custom-node INT8 freeze
until reset).
Gate the automatic ROCm default on GPU architecture as well as Triton version so
RDNA1/RDNA2 stay on the working eager fallback. Add --disable-triton-backend as
an explicit override; --enable-triton-backend still force-enables on any arch.
2026-07-10 03:31:20 -07:00
Alexander Piskun
206b9245dc
[Partner Nodes] fix(Tencent): restore Tencent3DPartNode FBX output via staged generation ( #14867 )
...
Signed-off-by: bigcat88 <bigcat88@icloud.com>
2026-07-10 12:33:32 +03:00
Alexander Piskun
89ecc5cf8c
[Partner Nodes] feat(Seedream): add widget to disable thinking ( #14853 )
...
Signed-off-by: bigcat88 <bigcat88@icloud.com>
Co-authored-by: Daxiong (Lin) <contact@comfyui-wiki.com>
2026-07-10 11:58:22 +03:00
John Pollock
8e2e54e2b8
Add SeedVR2 support (CORE-6) ( #14424 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Build package / Build Test (3.10) (push) Has been cancelled
Build package / Build Test (3.11) (push) Has been cancelled
Build package / Build Test (3.12) (push) Has been cancelled
Build package / Build Test (3.13) (push) Has been cancelled
Build package / Build Test (3.14) (push) Has been cancelled
2026-07-10 15:07:42 +08:00
comfyanonymous
e2a6e30d89
Fix black image on turing when using int4 models. ( #14864 )
2026-07-09 23:17:06 -04:00
liminfei-amd
099522f85b
Enable comfy-kitchen Triton backend by default on ROCm/AMD ( #14862 )
...
On AMD/ROCm the CUDA backend is unavailable, so Triton is the only accelerated
comfy-kitchen backend. It was disabled by default (opt-in --enable-triton-backend),
leaving AMD on the slow eager path. Enable it by default when torch.version.hip is
set AND Triton is >= 3.7 -- older Triton lacks libdevice.rint on the HIP backend and
hard-crashes the INT8 path, so on Triton < 3.7 it stays disabled with a log line.
NVIDIA behavior is unchanged; the explicit --enable-triton-backend flag still works
as an override.
Fixes #14861
2026-07-09 23:11:52 -04:00
liminfei-amd
62e025a4f3
Fix FP8 activation quantization for >2D activations in mixed_precision_ops ( #14643 )
...
mixed_precision_ops.Linear.forward only quantized activations that were 2D, or
3D (reshaped to 2D). Inputs with rank >= 4 (e.g. Anima's MLP activations, which
are not reshaped to 3D the way the attention path is) fell through the
`input_reshaped.ndim == 2` guard and reached scaled_mm as bf16, silently
dispatching a bf16 kernel instead of FP8. Since MLP is roughly half the compute,
the FP8 speedup was far below expectation.
Generalize the existing 3D->2D reshape to any rank >= 3 (flatten the leading
dims, keep the contraction dim) and reshape the output back to the original
leading dims. 2D and 3D inputs are handled exactly as before; only rank >= 4
inputs change (now quantized instead of skipped). This matches the rank-agnostic
handling already used by the training path (flatten(0, -2) / unflatten).
Fixes #14595 .
2026-07-09 22:30:26 -04:00
comfyanonymous
b7a648ca20
Try to fix the model reloading issue some people have. ( #14822 )
Detect Unreviewed Merge / detect (push) Waiting to run
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Build package / Build Test (3.10) (push) Waiting to run
Build package / Build Test (3.11) (push) Waiting to run
Build package / Build Test (3.12) (push) Waiting to run
Build package / Build Test (3.13) (push) Waiting to run
Build package / Build Test (3.14) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-07-09 16:39:01 -07:00
comfyanonymous
73e84d5ec8
Support convrot int4 models. ( #14859 )
...
linear_dtype in comfy_quant metadata can be used to set if the int4 op does
the matrix multiplication in int8 or int4, the default is int4 on GPUs that
support it with fallback to int8 for GPUs that don't.
2026-07-09 18:57:09 -04:00
Alexis Rolland
1ea724339c
Update cla.yml ( #14851 )
2026-07-09 17:57:44 -04:00
Simon Pinfold
412aaab0e2
feat(api): expose registered extension filters on /experiment/models ( #14797 )
...
Each folder in the listing now carries its registered extension
allowlist verbatim; an empty array means the folder accepts any
extension (match-all), mirroring filter_files_extensions semantics.
Gives consumers the filtering rule itself rather than just its output:
/models/{folder} lists files by the per-folder rule but the rule is not
exposed anywhere, and /experiment/models/{folder} filters everything by
the global supported_pt_extensions regardless of registration.
Presentation-level filtering of match-all folders (e.g. hiding
README/config noise that repository-downloading custom nodes leave in
model directories) is deliberately left to the consumer.
Co-authored-by: guill <jacob.e.segal@gmail.com>
2026-07-09 12:59:30 -07:00