4796 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Luke Mino-Altherr	8711e42dd3	fix: ruff linting errors and add comprehensive test coverage for asset queries ... - Fix unused imports in routes.py, asset.py, manager.py, asset_management.py, ingest.py - Fix whitespace issues in upload.py, asset_info.py, ingest.py - Fix typo in manager.py (stray character after result["asset"]) - Fix broken import in test_metadata.py (project_kv moved to asset_info.py) - Add fixture override in queries/conftest.py for unit test isolation Add 48 new tests covering all previously untested query functions: - asset.py: upsert_asset, bulk_insert_assets - cache_state.py: upsert_cache_state, delete_cache_states_outside_prefixes, get_orphaned_seed_asset_ids, delete_assets_by_ids, get_cache_states_for_prefixes, bulk_set_needs_verify, delete_cache_states_by_ids, delete_orphaned_seed_asset, bulk_insert_cache_states_ignore_conflicts, get_cache_states_by_paths_and_asset_ids - asset_info.py: insert_asset_info, get_or_create_asset_info, update_asset_info_timestamps, replace_asset_info_metadata_projection, bulk_insert_asset_infos_ignore_conflicts, get_asset_info_ids_by_ids - tags.py: bulk_insert_tags_and_meta Total: 119 tests pass (up from 71) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-02-24 11:34:44 -08:00
Luke Mino-Altherr	2780b6cd57	refactor: extract multipart upload parsing from routes ... - Add app/assets/api/upload.py with parse_multipart_upload() for HTTP parsing - Add ParsedUpload dataclass to schemas_in.py - Add domain exceptions (AssetValidationError, AssetNotFoundError, HashMismatchError) - Add manager.process_upload() with domain exceptions (no HTTP status codes) - Routes map domain exceptions to HTTP responses - Slim down upload_asset route to ~20 lines (was ~150) Amp-Thread-ID: https://ampcode.com/threads/T-019c2519-abe1-738a-ad2e-29ece17c0e42 Co-authored-by: Amp <amp@ampcode.com>	2026-02-24 11:34:44 -08:00
Luke Mino-Altherr	69b3fef327	Move get_comfy_models_folders to path_utils.py to avoid late import ... Amp-Thread-ID: https://ampcode.com/threads/T-019c2510-33fa-7199-ae4b-bc31102277a7 Co-authored-by: Amp <amp@ampcode.com>	2026-02-24 11:34:43 -08:00
Luke Mino-Altherr	bd1d13ebe6	Refactor helpers.py: move functions to their respective modules ... - Move scanner-only functions to scanner.py - Move query-only functions (is_scalar, project_kv) to asset_info.py - Move get_query_dict to routes.py - Create path_utils.py service for path-related functions - Reduce helpers.py to shared utilities only Amp-Thread-ID: https://ampcode.com/threads/T-019c2510-33fa-7199-ae4b-bc31102277a7 Co-authored-by: Amp <amp@ampcode.com>	2026-02-24 11:34:43 -08:00
Luke Mino-Altherr	21e746d836	Move hashing.py to services directory ... Amp-Thread-ID: https://ampcode.com/threads/T-019c2510-33fa-7199-ae4b-bc31102277a7 Co-authored-by: Amp <amp@ampcode.com>	2026-02-24 11:34:43 -08:00
Luke Mino-Altherr	bf6e85bc01	refactor: move bulk_ops to queries and scanner service ... - Delete bulk_ops.py, moving logic to appropriate layers - Add bulk insert query functions: - queries/asset.bulk_insert_assets - queries/cache_state.bulk_insert_cache_states_ignore_conflicts - queries/cache_state.get_cache_states_by_paths_and_asset_ids - queries/asset_info.bulk_insert_asset_infos_ignore_conflicts - queries/asset_info.get_asset_info_ids_by_ids - queries/tags.bulk_insert_tags_and_meta - Move seed_from_paths_batch orchestration to scanner._seed_from_paths_batch Amp-Thread-ID: https://ampcode.com/threads/T-019c24fd-157d-776a-ad24-4f19cf5d3afe Co-authored-by: Amp <amp@ampcode.com>	2026-02-24 11:34:43 -08:00
Luke Mino-Altherr	5b4726e01f	refactor: move scanner to services layer with pure query extraction ... - Move app/assets/scanner.py to app/assets/services/scanner.py - Extract pure queries from fast_db_consistency_pass: - get_cache_states_for_prefixes() - bulk_set_needs_verify() - delete_cache_states_by_ids() - delete_orphaned_seed_asset() - Split prune_orphaned_assets into pure queries: - delete_cache_states_outside_prefixes() - get_orphaned_seed_asset_ids() - delete_assets_by_ids() - Add reconcile_cache_states_for_root() service function - Add prune_orphaned_assets() service function - Remove function injection pattern - Update imports in main.py, server.py, routes.py Amp-Thread-ID: https://ampcode.com/threads/T-019c24f1-3385-701b-87e0-8b6bc87e841b Co-authored-by: Amp <amp@ampcode.com>	2026-02-24 11:34:43 -08:00
Luke Mino-Altherr	77be514cd9	refactor: move in-function imports to top-level and remove keyword-only argument pattern ... - Move imports from inside functions to module top-level in: - app/assets/database/queries/asset.py - app/assets/database/queries/asset_info.py - app/assets/database/queries/cache_state.py - app/assets/manager.py - app/assets/services/asset_management.py - app/assets/services/ingest.py - Remove keyword-only argument markers (*,) from app/assets/ to match codebase conventions Amp-Thread-ID: https://ampcode.com/threads/T-019c24eb-bfa2-727f-8212-8bc976048604 Co-authored-by: Amp <amp@ampcode.com>	2026-02-24 11:34:43 -08:00
Luke Mino-Altherr	7dd0cac0c9	Refactor asset database: separate business logic from queries ... Architecture changes: - API Routes -> manager.py (thin adapter) -> services/ (business logic) -> queries/ (atomic DB ops) - Services own session lifecycle via create_session() - Queries accept Session as parameter, do single-table atomic operations New app/assets/services/ layer: - __init__.py - exports all service functions - ingest.py - ingest_file_from_path(), register_existing_asset() - asset_management.py - get_asset_detail(), update_asset_metadata(), delete_asset_reference(), set_asset_preview() - tagging.py - apply_tags(), remove_tags(), list_tags() Removed from queries/asset_info.py: - ingest_fs_asset (moved to services/ingest.py as ingest_file_from_path) - update_asset_info_full (moved to services/asset_management.py as update_asset_metadata) - create_asset_info_for_existing_asset (moved to services/ingest.py as register_existing_asset) Updated manager.py: - Now a thin adapter that transforms API schemas to/from service calls - Delegates all business logic to services layer - No longer imports sqlalchemy.orm.Session or models directly Test updates: - Fixed test_cache_state.py import of pick_best_live_path (moved to helpers.py) - Added comprehensive service layer tests (41 new tests) - All 112 query + service tests pass Amp-Thread-ID: https://ampcode.com/threads/T-019c24e2-7ae4-707f-ad19-c775ed8b82b5 Co-authored-by: Amp <amp@ampcode.com>	2026-02-24 11:34:43 -08:00
Luke Mino-Altherr	45ce576777	chore: remove unused Asset import from manager.py ... Amp-Thread-ID: https://ampcode.com/threads/T-019c24bb-475b-7442-9ff9-8288edea3345 Co-authored-by: Amp <amp@ampcode.com>	2026-02-24 11:34:43 -08:00
Luke Mino-Altherr	1cc688db18	refactor(assets): split queries.py into modular query modules ... Split the ~1000 line app/assets/database/queries.py into focused modules: - queries/asset.py - Asset entity queries (asset_exists_by_hash, get_asset_by_hash) - queries/asset_info.py - AssetInfo queries (~15 functions) - queries/cache_state.py - AssetCacheState queries (list_cache_states_by_asset_id, pick_best_live_path, prune_orphaned_assets, fast_db_consistency_pass) - queries/tags.py - Tag queries (8 functions including ensure_tags_exist, add/remove tag functions, list_tags_with_usage) - queries/__init__.py - Re-exports all public functions for backward compatibility Also adds comprehensive unit tests using in-memory SQLite: - tests-unit/assets_test/queries/conftest.py - Session fixture - tests-unit/assets_test/queries/test_asset.py - 5 tests - tests-unit/assets_test/queries/test_asset_info.py - 23 tests - tests-unit/assets_test/queries/test_cache_state.py - 8 tests - tests-unit/assets_test/queries/test_metadata.py - 12 tests for _apply_metadata_filter - tests-unit/assets_test/queries/test_tags.py - 23 tests All 71 unit tests pass. Existing integration tests unaffected. Amp-Thread-ID: https://ampcode.com/threads/T-019c24bb-475b-7442-9ff9-8288edea3345 Co-authored-by: Amp <amp@ampcode.com>	2026-02-24 11:34:43 -08:00
comfyanonymous	b874bd2b8c	ComfyUI v0.15.0	2026-02-24 12:42:15 -05:00
ComfyUI Wiki	0aa02453bb	chore: update embedded docs to v0.4.3 (#12601)	2026-02-24 12:41:36 -05:00
comfyanonymous	599f9c5010	Don't crash right away if op is uninitialized. (#12615)	2026-02-24 12:28:25 -05:00
ComfyUI Wiki	11fefa58e9	chore: update workflow templates to v0.9.3 (#12610)	2026-02-24 09:04:51 -08:00
Alexander Piskun	d8090013b8	feat(api-nodes): add ByteDance Seedream-5 model (#12609) ... * feat(api-nodes): add ByteDance Seedream-5 model * made error message more correct * rename seedream 5.0 model	2026-02-24 09:03:30 -08:00
Christian Byrne	048dd2f321	Patch frontend to 1.39.16 (from 1.39.14) (#12604) ... * Update requirements.txt * Update requirements.txt --------- Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>	2026-02-24 00:44:40 -08:00
comfyanonymous	84aba95e03	Temporality unbreak some LTXAV workflows to give people time to migrate. (#12605)	2026-02-24 00:50:03 -05:00
comfyanonymous	9b1c63eb69	Add SplitImageToTileList and ImageMergeTileList nodes. (#12599) ... With these you can split an image into tiles, do operations and then combine it back to a single image.	2026-02-23 21:01:17 -05:00
ComfyUI Wiki	7a7debcaf1	chore: update workflow templates to v0.9.2 (#12596)	2026-02-23 18:27:20 -05:00
Alexander Piskun	dba2766e53	feat(api-nodes): add KlingAvatar node (#12591)	2026-02-23 11:27:16 -08:00
comfyanonymous	caa43d2395	Fix issue loading fp8 ltxav checkpoints. (#12582)	2026-02-22 16:00:02 -05:00
comfyanonymous	07ca6852e8	Fix dtype issue in embeddings connector. (#12570)	2026-02-22 03:18:20 -05:00
comfyanonymous	f266b8d352	Move LTXAV av embedding connectors to diffusion model. (#12569)	2026-02-21 22:29:58 -05:00
Christian Byrne	b6cb30bab5	chore: tune CodeRabbit config to limit review scope and disable for drafts (#12567) ... * chore: tune CodeRabbit config to limit review scope and disable for drafts - Add tone_instructions to focus only on newly introduced issues - Add global path_instructions entry to ignore pre-existing issues in moved/reformatted code - Disable draft PR reviews (drafts: false) and add WIP title keywords - Disable ruff tool to prevent linter-based outside-diff-range comments Addresses feedback from maintainers about CodeRabbit flagging pre-existing issues in code that was merely moved or de-indented (e.g., PR #12557), which can discourage community contributions and cause scope creep. Amp-Thread-ID: https://ampcode.com/threads/T-019c82de-0481-7253-ad42-20cb595bb1ba * chore: add 'DO NOT MERGE' to ignore_title_keywords Amp-Thread-ID: https://ampcode.com/threads/T-019c82de-0481-7253-ad42-20cb595bb1ba	2026-02-21 18:32:15 -08:00
Christian Byrne	ee72752162	Add category to Normalized Attention Guidance node (#12565)	2026-02-21 19:51:21 -05:00
Alexander Brown	7591d781a7	fix: specify UTF-8 encoding when reading subgraph files (#12563) ... On Windows, Python defaults to cp1252 encoding when no encoding is specified. JSON files containing UTF-8 characters (e.g., non-ASCII characters) cause UnicodeDecodeError when read with cp1252. This fixes the error that occurs when loading blueprint subgraphs on Windows systems. https://claude.ai/code/session_014WHi3SL9Gzsi3U6kbSjbSb Co-authored-by: Claude <noreply@anthropic.com>	2026-02-21 15:05:00 -08:00
rattus	0bfb936ab4	comfy-aimdo 0.2 - Improved pytorch allocator integration (#12557) ... Integrate comfy-aimdo 0.2 which takes a different approach to installing the memory allocator hook. Instead of using the complicated and buggy pytorch MemPool+CudaPluggableAlloctor, cuda is directly hooked making the process much more transparent to both comfy and pytorch. As far as pytorch knows, aimdo doesnt exist anymore, and just operates behind the scenes. Remove all the mempool setup stuff for dynamic_vram and bump the comfy-aimdo version. Remove the allocator object from memory_management and demote its use as an enablment check to a boolean flag. Comfy-aimdo 0.2 also support the pytorch cuda async allocator, so remove the dynamic_vram based force disablement of cuda_malloc and just go back to the old settings of allocators based on command line input.	2026-02-21 10:52:57 -08:00
pythongosssss	602b2505a4	add support for pyopengl < 3.1.4 where the size parameter does not exist (#12555)	2026-02-21 06:14:57 -08:00
Christian Byrne	04a55d5019	fix: swap essentials_category from CLIPTextEncode to PrimitiveStringMultiline (#12553) ... Remove CLIPTextEncode from Basics essentials category and add PrimitiveStringMultiline (String Multiline) in its place. Amp-Thread-ID: https://ampcode.com/threads/T-019c7efb-d916-7244-8c43-77b615ba0622 Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>	2026-02-20 23:46:46 -08:00
Christian Byrne	5fb8f06495	feat: add essential subgraph blueprints (#12552) ... Add 24 non-cloud essential blueprints from comfyui-wiki/Subgraph-Blueprints. These cover common workflows: text/image/video generation, editing, inpainting, outpainting, upscaling, depth maps, pose, captioning, and more. Cloud-only blueprints (5) are excluded and will be added once client-side distribution filtering lands. Amp-Thread-ID: https://ampcode.com/threads/T-019c6f43-6212-7308-bea6-bfc35a486cbf	2026-02-20 23:40:13 -08:00
Terry Jia	5a182bfaf1	update glsl blueprint with gradient (#12548) ... Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>	2026-02-20 23:02:36 -08:00
Terry Jia	f394af8d0f	feat: add gradient-slider display mode for FLOAT inputs (#12536) ... * feat: add gradient-slider display mode for FLOAT inputs * fix: use precise type annotation list[list[float]] for gradient_stops Amp-Thread-ID: https://ampcode.com/threads/T-019c7eea-be2b-72ce-a51f-838376f9b7a7 --------- Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com> Co-authored-by: bymyself <cbyrne@comfy.org>	2026-02-20 22:52:32 -08:00
Arthur R Longbottom	aeb5bdc8f6	Fix non-contiguous audio waveform crash in video save (#12550) ... Fixes #12549	2026-02-20 23:37:55 -05:00
comfyanonymous	64953bda0a	Update nightly installation command for ROCm (#12547)	2026-02-20 21:32:05 -05:00
Christian Byrne	b254cecd03	chore: add CodeRabbit configuration for automated code review (#12539) ... Amp-Thread-ID: https://ampcode.com/threads/T-019c7915-2abf-743c-9c74-b93d87d63055 Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>	2026-02-20 00:25:54 -08:00
Alexander Piskun	1bb956fb66	[API Nodes] add ElevenLabs nodes (#12207) ... * feat(api-nodes): add ElevenLabs API nodes * added price badge for ElevenLabsInstantVoiceClone node --------- Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>	2026-02-19 22:12:28 -08:00
pythongosssss	96d6bd1a4a	Add GLSL shader node using PyOpenGL (#12148) ... * adds support for executing simple glsl shaders using moderngl package * tidy * Support multiple outputs * Try fix build * fix casing * fix line endings * convert to using PyOpenGL and glfw * remove cpu support * tidy * add additional support for egl & osmesa backends * fix ci perf: only read required outputs * add diagnostics, update mac initialization * GLSL glueprints + node fixes (#12492) * Add image operation blueprints * Add channels * Add glow * brightness/contrast * hsb * add glsl shader update system * shader nit iteration * add multipass for faster blur * more fixes * rebuild blueprints * print -> logger * Add edge preserving blur * fix: move _initialized flag to end of GLContext.__init__ Prevents '_vao' attribute error when init fails partway through and subsequent calls skip initialization due to early _initialized flag. * update valid ranges - threshold 0-100 - step 0+ * fix value ranges * rebuild node to remove extra inputs * Fix gamma step * clamp saturation in colorize instead of wrapping * Fix crash on 1x1 px images * rework description * remove unnecessary f Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com> Co-authored-by: Hunter Senft-Grupp <hunter@comfy.org>	2026-02-19 23:22:13 -05:00
comfyanonymous	5f2117528a	Force min length 1 when tokenizing for text generation. (#12538)	2026-02-19 22:57:44 -05:00
comfyanonymous	0301ccf745	Small cleanup and try to get qwen 3 work with the text gen. (#12537)	2026-02-19 22:42:28 -05:00
Christian Byrne	4d172e9ad7	feat: mark 429 widgets as advanced for collapsible UI (#12197) ... * feat: mark 429 widgets as advanced for collapsible UI Mark widgets as advanced across core, comfy_extras, and comfy_api_nodes to support the new collapsible advanced inputs section in the frontend. Changes: - 267 advanced markers in comfy_extras/ - 162 advanced markers in comfy_api_nodes/ - All files pass python3 -m py_compile verification Widgets marked advanced (hidden by default): - Scheduler internals: sigma_max, sigma_min, rho, mu, beta, alpha - Sampler internals: eta, s_noise, order, rtol, atol, h_init, pcoeff, etc. - Memory optimization: tile_size, overlap, temporal_size, temporal_overlap - Pipeline controls: add_noise, start_at_step, end_at_step - Timing controls: start_percent, end_percent - Layer selection: stop_at_clip_layer, layers, block_number - Video encoding: codec, crf, format - Device/dtype: device, noise_device, dtype, weight_dtype Widgets kept basic (always visible): - Core params: strength, steps, cfg, denoise, seed, width, height - Model selectors: ckpt_name, lora_name, vae_name, sampler_name - Common controls: upscale_method, crop, batch_size, fps, opacity Related: frontend PR #11939 Amp-Thread-ID: https://ampcode.com/threads/T-019c1734-6b61-702e-b333-f02c399963fc * fix: remove advanced=True from DynamicCombo.Input (unsupported) Amp-Thread-ID: https://ampcode.com/threads/T-019c1734-6b61-702e-b333-f02c399963fc * fix: address review - un-mark model merge, video, image, and training node widgets as advanced Per comfyanonymous review: - Model merge arguments should not be advanced (all 14 model-specific merge classes) - SaveAnimatedWEBP lossless/quality/method should not be advanced - SaveWEBM/SaveVideo codec/crf/format should not be advanced - TrainLoraNode options should not be advanced (7 inputs) Amp-Thread-ID: https://ampcode.com/threads/T-019c322b-a3a8-71b7-9962-d44573ca6352 * fix: un-mark batch_size and webcam width/height as advanced (should stay basic) Amp-Thread-ID: https://ampcode.com/threads/T-019c3236-1417-74aa-82a3-bcb365fbe9d1 --------- Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>	2026-02-19 19:20:02 -08:00
Yourz	5632b2df9d	feat: add essentials_category (#12357) ... * feat: add essentials_category field to node schema Amp-Thread-ID: https://ampcode.com/threads/T-019c2b25-cd90-7218-9071-03cb46b351b3 * feat: add ESSENTIALS_CATEGORY to core nodes Marked nodes: - Basic: LoadImage, SaveImage, LoadVideo, SaveVideo, Load3D, CLIPTextEncode - Image Tools: ImageScale, ImageInvert, ImageBatch, ImageCrop, ImageRotate, ImageBlur - Image Tools/Preprocessing: Canny - Image Generation: LoraLoader - Audio: LoadAudio, SaveAudio Amp-Thread-ID: https://ampcode.com/threads/T-019c2b25-cd90-7218-9071-03cb46b351b3 * Add ESSENTIALS_CATEGORY to more nodes - SaveGLB (Basic) - GetVideoComponents (Video Tools) - TencentTextToModelNode, TencentImageToModelNode (3D) - RecraftRemoveBackgroundNode (Image Tools) - KlingLipSyncAudioToVideoNode (Video Generation) - OpenAIChatNode (Text Generation) - StabilityTextToAudio (Audio) Amp-Thread-ID: https://ampcode.com/threads/T-019c2b69-81c1-71c3-8096-450a39e20910 * fix: correct essentials category for Canny node Amp-Thread-ID: https://ampcode.com/threads/T-019c7303-ab53-7341-be76-a5da1f7a657e Co-authored-by: Amp <amp@ampcode.com> * refactor: replace essentials_category string literals with constants Amp-Thread-ID: https://ampcode.com/threads/T-019c7303-ab53-7341-be76-a5da1f7a657e Co-authored-by: Amp <amp@ampcode.com> * refactor: revert constants, use string literals for essentials_category Amp-Thread-ID: https://ampcode.com/threads/T-019c7303-ab53-7341-be76-a5da1f7a657e Co-authored-by: Amp <amp@ampcode.com> * fix: update basics --------- Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>	2026-02-19 19:00:26 -08:00
Alexander Piskun	2687652530	fix(api-nodes): force Gemini to return uncompressed images (#12516)	2026-02-19 04:10:39 -08:00
Jukka Seppänen	6d11cc7354	feat: Add basic text generation support with native models, initially supporting Gemma3 (#12392)	2026-02-18 20:49:43 -05:00
comfyanonymous	f262444dd4	Add simple 3 band equalizer node for audio. (#12519)	2026-02-18 18:36:35 -05:00
Alexander Piskun	239ddd3327	fix(api-nodes): add price badge for Rodin Gen-2 node (#12512)	2026-02-17 23:15:23 -08:00
Hunter	83dd65f23a	fix: use glob matching for Gemini image MIME types (#12511) ... gemini-3-pro-image-preview nondeterministically returns image/jpeg instead of image/png. get_image_from_response() hardcoded get_parts_by_type(response, "image/png"), silently dropping JPEG responses and falling back to torch.zeros (all-black output). Add _mime_matches() helper using fnmatch for glob-style MIME matching. Change get_image_from_response() to request "image/*" so any image format returned by the API is correctly captured.	2026-02-18 00:03:54 -05:00
Terry Jia	8ad38d2073	BBox widget (#11594) ... * Boundingbox widget * code improve --------- Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org>	2026-02-17 17:13:39 -08:00
Comfy Org PR Bot	6c14f129af	Bump comfyui-frontend-package to 1.39.14 (#12494) ... * Bump comfyui-frontend-package to 1.39.13 * Update requirements.txt --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org>	2026-02-17 13:41:34 -08:00
rattus	58dcc97dcf	ops: limit return of requants (#12506) ... This check was far too broad and the dtype is not a reliable indicator of wanting the requant (as QT returns the compute dtype as the dtype). So explictly plumb whether fp8mm wants the requant or not.	2026-02-17 15:32:27 -05:00