5565 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
John Pollock	a01fd3f0ec	Merge 76719afe7c into 439bd807f8	2026-07-06 17:53:26 -04:00
comfyanonymous	439bd807f8	Skip unloading dynamic model patchers in current workflow. (#14799)	2026-07-06 14:35:12 -07:00
Daxiong (Lin)	b08debceca	chore: update embedded docs to v0.5.7 (#14783)	2026-07-06 09:56:09 +08:00
comfyanonymous	000c6b784e	Small speedup for text model sampling. (#14773)	2026-07-05 18:39:24 -07:00
comfyanonymous	76719afe7c	Fix test.	2026-07-05 16:28:59 -04:00
Alexander Piskun	985fb9d6ad	[Partner Nodes] fix(logs-auth): mask authorization headers in logs (#14774) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-05 13:55:29 +03:00
Alexis Rolland	7f287b705e	fix: Bug when setting transparency in color picker (#14764)	2026-07-04 19:13:38 -04:00
comfyanonymous	b7ba504e06	Try to make coderabbit enforce AGENTS.md (#14759)	2026-07-04 14:25:24 -04:00
John Pollock	093d17c587	Add SeedVR2 temporal chunk and merge nodes ... ## Summary Sampling a long SeedVR2 video in one pass runs out of VRAM: the DiT working set grows linearly with latent frames times pixel area, so a 100 frame clip at 4x upscale needs more memory than any consumer card has. This PR adds two workflow-level nodes that split the latent into overlapping temporal chunks and recombine the sampled chunks with a Hann crossfade. The executor's list handling runs the stock KSampler once per chunk, so the sampler itself is untouched. - **Chunk SeedVR2 Latent** splits the latent on the temporal axis. `frames_per_chunk` is in pixel frames on the 4n+1 grid, `temporal_overlap` sets how many latent frames adjacent chunks share, and `chunking_mode=auto` solves the chunk size from measured free VRAM and the latent's own dimensions. The node outputs the effective overlap so the merge is wired, not typed. - **Merge SeedVR2 Latent Chunks** recombines the sampled chunks in order, crossfading each shared region with a Hann window (flat shoulders on the outer thirds, fade across the middle third). Zero overlap is a plain concatenation, bit-identical to `torch.cat`. ## Changes - Added 2 nodes and 1 crossfade helper to `comfy_extras/nodes_seedvr.py` (+201 lines). - Added 4 chunk-law constants to `comfy/ldm/seedvr/constants.py` (+10 lines). - Added pytest unit tests in `tests-unit/comfy_extras_test/test_seedvr2_temporal_chunk.py` (+66 lines): chunk geometry, 4n+1 and mode validation, overlap clamping, temporal noise mask slicing (5-D and 4-D), the auto law including batch scaling, crossfade weights and blend direction, round trip, and metadata handling. Everything outside the two new nodes is byte-identical to the base branch. The new constants are read only by the chunk node, and workflows that do not use these nodes take no new code path. ## Auto mode calibration The auto law is `max_latent_frames = (free_GiB - reserved - margin) / (0.30 * megapixels)`, calibrated on an RTX 5090 (32 GB) with the 3b fp16 model: a 17-cell resolution sweep plus temporal bisection located the activation wall and confirmed it is linear in latent frames times pixel area (the same total-voxel budget holds from 1.5:1 through 24:1 aspect ratios and under transposition). The margin is four standard deviations of the measured run-to-run spread, which costs about one latent frame of chunk size and makes an out-of-memory failure a lottery ticket rather than a coin flip. Manual mode bypasses the law entirely. On a 32 GB card, a 640x480x100 input at 4x upscale sampled as a single chunk allocates past 31 GiB and dies; auto mode picks 49 frame chunks (three chunks with overlap) and the full pipeline completes in about 240 seconds. The same law stands down on small inputs: a 320x240x100 clip runs as a single chunk because it fits. ## Example workflow Load a video, 4x upscale, auto chunking, temporal overlap 3. Expected output for a 640x480x100 input: 2560x1920, 100 frames, seams invisible at the default overlap. <details> <summary>API workflow JSON</summary> ```json { "14": {"inputs": {"vae_name": "ema_vae_fp16.safetensors"}, "class_type": "VAELoader"}, "17": {"inputs": {"video": ["24", 0]}, "class_type": "GetVideoComponents"}, "20": {"inputs": {"fps": ["17", 2], "images": ["30", 0], "audio": ["17", 1]}, "class_type": "CreateVideo"}, "21": {"inputs": {"tile_size": 192, "overlap": 64, "temporal_size": 64, "temporal_overlap": 8, "pixels": ["27", 0], "vae": ["14", 0]}, "class_type": "VAEEncodeTiled"}, "22": {"inputs": {"tile_size": 256, "overlap": 32, "temporal_size": 64, "temporal_overlap": 8, "samples": ["33", 0], "vae": ["14", 0]}, "class_type": "VAEDecodeTiled"}, "23": {"inputs": {"unet_name": "seedvr2_3b_fp16.safetensors", "weight_dtype": "default"}, "class_type": "UNETLoader"}, "24": {"inputs": {"file": "input.mp4", "video-preview": ""}, "class_type": "LoadVideo"}, "25": {"inputs": {"filename_prefix": "video/seedvr2_upscale", "format": "auto", "codec": "auto", "video": ["20", 0]}, "class_type": "SaveVideo"}, "26": {"inputs": {"resize_type": "scale by multiplier", "resize_type.multiplier": 4, "scale_method": "bicubic", "input": ["17", 0]}, "class_type": "ResizeImageMaskNode"}, "27": {"inputs": {"resized_images": ["26", 0]}, "class_type": "SeedVR2Preprocess"}, "28": {"inputs": {"model": ["23", 0], "vae_conditioning": ["32", 0]}, "class_type": "SeedVR2Conditioning"}, "29": {"inputs": {"seed": 5770521, "steps": 1, "cfg": 1, "sampler_name": "euler", "scheduler": "simple", "denoise": 1, "model": ["23", 0], "positive": ["28", 0], "negative": ["28", 1], "latent_image": ["32", 0]}, "class_type": "KSampler"}, "30": {"inputs": {"color_correction_method": "lab", "images": ["22", 0], "original_resized_images": ["26", 0]}, "class_type": "SeedVR2PostProcessing"}, "32": {"inputs": {"frames_per_chunk": 21, "temporal_overlap": 3, "chunking_mode": "auto", "latent": ["21", 0]}, "class_type": "SeedVR2TemporalChunk"}, "33": {"inputs": {"temporal_overlap": ["32", 1], "latent_chunks": ["29", 0]}, "class_type": "SeedVR2TemporalMerge"} } ``` </details> ## Prior art - Reference implementation: https://github.com/ByteDance-Seed/SeedVR - Community precedent for temporal chunking with blended reassembly: https://github.com/numz/ComfyUI-SeedVR2_VideoUpscaler Chunk boundaries are a mathematical compromise: the model attends within a chunk, so different chunkings produce different outputs. The overlap crossfade hides the seam; power users can widen or zero the overlap from the workflow.	2026-07-04 13:05:19 -05:00
Silver	6c62ca0b6b	fix: error when embedding is loaded with models using llama_template (#14744)	2026-07-04 17:06:09 +08:00
Robin Huang	3fe9f5fecb	Add CLAUDE.md as symlink to AGENTS.md (#14757)	2026-07-04 13:12:47 +08:00
comfyanonymous	62001efd4f	Update comfy_extras/nodes_seedvr.py ... Co-authored-by: Alexis Rolland <alexis@comfy.org>	2026-07-03 19:01:25 -07:00
comfyanonymous	d8506849f1	Update comfy_extras/nodes_seedvr.py ... Co-authored-by: Alexis Rolland <alexis@comfy.org>	2026-07-03 19:01:15 -07:00
comfyanonymous	06dc642763	Update comfy_extras/nodes_seedvr.py ... Co-authored-by: Alexis Rolland <alexis@comfy.org>	2026-07-03 19:01:02 -07:00
comfyanonymous	cb16da18f9	Fix nvfp4 model detection.	2026-07-03 19:00:04 -07:00
Alexander Piskun	1073a74976	[Partner Nodes] chore(ByteDance): adjust category name (#14752) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-04 00:01:05 +03:00
comfyanonymous	de1b8f3e8d	Update AGENTS.md (#14738)	2026-07-03 13:08:24 -07:00
Alexander Piskun	77917ed3a6	[Partner Nodes] chore(StabilityAI): remove StabilityAI nodes (#14737) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-03 14:24:21 +03:00
Daxiong (Lin)	a04ebe05c2	chore: update workflow templates to v0.11.2 (#14741)	2026-07-03 19:08:11 +08:00
Alexander Piskun	9764381998	[Partner Nodes] feat(ByteDance): add support for Seed Audio 1.0 (#14731) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-03 14:00:10 +03:00
comfyanonymous	1e04ced089	Update AGENTS.md (#14733)	2026-07-03 02:08:47 -04:00
comfyanonymous	d3f5ae56b3	Fix cast issue.	2026-07-03 01:37:29 -04:00
Alexis Rolland	e06033fb97	Merge branch 'master' into seedvr2-native-support-v5	2026-07-03 12:36:42 +08:00
Matt Miller	96e0e3585b	security: fix four vulnerabilities (GHSA-779p-m5rp-r4h4) (#14734) ... * security: fix five vulnerabilities (GHSA-779p-m5rp-r4h4) - CVE-2026-56670: force download of SVG/XML responses on /view to prevent stored XSS - CVE-2026-56671: contain /experiment/models/preview reads within the model folder - CVE-2026-56672: stop inline rendering of uploaded /userdata/{file} content - CVE-2026-56673: prevent path traversal in get_annotated_filepath (LoadImage /prompt input) - CVE-2026-56674: reject opaque/null Origin to close the CSRF middleware bypass Adds regression tests under tests-unit/security_test/ covering all five. * security: address review feedback on GHSA-779p fixes - Fix Windows CI failure in test_get_annotated_filepath: compare against os.path.abspath(...) to match the intentional abspath normalization added by the traversal hardening (abspath prepends the drive letter on Windows). - origin_check: narrow the bare `except:` in is_loopback() to ValueError so genuine interrupts aren't swallowed (review nit). - origin_check: guard .port access in is_cross_origin_forbidden() so a malformed/out-of-range port (e.g. Origin: http://127.0.0.1:99999) fails closed with a 403 instead of surfacing an uncaught 500 in the middleware. - server /view: escape backslash/quote in the Content-Disposition filename (RFC 6266 quoted-string) so a filename containing a double quote can't malform the response header. * security: address CodeRabbit review feedback on GHSA-779p tests - test #3: guard the symlink-escape test with a try/except skip so it no longer errors on Windows CI where os.symlink needs elevated privileges / Developer Mode (mirrors the guard in the sibling test #2). - test #5: refresh the stale module docstring to describe the actual /view gating (view_image closure calling folder_paths.is_dangerous_content_type, the normalising check) instead of the bypassable raw set-membership test. * revert(security): drop CVE-2026-56674 Origin: null CSRF change Per maintainer review, the reported CSRF is already mitigated by the pre-existing Sec-Fetch-Site: cross-site check for current browsers, and the null-origin rejection risked breaking legitimate sandboxed-iframe embeds. Restores origin_only_middleware and is_loopback in server.py to their prior state (the Sec-Fetch-Site check is retained) and removes utils/origin_check.py and its regression test. The other four GHSA-779p fixes are unaffected.	2026-07-02 20:44:54 -07:00
comfyanonymous	6d72960989	Fix ruff.	2026-07-02 23:04:52 -04:00
comfyanonymous	c7b2c3b569	Refactors and cleanups.	2026-07-02 22:59:38 -04:00
comfyanonymous	35c1470935	Update AGENTS.md (#14726)	2026-07-02 15:05:55 -04:00
Alexander Piskun	694815f498	[Partner Nodes] chore(Ideogram): remove IdeogramV1 and IdeogramV2 nodes (#14712) ... Signed-off-by: bigcat88 <bigcat88@icloud.com> Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>	2026-07-02 08:35:11 +03:00
comfyanonymous	77d42ed7e9	Remove SeedVR2ProgressiveSampler.	2026-07-01 22:19:37 -04:00
comfyanonymous	f437d87155	Cleanups using AGENTS.md	2026-07-01 22:17:51 -04:00
comfyanonymous	92594ca84c	Update AGENTS.md with more stuff. (#14725)	2026-07-01 21:55:13 -04:00
John Pollock	e595965392	Remove SeedVR2 VAE memory convolution workaround	2026-07-01 15:27:21 -05:00
Silver	2c935de1b1	Fix Qwen3-VL tokenizer crash with custom embeddings (#14713)	2026-07-01 21:15:07 +03:00
comfyanonymous	dd17debce5	Add some more stuff to AGENTS.md (#14704)	2026-07-01 01:51:51 -04:00
comfyanonymous	50e5270b86	Add AGENTS.md (#14696)	2026-06-30 17:40:33 -04:00
comfyanonymous	bb131be9e8	ComfyUI v0.27.0	2026-06-30 17:36:02 -04:00
Daxiong (Lin)	6fca64780c	chore: update workflow templates to v0.11.1 (#14698)	2026-06-30 14:28:09 -07:00
Alexis Rolland	6e11828d10	chore: Update nodes categories (#14674)	2026-07-01 05:20:20 +08:00
Alexander Piskun	b70944e710	[Partner Nodes] feat(Google): add Gemini Video Omni node (#14695)	2026-06-30 17:17:53 -04:00
Matt Miller	1c59659a2f	feat: make asset hashing opt-in via --enable-asset-hashing, off by default (#14663) ... Add a --enable-asset-hashing CLI flag (action=store_true, default False) and plumb it into the two asset-seeder call sites in main.py that previously hardcoded compute_hashes=True (the startup scan and the post-job output enqueue). Local runs now skip blake3 hashing unless the user opts in, avoiding the startup/per-output cost on large models directories while keeping hashing available for asset-portability features. Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>	2026-06-30 14:13:20 -07:00
comfyanonymous	d395813bcd	Fix memory leak related to int8. (#14697)	2026-06-30 14:08:59 -07:00
Alexander Piskun	8fe0243d97	[Partner Nodes] feat(Google): add Nano Banana 2 Lite model (#14693) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-06-30 11:17:23 -07:00
Silver	ba3f697dbb	Add ConditioningMultiply node to nodes.py as an addition to other adj… (#14686)	2026-06-30 16:27:09 +08:00
Comfy Org PR Bot	510ed5c384	Bump comfyui-frontend-package to 1.45.20 (#14684)	2026-06-30 16:25:03 +08:00
comfyanonymous	7851410511	Better and faster int8 lora applying. (#14685)	2026-06-29 21:52:08 -04:00
Daxiong (Lin)	a58473fd9b	chore: update embedded docs to v0.5.6 (#14668) ... Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>	2026-06-29 17:08:06 +08:00
comfyanonymous	79c555ce6b	Fix int8 mm being skipped on offloaded lora weights. (#14669)	2026-06-28 23:52:36 -04:00
Matt Miller	f19735759e	ci: add team-gated Cursor review (thin caller for github-workflows) (#14527)	2026-06-27 23:34:30 -07:00
comfyanonymous	a95e461916	int8 support on turing GPUs. (#14662)	2026-06-27 15:53:11 -07:00
pythongosssss	603d891eaf	Update GLSL node to use ANGLE library (CORE-162) (#13195)	2026-06-27 08:40:31 +08:00