Commit Graph

4140 Commits

Author SHA1 Message Date
strint
aab0e244f7 fix MMAP_MEM_THRESHOLD_GB default 2025-10-23 14:44:51 +08:00
strint
f3c673d086 Merge branch 'master' of https://github.com/siliconflow/ComfyUI into refine_offload 2025-10-22 21:15:28 +08:00
comfyanonymous
9cdc64998f
Only disable cudnn on newer AMD GPUs. (#10437) 2025-10-21 19:15:23 -04:00
strint
98ba311511 add env 2025-10-21 19:06:34 +08:00
strint
80383932ec lazy rm file 2025-10-21 18:00:31 +08:00
strint
08e094ed81 use native mmap 2025-10-21 17:00:56 +08:00
comfyanonymous
560b1bdfca ComfyUI version v0.3.66 2025-10-21 01:12:32 -04:00
strint
fff56de63c fix format 2025-10-21 11:59:59 +08:00
strint
2d010f545c refine code 2025-10-21 11:54:56 +08:00
strint
2f0d56656e refine code 2025-10-21 11:38:17 +08:00
comfyanonymous
b7992f871a
Revert "execution: fold in dependency aware caching / Fix --cache-none with l…" (#10422)
This reverts commit b1467da480.
2025-10-20 19:03:06 -04:00
comfyanonymous
2c2aa409b0
Log message for cudnn disable on AMD. (#10418) 2025-10-20 15:43:24 -04:00
ComfyUI Wiki
a4787ac83b
Update template to 0.2.1 (#10413)
* Update template to 0.1.97

* Update template to 0.2.1
2025-10-20 15:28:36 -04:00
strint
05c2518c6d refact mmap 2025-10-21 02:59:51 +08:00
strint
8aeebbf7ef fix to 2025-10-21 02:27:40 +08:00
strint
49561788cf fix log 2025-10-21 02:03:38 +08:00
strint
e9e1d2f0e8 add mmap tensor 2025-10-21 00:40:14 +08:00
strint
4ac827d564 unload partial 2025-10-20 18:27:38 +08:00
strint
21ebcada1d debug free mem 2025-10-20 16:22:50 +08:00
Christian Byrne
b5c59b763c
Deprecation warning on unused files (#10387)
* only warn for unused files

* include internal extensions
2025-10-19 13:05:46 -07:00
comfyanonymous
b4f30bd408
Pytorch is stupid. (#10398) 2025-10-19 01:25:35 -04:00
comfyanonymous
dad076aee6
Speed up chroma radiance. (#10395) 2025-10-18 23:19:52 -04:00
comfyanonymous
0cf33953a7
Fix batch size above 1 giving bad output in chroma radiance. (#10394) 2025-10-18 23:15:34 -04:00
comfyanonymous
5b80addafd
Turn off cuda malloc by default when --fast autotune is turned on. (#10393) 2025-10-18 22:35:46 -04:00
comfyanonymous
9da397ea2f
Disable torch compiler for cast_bias_weight function (#10384)
* Disable torch compiler for cast_bias_weight function

* Fix torch compile.
2025-10-17 20:03:28 -04:00
comfyanonymous
92d97380bd
Update Python 3.14 installation instructions (#10385)
Removed mention of installing pytorch nightly for Python 3.14.
2025-10-17 18:22:59 -04:00
Alexander Piskun
99ce2a1f66
convert nodes_controlnet.py to V3 schema (#10202) 2025-10-17 14:13:05 -07:00
rattus128
b1467da480
execution: fold in dependency aware caching / Fix --cache-none with loops/lazy etc (#10368)
* execution: fold in dependency aware caching

This makes --cache-none compatiable with lazy and expanded
subgraphs.

Currently the --cache-none option is powered by the
DependencyAwareCache. The cache attempts to maintain a parallel
copy of the execution list data structure, however it is only
setup once at the start of execution and does not get meaninigful
updates to the execution list.

This causes multiple problems when --cache-none is used with lazy
and expanded subgraphs as the DAC does not accurately update its
copy of the execution data structure.

DAC has an attempt to handle subgraphs ensure_subcache however
this does not accurately connect to nodes outside the subgraph.
The current semantics of DAC are to free a node ASAP after the
dependent nodes are executed.

This means that if a subgraph refs such a node it will be requed
and re-executed by the execution_list but DAC wont see it in
its to-free lists anymore and leak memory.

Rather than try and cover all the cases where the execution list
changes from inside the cache, move the while problem to the
executor which maintains an always up-to-date copy of the wanted
data-structure.

The executor now has a fast-moving run-local cache of its own.
Each _to node has its own mini cache, and the cache is unconditionally
primed at the time of add_strong_link.

add_strong_link is called for all of static workflows, lazy links
and expanded subgraphs so its the singular source of truth for
output dependendencies.

In the case of a cache-hit, the executor cache will hold the non-none
value (it will respect updates if they happen somehow as well).

In the case of a cache-miss, the executor caches a None and will
wait for a notification to update the value when the node completes.

When a node completes execution, it simply releases its mini-cache
and in turn its strong refs on its direct anscestor outputs, allowing
for ASAP freeing (same as the DependencyAwareCache but a little more
automatic).

This now allows for re-implementation of --cache-none with no cache
at all. The dependency aware cache was also observing the dependency
sematics for the objects and UI cache which is not accurate (this
entire logic was always outputs specific).

This also prepares for more complex caching strategies (such as RAM
pressure based caching), where a cache can implement any freeing
strategy completely independently of the DepedancyAwareness
requirement.

* main: re-implement --cache-none as no cache at all

The execution list now tracks the dependency aware caching more
correctly that the DependancyAwareCache.

Change it to a cache that does nothing.

* test_execution: add --cache-none to the test suite

--cache-none is now expected to work universally. Run it through the
full unit test suite. Propagate the server parameterization for whether
or not the server is capabale of caching, so that the minority of tests
that specifically check for cache hits can if else. Hard assert NOT
caching in the else to give some coverage of --cache-none expected
behaviour to not acutally cache.
2025-10-17 13:55:15 -07:00
strint
49597bfa3e load remains mmap 2025-10-17 21:43:49 +08:00
strint
6583cc0142 debug load mem 2025-10-17 18:28:25 +08:00
strint
5c3c6c02b2 add debug log of cpu load 2025-10-17 16:33:14 +08:00
Jedrzej Kosinski
d8d60b5609
Do batch_slice in EasyCache's apply_cache_diff (#10376) 2025-10-17 00:39:37 -04:00
comfyanonymous
b1293d50ef
workaround also works on cudnn 91200 (#10375) 2025-10-16 19:59:56 -04:00
comfyanonymous
19b466160c
Workaround for nvidia issue where VAE uses 3x more memory on torch 2.9 (#10373) 2025-10-16 18:16:03 -04:00
Alexander Piskun
bc0ad9bb49
fix(api-nodes): remove "veo2" model from Veo3 node (#10372) 2025-10-16 10:12:50 -07:00
strint
e5ff6a1b53 refine log 2025-10-16 22:47:03 +08:00
strint
71b23d12e4 rm useless log 2025-10-16 22:34:55 +08:00
strint
a207301c25 rm useless log 2025-10-16 22:28:06 +08:00
strint
9352987e9b add log 2025-10-16 22:25:17 +08:00
strint
c1eac555c0 add debug log 2025-10-16 21:42:48 +08:00
strint
2b222962c3 add debug log 2025-10-16 21:42:02 +08:00
strint
f40e00cb35 add detail debug 2025-10-16 19:38:13 +08:00
strint
fa19dd4620 debug offload 2025-10-16 17:00:47 +08:00
strint
6e33ee391a debug error 2025-10-16 16:45:08 +08:00
Rizumu Ayaka
4054b4bf38
feat: deprecated API alert (#10366) 2025-10-16 01:13:31 -07:00
Arjan Singh
55ac7d333c
Bump frontend to 1.28.7 (#10364) 2025-10-15 20:30:39 -07:00
Faych
afa8a24fe1
refactor: Replace manual patches merging with merge_nested_dicts (#10360) 2025-10-15 17:16:09 -07:00
Jedrzej Kosinski
493b81e48f
Fix order of inputs nested merge_nested_dicts (#10362) 2025-10-15 16:47:26 -07:00
comfyanonymous
6b035bfce2
Latest pytorch stable is cu130 (#10361) 2025-10-15 18:48:12 -04:00
Alexander Piskun
74b7f0b04b
feat(api-nodes): add Veo3.1 model (#10357) 2025-10-15 15:41:45 -07:00