5508 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Wei Hai	bf00c39705	Don't instantiate nodes during validation ... Addresses review feedback: the V1 executability check fell back to constructing the node (class_def()) when the FUNCTION method wasn't found on the class. That runs __init__ during validation, so a constructor's side effects or failure could be misreported as invalid_node_definition for an otherwise valid node. Inspect only the class. No core/extra node defines its FUNCTION method on the instance, so this loses no real coverage while removing the side-effect risk. Replace the instance-fallback test with one asserting a node with a raising __init__ but a valid class-level method still passes validation (i.e. it is never instantiated).	2026-06-26 16:04:29 -07:00
Wei Hai	82c954bd2a	Validate that a node is executable before running the prompt ... A node whose FUNCTION points at a method that does not exist (e.g. a typo in a custom node), or a V3 node missing its execute override, was only detected once that node ran -- after every upstream node had already executed. In a multi-node workflow the user waited for the whole graph to run up to the broken node before seeing the error. validate_prompt already walks every node before execution; add an executability check there so the error is reported up front and attributed to the offending node (returned in node_errors), and nothing runs. The check resolves the V1 FUNCTION method on the class (the common case) and falls back to an instance, since the runtime invokes it on an instance and a node may define FUNCTION or its method in __init__. V3 nodes are checked via their existing VALIDATE_CLASS. Add tests for V1 typo, V3 typo, good nodes, and a node whose method is defined in __init__ (must not be falsely rejected).	2026-06-26 15:53:34 -07:00
comfyanonymous	7cb784e0f4	Faster int8. (#14641)	2026-06-25 15:25:47 -07:00
comfyanonymous	1a510f0423	Support int8 models. (#14636)	2026-06-25 11:23:58 -07:00
Daxiong (Lin)	639c8fa788	chore: update workflow templates to v0.10.7 (#14632)	2026-06-25 23:05:34 +08:00
Alexander Piskun	e22f1500f9	[Partner Nodes] feat(ByteDance): add support for SeeDance-2.0-Mini video model (#14626) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-06-25 17:57:04 +03:00
Terry Jia	dac4ea3a80	feat: Bounding boxes canvas and Ideogram JSON prompt (#14537)	2026-06-25 22:34:09 +08:00
Comfy Org PR Bot	b0ec19804f	chore(openapi): sync shared API contract from cloud@4118910 (#14619)	2026-06-25 13:54:53 +08:00
comfyanonymous	64e1d740b8	Add advanced krea 2 model merging node. (#14621)	2026-06-24 20:37:30 -07:00
Yousef R. Gamaleldin	b22d0fb9c0	feat: Add Support For Simple Seed (CORE-295) (#14616)	2026-06-25 09:39:10 +08:00
Alexander Piskun	5236cd02e6	[Partner Nodes] feat(ByteDance): add 4K resolution support for SeeDance 2.0 (#14614) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-06-24 17:57:46 +03:00
Alexander Piskun	cabb7342d1	[Partner Nodes] feat(Grok): add 1080p resolution to Grok Image node (#14612) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-06-24 16:28:56 +03:00
Daxiong (Lin)	12218db68a	Update the template to bring the HH1.1 templates back (#14613)	2026-06-24 21:01:25 +08:00
Alexander Piskun	44955d783b	[Partner Nodes] feat(Alibaba): add support for HappyHorse 1.1 model (#14611) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-06-24 13:37:28 +03:00
Comfy Org PR Bot	1f275fcba6	chore(openapi): sync shared API contract from cloud@363764b (#14607)	2026-06-24 18:22:59 +08:00
comfyanonymous	f6c162ddcf	ComfyUI v0.26.0	2026-06-23 13:22:28 -04:00
Daxiong (Lin)	261bdb7cac	chore: update workflow templates to v0.10.3 (#14603)	2026-06-23 13:06:26 -04:00
Alexander Piskun	4a03056632	[Partner Nodes] revert last 3 PRs: #14597 #14588 #14581 (#14602)	2026-06-23 12:49:16 -04:00
Alexander Piskun	0f949d0faf	[Partner Nodes] feat(Grok): add 1080p resolution to Grok Image node (#14597)	2026-06-23 23:38:46 +08:00
Daxiong (Lin)	d0b640fff7	chore: update workflow templates to v0.10.2 (#14600)	2026-06-23 23:35:21 +08:00
Alexander Piskun	0ba903bd5b	[Partner Nodes] feat(ByteDance): add 4K resolution support for SeeDance 2.0 (#14588) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-06-23 16:18:35 +03:00
Alexander Piskun	0a92ed161e	[Partner Nodes] feat(Alibaba): add support for HappyHorse 1.1 model (#14581) ... Signed-off-by: bigcat88 <bigcat88@icloud.com> Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>	2026-06-23 13:29:46 +03:00
comfyanonymous	b910f4fa2a	More accurate memory usage factor for krea 2. (#14594)	2026-06-23 16:50:48 +08:00
comfyanonymous	833bfb572e	Please try native formats instead of disabling dynamic vram. (#14577)	2026-06-22 21:06:19 -07:00
Jukka Seppänen	2a61015582	feat: Support Krea2 (#14589)	2026-06-22 14:35:00 -07:00
Daxiong (Lin)	6978a466b8	chore: update embedded docs to v0.5.5 (#14585)	2026-06-22 18:29:02 +08:00
Alexis Rolland	b0f9e326af	Add output socket to save nodes (#13866)	2026-06-22 10:15:28 +08:00
comfyanonymous	0d8b7510bd	Update extra model paths example. (#14570)	2026-06-20 19:28:09 -07:00
Alexander Piskun	dc3f8f314a	[Partner Nodes] chore(Google): remove preview versions of models that will be deprecated soon (#14555) ... Signed-off-by: bigcat88 <bigcat88@icloud.com> Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>	2026-06-20 09:13:37 +03:00
Comfy Org PR Bot	d282ef7201	chore(openapi): sync shared API contract from cloud@1aea581 (#14562)	2026-06-20 12:53:10 +08:00
comfyanonymous	e00b55631a	Small anima optimization. (#14557)	2026-06-20 08:05:28 +08:00
Alexis Rolland	69d34f2654	Rename a bunch of nodes (#14547)	2026-06-20 08:01:28 +08:00
Barish Ozbay	cd77c551d6	feat: Context Windows sampling with LTX2 models and IC-LoRa guides (CORE-3) (#13325)	2026-06-20 07:47:31 +08:00
Matt Miller	4e716f7c57	Add jobs-namespace cancel endpoints (POST /api/jobs/{job_id}/cancel, POST /api/jobs/cancel) (#14493) ... * Add jobs-namespace cancel endpoints Add two cancel endpoints under the jobs namespace so a job can be cancelled by id without the caller needing to know whether the job is running or pending, or branching between /interrupt and /queue. - POST /api/jobs/{job_id}/cancel cancels one job by id. Idempotent: an already-finished or unknown id returns 200 {"cancelled": false} rather than an error. - POST /api/jobs/cancel takes {"job_ids": [...]} and cancels a batch. Fail-fast: if any id is unknown the request returns 404 listing the unknown ids and cancels nothing (no partial side effects). Both are state-agnostic and map onto the existing queue mechanics: a running job is interrupted (same path as /interrupt), a pending job is dequeued (same path as /queue {"delete": [...]}). The cancel logic lives in comfy_execution.jobs as pure, unit-tested helpers; the server handlers are thin wrappers. openapi.yaml documents both routes. * fix: resolve review feedback on cancel endpoints - Guard cancel_job() against TOCTOU: when dequeue() returns False the pending job left the queue between snapshot and delete; return CANCEL_UNKNOWN so callers never report cancelled=True for a remove that did not happen. - Validate each job_ids element in the batch cancel endpoint before any queue access; unhashable or non-UUID values now return 400 instead of raising TypeError (500). - Update batch HTTP tests to use canonical UUID ids (required now that the endpoint validates id format) and add tests for the new guards. * fix: make job cancel atomic and best-effort Addresses two cancel races/edges raised in review. Targeted, atomic interrupt. cancel_job's interrupt callback now takes the prompt id and returns whether it fired; the single-cancel route backs it with the new PromptQueue.interrupt_if_running, which checks the running set and signals the interrupt under the queue mutex. This closes the TOCTOU where a pending job that starts executing between the snapshot and dequeue (or a running job that finishes between the snapshot and interrupt) could be missed or, worse, cause an unrelated prompt to be interrupted. The per-prompt interrupt-flag reset in execute_async keeps a finished job from leaking the interrupt onto its successor. Best-effort batch cancel. POST /api/jobs/cancel no longer fails the whole batch with 404 when one id is unknown/finished; such ids are treated as no-ops, so "cancel all" still cancels the in-progress jobs even if some finished between the client's snapshot and the request. Malformed ids are still rejected with 400.	2026-06-19 16:39:35 -07:00
Terry Jia	2ab3816dcf	feat: add Load3DAdvanced node (#14316)	2026-06-20 07:06:55 +08:00
Comfy Org PR Bot	bc11e8a65a	Bump comfyui-frontend-package to 1.45.19 (#14559)	2026-06-19 16:01:34 -07:00
Alexander Piskun	bd39bbf067	[Partner Nodes] fix: respect Retry-After header (#14234) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-06-19 11:32:56 +03:00
Alexander Piskun	5955ddff52	[Partner Nodes] feat(Luma): add support for Luma Rays 3.2 (#14540) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-06-19 08:46:07 +03:00
comfyanonymous	5ef0092af9	Move comfy sys path insert to custom node loading. (#14459)	2026-06-18 22:32:55 -04:00
Matt Miller	94ee49b161	harden: load training-dataset shards with weights_only=True (#14543) ... LoadTrainingDataset was the only torch.load call in the codebase without weights_only=True; comfy/utils.py and comfy/sd1_clip.py already pass it. Recent PyTorch defaults to weights_only=True, so this is defense-in-depth for installs pinned to older PyTorch. Verified a typical shard (latents + standard conditioning) round-trips cleanly under weights_only=True.	2026-06-18 15:30:57 -04:00
Comfy Org PR Bot	16514da2e7	chore(openapi): sync shared API contract from cloud@d10ff72 (#14518)	2026-06-18 17:27:53 +08:00
Daxiong (Lin)	8483c215dc	Update ComfyUI Desktop to Comfy Desktop for consistent product naming (#14533)	2026-06-18 17:24:05 +08:00
Jedrzej Kosinski	f2270f070a	feat: add enable_telemetry CLI feature flag (#14530)	2026-06-17 19:35:05 -07:00
Alexander Piskun	191a75a2cd	[Partner Nodes] feat(Kling): add support for Kling V3-Turbo model (#14528)	2026-06-18 07:54:53 +08:00
comfyanonymous	52257bb435	Add negative prompt to boogu edit node and set min images to 0. (#14529)	2026-06-17 15:42:29 -07:00
Jukka Seppänen	e25c391888	feat: Support Boogu-Image (CORE-308) (#14523)	2026-06-17 14:22:36 -07:00
Jukka Seppänen	ca3dbe206c	Allow using Qwen3-VL as flux2 klein text encoder (again) (#14526)	2026-06-17 08:45:06 -07:00
Jukka Seppänen	a590d60bb1	feat: SCAIL-2 multireference (CORE-310) (#14509) ... * SCAIl-2: support multiref	2026-06-17 16:21:23 +03:00
Alexis Rolland	d202707ff2	Update TripoSplat categories (#14512)	2026-06-17 21:02:45 +08:00
comfyanonymous	f026b01ba5	Update links to new comfyui desktop repo. (#14516)	2026-06-16 20:02:53 -07:00