Commit Graph

5124 Commits

Author SHA1 Message Date
John Pollock
e8402d94b4 Address Trellis VAE decode review feedback 2026-04-20 22:10:15 -05:00
John Pollock
7e9ee82351 Merge remote-tracking branch 'origin/issue_73' into issue_80
# Conflicts:
#	comfy_extras/nodes_trellis2.py
2026-04-20 22:04:24 -05:00
John Pollock
b896abf836 Merge pull request #14 from pollockjj/issue_88
Trellis2: fix texture path resolution and gpu-only host conversion
2026-04-20 18:55:56 -07:00
John Pollock
3546836091 Fix Trellis VAE decode memory management 2026-04-20 20:39:08 -05:00
John Pollock
972f9ca517 Merge remote-tracking branch 'origin/issue_73' into issue_88 2026-04-20 20:00:52 -05:00
John Pollock
da6f3b630f Merge pull request #13 from pollockjj/issue_94
Trellis2: make textured mesh simplification deterministic
2026-04-20 17:57:01 -07:00
John Pollock
2db06439ad Merge pull request #12 from pollockjj/issue_87
Issue 87: fix Trellis2 batch semantics collapse shape and texture samples
2026-04-20 15:24:35 -07:00
John Pollock
de7a811cdd fix: stabilize Trellis2 mesh simplification 2026-04-20 17:22:31 -05:00
John Pollock
0f530ce540 Omit null batch_index from Trellis upsample output 2026-04-20 17:20:57 -05:00
John Pollock
8f3d52fd49 Validate Trellis coord_counts noise metadata 2026-04-20 17:17:50 -05:00
John Pollock
149af779ed Harden Trellis sparse latent seeding 2026-04-20 16:05:10 -05:00
John Pollock
081e7126bd Fail loud on Trellis invalid batch metadata 2026-04-20 15:50:40 -05:00
John Pollock
f309cc1889 Harden Trellis sparse metadata validation 2026-04-20 14:46:23 -05:00
John Pollock
73ca4a452e fix: issue 88 make texture voxel query deterministic 2026-04-20 14:44:45 -05:00
John Pollock
b1f6eb562c fix: issue 88 unify texture paint color path on host 2026-04-20 14:39:15 -05:00
John Pollock
a0e5da14e7 fix: issue 88 texture path resolution and gpu-only host conversion 2026-04-20 14:35:08 -05:00
John Pollock
e95be49e69 Fix Trellis seeded sparse batch semantics 2026-04-20 14:29:07 -05:00
John Pollock
032943a065 Fix Trellis PR review regressions 2026-04-20 12:15:49 -05:00
John Pollock
eaf7d708b0 Fix Trellis2 batched shape and texture semantics 2026-04-20 11:06:04 -05:00
John Pollock
5ec794f423 Merge pull request #11 from pollockjj/issue_76_extract
Trellis2/Hunyuan3d: n>1 batched cascade support
2026-04-19 21:51:27 -07:00
John Pollock
e2bbcece02 Trellis2: inline batched mesh helpers 2026-04-19 23:47:57 -05:00
John Pollock
6e45580707 Trellis2: share batched mesh helpers 2026-04-19 23:33:09 -05:00
John Pollock
849a75c4dc Trellis2: handle empty and batched texture paint paths 2026-04-19 23:23:24 -05:00
John Pollock
353f3d9164 Trellis2/Hunyuan3d: preserve mesh tensor contract in batch mode 2026-04-19 22:55:38 -05:00
John Pollock
eb3ac5ffe4 Trellis2/Hunyuan3d: n>1 batched cascade support
Mesh-producing nodes (VoxelToMeshBasic, VoxelToMesh, VaeDecodeShapeTrellis)
previously stacked per-batch vertex/face tensors with torch.stack, which
failed under batch>1 because per-item meshes have variable shapes. Store
per-item tensors as lists when shapes differ; keep stacked-tensor fast
path when shapes match. Update SaveGLB, PostProcessMesh, and
VaeDecodeTextureTrellis consumers to iterate per-item when input is a
list.

Trellis2Conditioning.execute previously collapsed batched image/mask
input to index 0, yielding identical conditioning for every batch item.
Loop over the batch and produce per-image cond_512/cond_1024/neg_cond
tensors stacked along the batch dim, matching the latent batch size.

batch_size=1 behavior is unchanged. batch_size>1 runs now emit one GLB
per batch item per SaveGLB node and carry per-image conditioning
through the structure/shape/texture cascade.
2026-04-19 22:03:53 -05:00
John Pollock
5d0c6cc7be Merge pull request #10 from pollockjj/issue_74_extract
Trellis2: fix structure batch pruning under shape_rule
2026-04-19 19:57:29 -07:00
John Pollock
e11bd314be Trellis2: guard structure shape_rule pruning to CFG batches 2026-04-19 21:38:45 -05:00
John Pollock
65430280ff Trellis2: slice cond half of x symmetrically under shape_rule pruning 2026-04-19 21:26:48 -05:00
John Pollock
845932eaef Merge pull request #8 from pollockjj/issue_89
Restore Trellis2 clip vision image_size state
2026-04-19 19:17:12 -07:00
John Pollock
3b0adb5ac2 Add Trellis2 image_size restore tests 2026-04-19 21:11:58 -05:00
John Pollock
78d4f27ec0 Match Copilot image_size restore pattern 2026-04-19 21:05:07 -05:00
John Pollock
e91a4659d5 Handle missing Trellis2 image_size restore state 2026-04-19 20:51:22 -05:00
John Pollock
1c91682604 Guard full Trellis2 conditioning image_size restore 2026-04-19 20:49:42 -05:00
John Pollock
718be91a15 Restore Trellis2 clip vision image_size state 2026-04-19 19:53:30 -05:00
John Pollock
d67432586e Merge pull request #7 from pollockjj/issue_86
Issue 86: fix Trellis2 1024 conditioning gate
2026-04-19 17:24:35 -07:00
John Pollock
233f234316 clarify: issue 86 latent-to-pixel resolution mapping 2026-04-19 19:20:14 -05:00
John Pollock
432493c19c fix: issue 86 1024 conditioning gate 2026-04-19 18:23:17 -05:00
Yousef R. Gamaleldin
dad713dc65 Fix return statement 2026-04-12 20:21:19 +02:00
Yousef R. Gamaleldin
18dd46b2eb Merge branch 'master' into trellis2 2026-04-12 20:19:33 +02:00
Yousef Rafat
576befbb4b small final change 2026-04-12 20:14:47 +02:00
comfyanonymous
31283d2892
Implement Ernie Image model. (#13369)
Some checks failed
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Generate Pydantic Stubs from api.comfy.org / generate-models (push) Has been cancelled
2026-04-11 22:29:31 -04:00
comfyanonymous
55ebd287ee
Add a supports_fp64 function. (#13368) 2026-04-11 21:06:36 -04:00
comfyanonymous
a2840e7552
Make ImageUpscaleWithModel node work with intermediate device and dtype. (#13357)
Some checks failed
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
Build package / Build Test (3.10) (push) Has been cancelled
Build package / Build Test (3.11) (push) Has been cancelled
Build package / Build Test (3.12) (push) Has been cancelled
Build package / Build Test (3.13) (push) Has been cancelled
Build package / Build Test (3.14) (push) Has been cancelled
2026-04-10 21:48:26 -04:00
Jukka Seppänen
a134423890
SDPose: resize input always (#13349) 2026-04-10 11:26:55 -10:00
Daxiong (Lin)
b920bdd77d
chore: update workflow templates to v0.9.45 (#13353) 2026-04-10 15:50:40 -04:00
Alexander Piskun
5410ed34f5
fix(api-nodes): fix GrokVideoReferenceNode price badge (#13354)
Some checks are pending
Python Linting / Run Ruff (push) Waiting to run
Python Linting / Run Pylint (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.10, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.11, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-stable (12.1, , linux, 3.12, [self-hosted Linux], stable) (push) Waiting to run
Full Comfy CI Workflow Runs / test-unix-nightly (12.1, , linux, 3.11, [self-hosted Linux], nightly) (push) Waiting to run
Execution Tests / test (macos-latest) (push) Waiting to run
Execution Tests / test (ubuntu-latest) (push) Waiting to run
Execution Tests / test (windows-latest) (push) Waiting to run
Test server launches without errors / test (push) Waiting to run
Unit Tests / test (macos-latest) (push) Waiting to run
Unit Tests / test (ubuntu-latest) (push) Waiting to run
Unit Tests / test (windows-2022) (push) Waiting to run
2026-04-10 08:01:15 -10:00
Yousef Rafat
293a597fdc texture fixes 2026-04-10 19:18:14 +02:00
Yousef Rafat
5cacceaad3 corrected simplification logic 2026-04-10 16:33:19 +02:00
Yousef Rafat
aab8ab6638 comfy ops + color support in postprocess 2026-04-10 16:12:23 +02:00
Yousef Rafat
986b8201da structure generation works 2026-04-10 14:24:07 +02:00