5555 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
彼彼	f185f9ffc5	Merge b0eb165473 into b08debceca	2026-07-06 10:40:28 +00:00
huangfeice	b0eb165473	small note: why JoyImage text-encode nodes emit the bucketed image ... Unlike TextEncodeQwenImageEdit, the JoyImage nodes resize to a discrete bucket, so the target size can't be recomputed downstream. Keep the image output and document that it feeds VAEEncode for a matching-size init latent.	2026-07-06 18:37:45 +08:00
huangfeice	0c18c501a7	refactor: Reuse process_qwen2vl_images for JoyImage preprocessing ... JoyImage differs from the standard process_qwen2vl_images only in using bicubic interpolation and post-resize clamping. I add interpolation and clamp parameters to the shared helper function, allowing JoyImage to directly reuse process_qwen2vl_images without a duplicated implementation. (note for reviewer: this modifies qwen_vl.py. If you feel this approach is not appropriate, we can discuss alternative implementations.)	2026-07-06 17:45:58 +08:00
huangfeice	3e42225399	fix: Use operations.LayerNorm for JoyImage norms ... Replace custom FP32LayerNorm with the standard affine-free operations.LayerNorm.	2026-07-06 17:45:08 +08:00
huangfeice	0eafd9cf0b	fix: Clean up JoyImage model dead code and redundant casts ... Some cleanup of the JoyImage transformer: - FP32LayerNorm/JoyImageModulate: drop constructor params that were never used (dtype/device on the param-free FP32LayerNorm, operations on JoyImageModulate). - modulate_table: init with torch.empty instead of torch.zeros since it is loaded from the state dict, and cast at use with comfy.ops.cast_to_input. - Replace the FeedForward nn.Dropout(0.0) no-op with nn.Identity, keeping the ModuleList slot so state-dict keys are unchanged. - Drop the always-true vec.shape guard (time_proj_dim is always hidden_size*6). - Remove the redundant per-reference .to(device,dtype) in JoyImage._apply_model; the extra_conds cast loop already moves ref_latents to the compute dtype/device. - Drop the redundant .to(xq.device) in the RoPE apply; the freqs are built on the latent device.	2026-07-06 17:43:24 +08:00
huangfeice	1ae7a81901	refactor: Move JoyImage CFG guidance rescale into a model/patch node ... Move JoyImage CFG guidance rescale to a JoyImageGuidanceRescale node that clones the model and calls set_model_sampler_cfg_function, following the RenormCFG (nodes_lumina2.py) precedent for model-specific guidance nodes.	2026-07-06 17:40:11 +08:00
huangfeice	56f9142e95	fix: Detect JoyImage text encoder by clp_type instead of shared Qwen3-VL keys ... JoyImage text_encoder now detects as QWEN3VL_8B and is selected by clip_type == JOYIMAGE. Also copy transformer_options in JoyImage._apply_model like the base method, so the per-block bookkeeping written during forward no longer leaks into the sampler's shared dict.	2026-07-06 17:36:46 +08:00
huangfeice	d763a4d961	Merge remote-tracking branch 'origin/master' into joyimage-edit-pr	2026-07-06 11:30:54 +08:00
Daxiong (Lin)	b08debceca	chore: update embedded docs to v0.5.7 (#14783)	2026-07-06 09:56:09 +08:00
comfyanonymous	000c6b784e	Small speedup for text model sampling. (#14773)	2026-07-05 18:39:24 -07:00
Alexander Piskun	985fb9d6ad	[Partner Nodes] fix(logs-auth): mask authorization headers in logs (#14774) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-05 13:55:29 +03:00
Alexis Rolland	7f287b705e	fix: Bug when setting transparency in color picker (#14764)	2026-07-04 19:13:38 -04:00
comfyanonymous	b7ba504e06	Try to make coderabbit enforce AGENTS.md (#14759)	2026-07-04 14:25:24 -04:00
Silver	6c62ca0b6b	fix: error when embedding is loaded with models using llama_template (#14744)	2026-07-04 17:06:09 +08:00
Robin Huang	3fe9f5fecb	Add CLAUDE.md as symlink to AGENTS.md (#14757)	2026-07-04 13:12:47 +08:00
Alexander Piskun	1073a74976	[Partner Nodes] chore(ByteDance): adjust category name (#14752) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-04 00:01:05 +03:00
comfyanonymous	de1b8f3e8d	Update AGENTS.md (#14738)	2026-07-03 13:08:24 -07:00
Alexander Piskun	77917ed3a6	[Partner Nodes] chore(StabilityAI): remove StabilityAI nodes (#14737) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-03 14:24:21 +03:00
Daxiong (Lin)	a04ebe05c2	chore: update workflow templates to v0.11.2 (#14741)	2026-07-03 19:08:11 +08:00
Alexander Piskun	9764381998	[Partner Nodes] feat(ByteDance): add support for Seed Audio 1.0 (#14731) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-07-03 14:00:10 +03:00
comfyanonymous	1e04ced089	Update AGENTS.md (#14733)	2026-07-03 02:08:47 -04:00
Matt Miller	96e0e3585b	security: fix four vulnerabilities (GHSA-779p-m5rp-r4h4) (#14734) ... * security: fix five vulnerabilities (GHSA-779p-m5rp-r4h4) - CVE-2026-56670: force download of SVG/XML responses on /view to prevent stored XSS - CVE-2026-56671: contain /experiment/models/preview reads within the model folder - CVE-2026-56672: stop inline rendering of uploaded /userdata/{file} content - CVE-2026-56673: prevent path traversal in get_annotated_filepath (LoadImage /prompt input) - CVE-2026-56674: reject opaque/null Origin to close the CSRF middleware bypass Adds regression tests under tests-unit/security_test/ covering all five. * security: address review feedback on GHSA-779p fixes - Fix Windows CI failure in test_get_annotated_filepath: compare against os.path.abspath(...) to match the intentional abspath normalization added by the traversal hardening (abspath prepends the drive letter on Windows). - origin_check: narrow the bare `except:` in is_loopback() to ValueError so genuine interrupts aren't swallowed (review nit). - origin_check: guard .port access in is_cross_origin_forbidden() so a malformed/out-of-range port (e.g. Origin: http://127.0.0.1:99999) fails closed with a 403 instead of surfacing an uncaught 500 in the middleware. - server /view: escape backslash/quote in the Content-Disposition filename (RFC 6266 quoted-string) so a filename containing a double quote can't malform the response header. * security: address CodeRabbit review feedback on GHSA-779p tests - test #3: guard the symlink-escape test with a try/except skip so it no longer errors on Windows CI where os.symlink needs elevated privileges / Developer Mode (mirrors the guard in the sibling test #2). - test #5: refresh the stale module docstring to describe the actual /view gating (view_image closure calling folder_paths.is_dangerous_content_type, the normalising check) instead of the bypassable raw set-membership test. * revert(security): drop CVE-2026-56674 Origin: null CSRF change Per maintainer review, the reported CSRF is already mitigated by the pre-existing Sec-Fetch-Site: cross-site check for current browsers, and the null-origin rejection risked breaking legitimate sandboxed-iframe embeds. Restores origin_only_middleware and is_loopback in server.py to their prior state (the Sec-Fetch-Site check is retained) and removes utils/origin_check.py and its regression test. The other four GHSA-779p fixes are unaffected.	2026-07-02 20:44:54 -07:00
comfyanonymous	35c1470935	Update AGENTS.md (#14726)	2026-07-02 15:05:55 -04:00
kijai	5b6dfcbe46	Add model wrapper and pass transformer options to attention	2026-07-02 13:40:58 +03:00
Alexander Piskun	694815f498	[Partner Nodes] chore(Ideogram): remove IdeogramV1 and IdeogramV2 nodes (#14712) ... Signed-off-by: bigcat88 <bigcat88@icloud.com> Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>	2026-07-02 08:35:11 +03:00
comfyanonymous	92594ca84c	Update AGENTS.md with more stuff. (#14725)	2026-07-01 21:55:13 -04:00
Silver	2c935de1b1	Fix Qwen3-VL tokenizer crash with custom embeddings (#14713)	2026-07-01 21:15:07 +03:00
huangfeice	a00b731054	Merge remote-tracking branch 'origin/master' into joyimage-edit-pr	2026-07-01 18:38:25 +08:00
huangfeice	e29384be0d	Add JoyImageEditPlus multi-image edit support (unify onto Plus-style forward) ... JoyImageEditPlus is the multi-image (1-6 reference images) variant of JoyImageEdit, trained from the same base. Its diffusers transformer shares byte-identical weight structure with the single-image variant (894 keys, zero rename) but injects references differently: instead of the single-image slot-stack (stack refs + noise into a 6D tensor and rotate on the frame dim, which forces all items to share resolution), each reference is independently patchified and concatenated on the sequence dim with per-image temporal-offset 3D RoPE, allowing references at different resolutions. Since the single-image port is not yet upstream, this unifies both variants onto the Plus-style forward rather than keeping two paths; single-image is now the ref=1 special case. Verified numerically: at ref=1 with equal resolution the new path's RoPE is bit-identical to the old slot-stack layout, and the transformer output matches the diffusers Plus reference (fp32, incl. the different-resolution case). ComfyUI runs cond/uncond in one forward with a shared reference configuration, so the diffusers Plus batched RoPE, padding attention_mask, and dedicated attention processor are unnecessary here: the unified forward reuses the existing unbatched _apply_rotary_emb and JoyImageAttention. Confirmed equivalent to the diffusers batched+mask path for a single sample. - comfy/ldm/joyimage/model.py: forward takes ref_latents and builds components=[target, ref0, ...]; per-component patchify + temporal-offset RoPE; output keeps only the target segment. Old single-grid RoPE removed. - comfy/model_base.py: JoyImage drops the slot-stack / frame-rotation / shape-equality path in _apply_model, passing ref_latents straight to the transformer. Guidance-rescale and the reference_latents requirement are kept. - comfy/text_encoders/joyimage.py: the image template emits one vision block per reference (N = image count); N=1 is byte-for-byte the old template. - comfy_extras/nodes_joyimage.py: add TextEncodeJoyImageEditPlus with optional image1..image6 inputs, each bucket-resized and VAE-encoded into the reference_latents list. Detection, supported_models, and sd.py need no changes: the identical weight structure routes both variants through image_model="joyimage".	2026-07-01 18:36:43 +08:00
comfyanonymous	dd17debce5	Add some more stuff to AGENTS.md (#14704)	2026-07-01 01:51:51 -04:00
comfyanonymous	50e5270b86	Add AGENTS.md (#14696)	2026-06-30 17:40:33 -04:00
comfyanonymous	bb131be9e8	ComfyUI v0.27.0	2026-06-30 17:36:02 -04:00
Daxiong (Lin)	6fca64780c	chore: update workflow templates to v0.11.1 (#14698)	2026-06-30 14:28:09 -07:00
Alexis Rolland	6e11828d10	chore: Update nodes categories (#14674)	2026-07-01 05:20:20 +08:00
Alexander Piskun	b70944e710	[Partner Nodes] feat(Google): add Gemini Video Omni node (#14695)	2026-06-30 17:17:53 -04:00
Matt Miller	1c59659a2f	feat: make asset hashing opt-in via --enable-asset-hashing, off by default (#14663) ... Add a --enable-asset-hashing CLI flag (action=store_true, default False) and plumb it into the two asset-seeder call sites in main.py that previously hardcoded compute_hashes=True (the startup scan and the post-job output enqueue). Local runs now skip blake3 hashing unless the user opts in, avoiding the startup/per-output cost on large models directories while keeping hashing available for asset-portability features. Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>	2026-06-30 14:13:20 -07:00
comfyanonymous	d395813bcd	Fix memory leak related to int8. (#14697)	2026-06-30 14:08:59 -07:00
Alexander Piskun	8fe0243d97	[Partner Nodes] feat(Google): add Nano Banana 2 Lite model (#14693) ... Signed-off-by: bigcat88 <bigcat88@icloud.com>	2026-06-30 11:17:23 -07:00
Silver	ba3f697dbb	Add ConditioningMultiply node to nodes.py as an addition to other adj… (#14686)	2026-06-30 16:27:09 +08:00
Comfy Org PR Bot	510ed5c384	Bump comfyui-frontend-package to 1.45.20 (#14684)	2026-06-30 16:25:03 +08:00
comfyanonymous	7851410511	Better and faster int8 lora applying. (#14685)	2026-06-29 21:52:08 -04:00
Daxiong (Lin)	a58473fd9b	chore: update embedded docs to v0.5.6 (#14668) ... Co-authored-by: Alexis Rolland <alexisrolland@hotmail.com>	2026-06-29 17:08:06 +08:00
comfyanonymous	79c555ce6b	Fix int8 mm being skipped on offloaded lora weights. (#14669)	2026-06-28 23:52:36 -04:00
Matt Miller	f19735759e	ci: add team-gated Cursor review (thin caller for github-workflows) (#14527)	2026-06-27 23:34:30 -07:00
comfyanonymous	a95e461916	int8 support on turing GPUs. (#14662)	2026-06-27 15:53:11 -07:00
pythongosssss	603d891eaf	Update GLSL node to use ANGLE library (CORE-162) (#13195)	2026-06-27 08:40:31 +08:00
comfyanonymous	470ac36a0a	Fix int8 loras causing lower quality requant with wrong settings. (#14650) ... * Update comfy-kitchen * Support requantizing with same settings as orig quant.	2026-06-26 16:41:29 -07:00
comfyanonymous	7cb784e0f4	Faster int8. (#14641)	2026-06-25 15:25:47 -07:00
comfyanonymous	1a510f0423	Support int8 models. (#14636)	2026-06-25 11:23:58 -07:00
Daxiong (Lin)	639c8fa788	chore: update workflow templates to v0.10.7 (#14632)	2026-06-25 23:05:34 +08:00